emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Phil Estival <pe@7d.nz>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Adam Porter <adam@alphapapa.net>,
	emacs-devel@gnu.org, Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: package submission : ob-sql-session
Date: Mon, 4 Nov 2024 19:16:01 +0100	[thread overview]
Message-ID: <abfc8716-0e06-42a9-a3f3-9f27c206bd84@7d.nz> (raw)
In-Reply-To: <87msizq7g3.fsf@localhost>



* [2024-10-20 14:34] Ihor Radchenko:
> Phil Estival <pe@7d.nz> writes:
> 
>>>> ob-sql-session :
>>>> - handle large results
>>>> - has :results tables
>>>> - accept header variables (:var)
>>>> - accept sql client shell commands
>>>> - keep login parameters
>>>> - prompt only for blank connection parameters
>>>> - can use `with-environment-variables'
>>>> - provide some more tests
> 
> Have you considered integrating it into ob-sql itself?
> If not, what are the obstacles?
> 

Hello Ihor,

yes I have. It grows ob-sql by approximately 300 lines.
There are rooms for improvements.
https://github.com/flintforge/ob-sql-session/blob/main/ob-sql.el

Current status :
- added support of :sessions to ob-sql.el, by merging ob-sql-session.el
- restored support for sqlite (even if there is ob-sqlite.el)
- added composite types for options
- moved options from org-babel to a new group org-babel-sql

TODO :
- use `org-babel-prep-session'
- verify headers and columns options
- check use and storage of :dbconnection
- minimize writings of temporary files
- Tests

Cheers,

Phil


  reply	other threads:[~2024-11-04 18:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <b1ca8e9e-be59-4740-8ea8-c3ebd4ba56fe@7d.nz>
     [not found] ` <daabaaef-70a0-4e4a-b0f9-64e8c05dcb21@alphapapa.net>
2024-09-17 10:00   ` packages submissions : ob-sql-session and org-blog Phil Estival
2024-09-17 22:25     ` Adam Porter
2024-09-18  1:41       ` package submission : ob-sql-session Phil Estival
2024-10-20 12:34         ` Ihor Radchenko
2024-11-04 18:16           ` Phil Estival [this message]
2024-11-09 14:43             ` Ihor Radchenko
2024-11-11 10:51               ` patch : ob-sql :session Phil Estival
2024-11-11 15:57                 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abfc8716-0e06-42a9-a3f3-9f27c206bd84@7d.nz \
    --to=pe@7d.nz \
    --cc=adam@alphapapa.net \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).