emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: David Masterson <dsmasterson@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Is this proper time format?
Date: Sat, 10 Jun 2023 17:01:25 -0700	[thread overview]
Message-ID: <SJ0PR03MB5455A8B8CF932CBB3D656FDAA257A@SJ0PR03MB5455.namprd03.prod.outlook.com> (raw)
In-Reply-To: <87v8fvtz1u.fsf@localhost> (Ihor Radchenko's message of "Sat, 10 Jun 2023 10:02:53 +0000")

Ihor Radchenko <yantar92@posteo.net> writes:

> David Masterson <dsmasterson@gmail.com> writes:
>
>>>> Maybe I'm not explicit enough.  In section 8.1 of the Org 9.6 manual is
>>>> a subsection "Time/Date Range" that *implies* times are supported in
>>>> ranges by the use of words "time" and "timestamp" when, above, you're
>>>> saying they are undefined (unsupported?) for now.  I'm merely saying
>>>> adjust the manual to remove the implication.
>>>
>>> Please check the manual from main branch of Org. It has more text:
>>
>> I disagree. I cloned Org from Savannah and made the attached patch
>> file from the main branch.  First time for me attaching a file to a
>> message.   Does it work for you?
>
> Yes. Though it would be better to attach the diff with proper (.diff or
> .patch) extension.

I hope you saw that I provided a "patch,txt" file in a following message
(forgot about the naming convention -- been a long time...)

> Even better would be providing commit message and formatting the patch
> properly. See https://orgmode.org/worg/org-contribute.html#first-patch
> Not mandatory though - I can format things properly on your behalf.

Thank you.  I haven't "patched" anything on Savannah and assumed I might
have to do the GNU copyright assignment.  For this, I thought it would
be easy for you.

>> -  Two timestamps connected by =--= denote a range.
>> +  Two timestamps connected by =--= denote a date range.  NOTE: time is
>> +  not specified in these timestamps -- just dates,
>
> I'd avoid this NOTE. Time is actually allowed, but agenda does nothing
> with it. But only agenda. The rest of Org will handle date ranges like
> <2023-06-10 Sat 14:00>--<2023-06-12 Mon 18:00> correctly.
>
>> -#+cindex: timestamps
>> -#+cindex: ranges, time
>> -#+cindex: date stamps
>> -#+cindex: deadlines
>> -#+cindex: scheduling
>
> Is there any particular reason why you removed index entries here and
> further in the diff?

No, there isn't.  I think what happened here is that I noticed section
8.1 in org-guide and org-manual were almost (but not quite) the same. I
assumed (incorrectly?) that they were supposed to be the same, but got
out of sync.  So I made my patch to org-guide and then replaced section
8.1 in org-manual with the one from org-guide.  I think these "cindex"
statements got dropped because of that.  If they are important in
org-manual, but not org-guide, then please put them back.

>>    A timestamp may contain a /repeater interval/, indicating that it
>>    applies not only on the given date, but again and again after
>> -  a certain interval of N hours (h), days (d), weeks (w), months (m),
>> -  or years (y).  The following shows up in the agenda every Wednesday:
>> +  a certain interval of N days (d), weeks (w), months (m), or years
>> +  (y).  The following shows up in the agenda every Wednesday:
>
> Why did you remove hours?

Oh!  Another difference between org-guide and org-manual that came over
in trying to resync the two.

>>    For more complex date specifications, Org mode supports using the
>> -  special expression diary entries implemented in the
>> -  [[info:emacs#Special Diary Entries][Emacs Calendar package]][fn:20].
>> -  For example, with optional time:
>> +  special expression diary entries implemented in the Emacs Calendar
>> +  package.  For example, with optional time:
>
> Why did you remove the links and the footnote?

Again, another diff between org-guide and org-manual, :-\

I'm relooking at this patch.  Testing finds that these work in the
timegrid agenda as expected:

* <2023-02-03 Thu 10:00-11:00>--<2023-02-04 Fri 10:00-11:00>
** Can't mark one done -- you have to mark them all done
*** Kind of expected for this form
* <2023-02-03 Thu 10:00-11:00 +1d>
** Can you limit the number of repeats? If so, how?
** Marking it DONE removes current one from agenda
*** reasonable

I have to rethink section 8.1.  With the above in mind, 8.1 is not quite
right, but it's more subtle than I thought.  Not sure how in the weeds
it should get for a user's manual. 

-- 
David Masterson


  reply	other threads:[~2023-06-11  0:07 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 16:58 Is this proper time format? David Masterson
2023-06-05 19:52 ` Ihor Radchenko
2023-06-05 21:03   ` David Masterson
2023-06-06  6:08     ` Ihor Radchenko
2023-06-06 18:01       ` David Masterson
2023-06-06 23:52         ` Samuel Wales
2023-06-07  5:40           ` David Masterson
2023-06-08 10:33         ` Ihor Radchenko
2023-06-08 23:09           ` David Masterson
2023-06-09  7:36             ` Ihor Radchenko
2023-06-10  2:34               ` David Masterson
2023-06-10 10:02                 ` Ihor Radchenko
2023-06-11  0:01                   ` David Masterson [this message]
2023-06-11  9:31                     ` Ihor Radchenko
2023-06-12  0:19                       ` David Masterson
2023-06-12 10:44                         ` Ihor Radchenko
2023-06-11  6:20                   ` David Masterson
2023-06-11  9:45                     ` Ihor Radchenko
2023-06-12  0:16                       ` David Masterson
2023-06-12 11:00                         ` Ihor Radchenko
2023-06-12 18:02                           ` David Masterson
2023-06-13  9:41                             ` Ihor Radchenko
2023-06-14  6:16                               ` David Masterson
2023-06-14 11:01                                 ` Ihor Radchenko
2023-06-15  3:35                                   ` David Masterson
2023-06-15 11:07                                     ` Ihor Radchenko
2023-06-15 16:04                                       ` David Masterson
2023-06-16  9:38                                         ` Ihor Radchenko
2023-06-17  0:54                                           ` David Masterson
2023-06-17 12:33                                             ` Ihor Radchenko
2023-06-18  3:57                                               ` David Masterson
2023-06-18 10:42                                                 ` Ihor Radchenko
2023-06-18 19:05                                                   ` David Masterson
2023-06-18 20:53                                                     ` Ihor Radchenko
2023-06-19 18:13                                                       ` David Masterson
2023-06-10  2:40               ` David Masterson
2023-06-23 12:18           ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR03MB5455A8B8CF932CBB3D656FDAA257A@SJ0PR03MB5455.namprd03.prod.outlook.com \
    --to=dsmasterson@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).