From: Ihor Radchenko <yantar92@posteo.net>
To: David Masterson <dsmasterson@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Is this proper time format?
Date: Sun, 18 Jun 2023 10:42:12 +0000 [thread overview]
Message-ID: <878rch9hmj.fsf@localhost> (raw)
In-Reply-To: <SJ0PR03MB54557235EF81BF04A33CF4F4A25EA@SJ0PR03MB5455.namprd03.prod.outlook.com>
David Masterson <dsmasterson@gmail.com> writes:
>> See the attached final draft.
>
> What's the command to save the attachment? It doesn't look like a mime
> attachment to me,
In message-mode:
C-c C-a runs the command mml-attach-file (found in message-mode-map),
which is an autoloaded interactive native-compiled Lisp function in
‘mml.el’.
It is bound to C-c RET f and C-c C-a.
>> I also slightly adjusted the wording and fixed list indentation in
>> one of description list items.
>
> One minor note -- I think of datestamp & timestamp as one word each
> while 'date range' & 'time range' are two words each. Unless you've got
> other reasons, I'd follow this convention. I think I see one 'cindex'
> that has 'timerange'.
I left the incorrectly spelled 'timerange' cindex entry on purpose.
In Org, we have variables `org-agenda-timerange-leaders' and
`org-agenda-remove-timeranges-from-blocks'. So, in Info-mode, some
people may search index for 'timerange' instead of 'time range'. Again,
the purpose is helping searchability.
I now applied to patch onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d50956e48
>> Please note that with this patch your total contribution is approaching
>> non-trivial 15LOC. Further patches will require FSF copyright
>> assignment.
>
> You got the number via some 'git' command?? If I get to doing more, I
> will do the copyright assignment -- I just never thought I'd make much
> changes.
Not exactly. There is git command to find total number of changed LOCs:
<https://github.com/yantar92/emacs-config/blob/master/config.org#detect-fsf-contribution-status-of-sender-for-org-ml>
(shell-command-to-string
(format "cd ~/Git/org-mode/; git log --author=\"%s\" --pretty=tformat: --numstat main | gawk '{ add += $1; subs += $2; loc += $1 - $2 } END { printf \"+l: %%s -l: %%s total: %%s\", add, subs, loc }' -"
(downcase (if (string-match-p email all-committers)
email sender))))
However, it will count all the LOCs, not just non-trivial.
By raw number of LOCs, your patch is indeed over 15LOC. However, part of
the patch is my text or syncing org-manual and org-guide texts. Those
changes are trivial.
So, I judged that the patch is still acceptable without FSF assignment.
But it will be the limit.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
Applied.
next prev parent reply other threads:[~2023-06-18 10:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 16:58 Is this proper time format? David Masterson
2023-06-05 19:52 ` Ihor Radchenko
2023-06-05 21:03 ` David Masterson
2023-06-06 6:08 ` Ihor Radchenko
2023-06-06 18:01 ` David Masterson
2023-06-06 23:52 ` Samuel Wales
2023-06-07 5:40 ` David Masterson
2023-06-08 10:33 ` Ihor Radchenko
2023-06-08 23:09 ` David Masterson
2023-06-09 7:36 ` Ihor Radchenko
2023-06-10 2:34 ` David Masterson
2023-06-10 10:02 ` Ihor Radchenko
2023-06-11 0:01 ` David Masterson
2023-06-11 9:31 ` Ihor Radchenko
2023-06-12 0:19 ` David Masterson
2023-06-12 10:44 ` Ihor Radchenko
2023-06-11 6:20 ` David Masterson
2023-06-11 9:45 ` Ihor Radchenko
2023-06-12 0:16 ` David Masterson
2023-06-12 11:00 ` Ihor Radchenko
2023-06-12 18:02 ` David Masterson
2023-06-13 9:41 ` Ihor Radchenko
2023-06-14 6:16 ` David Masterson
2023-06-14 11:01 ` Ihor Radchenko
2023-06-15 3:35 ` David Masterson
2023-06-15 11:07 ` Ihor Radchenko
2023-06-15 16:04 ` David Masterson
2023-06-16 9:38 ` Ihor Radchenko
2023-06-17 0:54 ` David Masterson
2023-06-17 12:33 ` Ihor Radchenko
2023-06-18 3:57 ` David Masterson
2023-06-18 10:42 ` Ihor Radchenko [this message]
2023-06-18 19:05 ` David Masterson
2023-06-18 20:53 ` Ihor Radchenko
2023-06-19 18:13 ` David Masterson
2023-06-10 2:40 ` David Masterson
2023-06-23 12:18 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rch9hmj.fsf@localhost \
--to=yantar92@posteo.net \
--cc=dsmasterson@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).