From: andrea@fedeli.eu
To: yantar92@posteo.net
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Error in data input and output format for org-columns--summary-estimate
Date: Fri, 18 Aug 2023 08:20:24 +0200 [thread overview]
Message-ID: <RZKPM0$B6EDA4B4C26DCC0E05EF77DE4DB90286@fedeli.eu> (raw)
In-Reply-To: <87pm3nnvim.fsf@localhost>
[-- Attachment #1: Type: text/plain, Size: 3305 bytes --]
IR > May you share your changes?
Sure!
Here they are: In these slices I take the upper part of the fork (where in case, assuming a small-big usage convention ;)) as that is the value that surely testify the effort estimation overrun. Being so, at the time of this writing I just realized the use of pcase is likely replaceable by a simpler (car (last (mapcar...))) call :).
Cheers,
Andrea
Job: diff -bwi org-clock.el{.old,}
720c720,723
< (let* ((effort-in-minutes (org-duration-to-minutes org-clock-effort))
---
> (let* ((effort-in-minutes
> (pcase (mapcar #'org-duration-to-minutes (split-string org-clock-effort "-"))
> (`(,_ ,value) value)
> (`(,value) value)))
828c831,833
< (let ((effort-in-minutes (org-duration-to-minutes org-clock-effort))
---
> (let ((effort-in-minutes (pcase (mapcar #'org-duration-to-minutes (split-string org-clock-effort "-"))
> (`(,_ ,value) value)
> (`(,value) value)))
Da emacs-orgmode-bounces+andrea=fedeli.eu@gnu.org
A andrea@fedeli.eu
Cc emacs-orgmode@gnu.org
Data Wed, 16 Aug 2023 10:15:13 +0000
Oggetto Re: [BUG] Error in data input and output format for org-columns--summary-estimate
andrea@fedeli.eu writes:
> Howdy!
> I'm back to a previous element partially discussed as I found other org places where the duration had to be adapted to be able to deal with ranges: org-clock-get-clock-string and
> org-clock-notify-once-if-expired, both in og-clock.el; both get into action if you have a task you estimated and for which you're now tracking development time (quite handy, I have to say, as you're immediately warned you've running beyond estimations. For those two functions, I have introduced a similar change to the one I did originally to go from the basic string-to number on split-string to org-duration to minutes. Thanks, Sant Ignucius, for the debug-on-entry feature :))
May you share your changes? I am not sure if I fully understand what and
why you did without seeing the diff.
> Two considerations here:
> 1. I understand the fact that est+ doesn't have to necessarily be associated with effort, but it is quite clear from the docs which is the intent with which it was introduced: the only provided example is on times, and there we have to consider that time is expressed in durations.
> What I mean is that it does NOT make much sense to me to tell users the effort is to be written as 3d if given as a single value, and it has to be rewritten as 3-5 if we want to say "in a fork of 3 to 5 days", especially if somewhere else some other duration unit is used..
It should not. The reason `org-columns--summary-estimate' uses
split-string is because it may have to work with recursively calculated
estimates from subtrees. EFFORT property itself does not officially
support ranges.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
[-- Attachment #2: Type: text/html, Size: 4874 bytes --]
next prev parent reply other threads:[~2023-08-18 6:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 12:46 [BUG] Error in data input and output format for org-columns--summary-estimate andrea
2023-07-09 14:17 ` Ihor Radchenko
2023-07-09 14:33 ` andrea
2023-07-10 8:57 ` Ihor Radchenko
[not found] ` <RXR2XJ$F3602788F3665C159BAF986799B1995C@fedeli.eu>
2023-07-14 9:02 ` Ihor Radchenko
2023-07-14 11:39 ` andrea
2023-07-18 9:10 ` Ihor Radchenko
2023-08-15 15:53 ` andrea
2023-08-16 10:15 ` Ihor Radchenko
2023-08-18 6:20 ` andrea [this message]
2023-08-18 9:29 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='RZKPM0$B6EDA4B4C26DCC0E05EF77DE4DB90286@fedeli.eu' \
--to=andrea@fedeli.eu \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).