emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug in definition of org-encode-time
@ 2022-07-24  8:45 Kenneth Stuart
  2022-07-24  9:41 ` Ihor Radchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Kenneth Stuart @ 2022-07-24  8:45 UTC (permalink / raw)
  To: emacs-orgmode

Hello,

Macro `org-encode-time` (lisp/org-macs.el +1395) does not get defined
for emacs >= 27.1 as the top level if statement is missing its ELSE clause.

#+begin_src elisp
(if (version< emacs-version "27.1")
    (defmacro org-encode-time (&rest time)
      (if (cdr time)
          `(encode-time ,@time)
        `(apply #'encode-time ,@time)))
  (if (ignore-errors (with-no-warnings (encode-time '(0 0 0 1 1 1971))))
      (defmacro org-encode-time (&rest time)
        (pcase (length time) ; Emacs-29 since d75e2c12eb
          (1 `(encode-time ,@time))
          ((or 6 9) `(encode-time (list ,@time)))
          (_ (error "`org-encode-time' may be called with 1, 6, or 9 arguments but %d given"
                    (length time)))))
    (defmacro org-encode-time (&rest time)
      (pcase (length time)
        (1 `(encode-time ,@time))
        (6 `(encode-time (list ,@time nil -1 nil)))
        (9 `(encode-time (list ,@time)))
        (_ (error "`org-encode-time' may be called with 1, 6, or 9 arguments but %d given"
                  (length time)))))) //MISSING ELSE//)
#+end_src

I'm assuming it should be:

#+begin_src diff
  diff --git a/lisp/org-macs.el b/lisp/org-macs.el
index 5931dd260..bbdacbdf8 100644
--- a/lisp/org-macs.el
+++ b/lisp/org-macs.el
@@ -1403,14 +1403,14 @@ nil, just return 0."
           (1 `(encode-time ,@time))
           ((or 6 9) `(encode-time (list ,@time)))
           (_ (error "`org-encode-time' may be called with 1, 6, or 9 arguments but %d given"
-                    (length time)))))
-    (defmacro org-encode-time (&rest time)
+                    (length time))))))
+  (defmacro org-encode-time (&rest time)
       (pcase (length time)
         (1 `(encode-time ,@time))
         (6 `(encode-time (list ,@time nil -1 nil)))
         (9 `(encode-time (list ,@time)))
         (_ (error "`org-encode-time' may be called with 1, 6, or 9 arguments but %d given"
-                  (length time)))))))
+                  (length time))))))
 (put 'org-encode-time 'function-documentation
      "Compatibility and convenience helper for `encode-time'.
 May be called with 9 components list (SECONDS ... YEAR IGNORED DST ZONE)
#+end_src

regards
Ken


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-24 11:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-24  8:45 Bug in definition of org-encode-time Kenneth Stuart
2022-07-24  9:41 ` Ihor Radchenko
2022-07-24 10:06   ` Kenneth Stuart
2022-07-24 11:37     ` Kenneth Stuart

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).