emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Paul Sexton <psexton@xnet.co.nz>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-depend only blocks null->TODO state change
Date: Wed, 11 Aug 2010 09:57:29 +0200	[thread overview]
Message-ID: <E6B4630D-5D92-44D0-9C9C-29D6D90CC649@gmail.com> (raw)
In-Reply-To: <loom.20100727T034424-868@post.gmane.org>

Hi Paul,

can you please explain the logical error and the patch?  Thanks!

- Carsten

On Jul 27, 2010, at 3:52 AM, Paul Sexton wrote:

> In agenda view, tasks which are supposed to be blocked using org- 
> depend's
> :BLOCKER: property, are not actually blocked and do not show up  
> dimmed.
> This is because of a logic error in 'org-depend-block-undo', hopefully
> fixed below.
> index eb38aa0..84fa1a7 100644
> --- a/d:/paul/dotemacs/site-lisp/org/contrib/lisp/org-depend.el
> +++ b/d:/paul/dotemacs/site-lisp/org/contrib/lisp/org-depend-new.el
> @@ -224,12 +224,13 @@ this ID property, that entry is also checked."
>         blocker blockers bl p1
>         (proceed-p
>          (catch 'return
> -           (unless (eq type 'todo-state-change)
> -             ;; We are not handling this kind of change
> -             (throw 'return t))
> -           (unless (and (not from) (member to org-not-done-keywords))
> -             ;; This is not a change from nothing to TODO, ignore it
> -             (throw 'return t))
> +            ;; If this is not a todo state change, or if this entry  
> is
> +            ;; DONE, do not block
> +            (when (or (not (eq type 'todo-state-change))
> +                      (member from (cons 'done org-done-keywords))
> +                      (member to (cons 'todo org-not-done-keywords))
> +                      (not to))
> +              (throw 'return t))
>            ;; OK, the plan is to switch from nothing to TODO
>            ;; Lets see if we will allow it.  Find the BLOCKER property
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

      reply	other threads:[~2010-08-11  7:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27  1:52 [PATCH] org-depend only blocks null->TODO state change Paul Sexton
2010-08-11  7:57 ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E6B4630D-5D92-44D0-9C9C-29D6D90CC649@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=psexton@xnet.co.nz \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).