From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] org-depend only blocks null->TODO state change Date: Wed, 11 Aug 2010 09:57:29 +0200 Message-ID: References: Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=45747 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oj6Bq-0006mB-75 for emacs-orgmode@gnu.org; Wed, 11 Aug 2010 03:57:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oj6Bp-0000ac-5M for emacs-orgmode@gnu.org; Wed, 11 Aug 2010 03:57:34 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:57012) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oj6Bp-0000aR-12 for emacs-orgmode@gnu.org; Wed, 11 Aug 2010 03:57:33 -0400 Received: by eydd26 with SMTP id d26so4645205eyd.0 for ; Wed, 11 Aug 2010 00:57:31 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Paul Sexton Cc: emacs-orgmode@gnu.org Hi Paul, can you please explain the logical error and the patch? Thanks! - Carsten On Jul 27, 2010, at 3:52 AM, Paul Sexton wrote: > In agenda view, tasks which are supposed to be blocked using org- > depend's > :BLOCKER: property, are not actually blocked and do not show up > dimmed. > > This is because of a logic error in 'org-depend-block-undo', hopefully > fixed below. > > index eb38aa0..84fa1a7 100644 > --- a/d:/paul/dotemacs/site-lisp/org/contrib/lisp/org-depend.el > +++ b/d:/paul/dotemacs/site-lisp/org/contrib/lisp/org-depend-new.el > @@ -224,12 +224,13 @@ this ID property, that entry is also checked." > blocker blockers bl p1 > (proceed-p > (catch 'return > - (unless (eq type 'todo-state-change) > - ;; We are not handling this kind of change > - (throw 'return t)) > - (unless (and (not from) (member to org-not-done-keywords)) > - ;; This is not a change from nothing to TODO, ignore it > - (throw 'return t)) > + ;; If this is not a todo state change, or if this entry > is > + ;; DONE, do not block > + (when (or (not (eq type 'todo-state-change)) > + (member from (cons 'done org-done-keywords)) > + (member to (cons 'todo org-not-done-keywords)) > + (not to)) > + (throw 'return t)) > > ;; OK, the plan is to switch from nothing to TODO > ;; Lets see if we will allow it. Find the BLOCKER property > > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten