emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Michael Hohmuth <Michael.Hohmuth@amd.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug in org-find-entry-with-id
Date: Fri, 19 Jun 2009 12:17:32 +0200	[thread overview]
Message-ID: <E1A398D1-9C89-4875-AD95-DAE116920ECE@gmail.com> (raw)
In-Reply-To: <3yztz2cbkoa.fsf@sieglinde.amd.com>


On Jun 19, 2009, at 12:08 PM, Michael Hohmuth wrote:

> Hi there,
>
> I've attached a critical bug fix for org-find-entry-with-id (relative
> to org.el in org-6.27a).
>
> Without this fix, following ID links to hidden headlines is impossible
> because org-back-to-heading always jumps back to the last visible
> headline.  This breaks many things, including org-depend.el.

Ouch!

Thank you *very* much for report and analysis.

I have applied this patch.

- Carsten

>
> Kind regards,
> Michael
> --  
> Michael Hohmuth, AMD Operating System Research Center, Dresden,  
> Germany
> michael.hohmuth@amd.com, www.amd64.org
>
> --- org.el	2009/06/19 10:04:48	1.1
> +++ org.el	2009/06/19 10:05:13
> @@ -12027,7 +12027,7 @@
> 	(when (re-search-forward
> 	       (concat "^[ \t]*:ID:[ \t]+" (regexp-quote id) "[ \t]*$")
> 	       nil t)
> -	  (org-back-to-heading)
> +	  (org-back-to-heading t)
> 	  (point))))))
>
> ;;;; Timestamps
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

      reply	other threads:[~2009-06-19 10:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-19 10:08 Bug in org-find-entry-with-id Michael Hohmuth
2009-06-19 10:17 ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1A398D1-9C89-4875-AD95-DAE116920ECE@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=Michael.Hohmuth@amd.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).