* Bug in org-find-entry-with-id
@ 2009-06-19 10:08 Michael Hohmuth
2009-06-19 10:17 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Michael Hohmuth @ 2009-06-19 10:08 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
Hi there,
I've attached a critical bug fix for org-find-entry-with-id (relative
to org.el in org-6.27a).
Without this fix, following ID links to hidden headlines is impossible
because org-back-to-heading always jumps back to the last visible
headline. This breaks many things, including org-depend.el.
Kind regards,
Michael
--
Michael Hohmuth, AMD Operating System Research Center, Dresden, Germany
michael.hohmuth@amd.com, www.amd64.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 289 bytes --]
--- org.el 2009/06/19 10:04:48 1.1
+++ org.el 2009/06/19 10:05:13
@@ -12027,7 +12027,7 @@
(when (re-search-forward
(concat "^[ \t]*:ID:[ \t]+" (regexp-quote id) "[ \t]*$")
nil t)
- (org-back-to-heading)
+ (org-back-to-heading t)
(point))))))
;;;; Timestamps
[-- Attachment #3: Type: text/plain, Size: 204 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug in org-find-entry-with-id
2009-06-19 10:08 Bug in org-find-entry-with-id Michael Hohmuth
@ 2009-06-19 10:17 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2009-06-19 10:17 UTC (permalink / raw)
To: Michael Hohmuth; +Cc: emacs-orgmode
On Jun 19, 2009, at 12:08 PM, Michael Hohmuth wrote:
> Hi there,
>
> I've attached a critical bug fix for org-find-entry-with-id (relative
> to org.el in org-6.27a).
>
> Without this fix, following ID links to hidden headlines is impossible
> because org-back-to-heading always jumps back to the last visible
> headline. This breaks many things, including org-depend.el.
Ouch!
Thank you *very* much for report and analysis.
I have applied this patch.
- Carsten
>
> Kind regards,
> Michael
> --
> Michael Hohmuth, AMD Operating System Research Center, Dresden,
> Germany
> michael.hohmuth@amd.com, www.amd64.org
>
> --- org.el 2009/06/19 10:04:48 1.1
> +++ org.el 2009/06/19 10:05:13
> @@ -12027,7 +12027,7 @@
> (when (re-search-forward
> (concat "^[ \t]*:ID:[ \t]+" (regexp-quote id) "[ \t]*$")
> nil t)
> - (org-back-to-heading)
> + (org-back-to-heading t)
> (point))))))
>
> ;;;; Timestamps
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-19 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-19 10:08 Bug in org-find-entry-with-id Michael Hohmuth
2009-06-19 10:17 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).