From: Nathaniel Flath <flat0103@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: org-mode List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-agenda tag completion works with ido
Date: Thu, 13 Jul 2017 10:07:02 -0700 [thread overview]
Message-ID: <CAPrg3HARqWPav4FVLfE2qfjsG8PQx6_dbFenZVanhxBbB5rV7g@mail.gmail.com> (raw)
In-Reply-To: <87bmopdkcy.fsf@kyleam.com>
[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]
On Wed, Jul 12, 2017 at 9:35 PM, Kyle Meyer <kyle@kyleam.com> wrote:
> Nathaniel Flath <flat0103@gmail.com> writes:
>
>> After upgrading to the latest org-mode, tag completion when filtering
>> in the agenda was broken - I had to fully enter the tag, despite using
>> ido (eg I would have a tag 'home', and 'ho-enter' would not compete).
>
> [...]
>
>> * org-agenda.el (org-agenda-filter-by-tag):
>> (org-agenda-filter-by-tag): pass t to require-match argument of completing-read.
>
> ^ repeated function name
>
Removed that in patch attached.
>> This causes ido-mode to complete tags properly when inputting partial matches, rather
>> that just sending the typed input.
>
> Wouldn't this mean that, in general, ido won't complete partial matches
> properly when require-match is nil? That doesn't sound right.
>
> I'm not an ido user, but testing with
>
> (require 'ido-ubiquitous)
> (ido-ubiquitous-mode 1)
>
> partial completion seems to work fine when I hit tab after calling
> org-agenda-filter-by-tag. Are you using ido-ubiquitous, or are you
> using some other package to get ido completion for non-file/buffer
> completion?
The issue is that that 'tab' is required - in the previous version of
org, this was not required and 'enter' would do the completion for
you.
>
> In this particular case, your change looks OK because I think all useful
> values should be in the collection. But I don't understand why you're
> not able to do partial completion without this change. Are you running
> into the same issue everywhere else that completing-read is called with
> a nil value for require-match?
I haven't checked everywhere else - presumably.
>
> --
> Kyle
[-- Attachment #2: 0001-completing-read-in-org-agenda-filter-by-tag-complete.patch --]
[-- Type: application/octet-stream, Size: 1089 bytes --]
From 002c8674ec9db51ed2cc16e73b43d02aa844ea00 Mon Sep 17 00:00:00 2001
From: Nathaniel Flath <flat0103@gmail.com>
Date: Wed, 12 Jul 2017 17:15:04 -0700
Subject: [PATCH] completing-read in org-agenda-filter-by-tag completes
partially-entered input
* org-agenda.el:
(org-agenda-filter-by-tag): pass t to require-match argument of completing-read.
This causes ido-mode to complete tags properly when inputting partial matches, rather
that just sending the typed input.
---
lisp/org-agenda.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 9ac4f65..20d128d 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7496,7 +7496,7 @@ also press `-' or `+' to switch between filtering and excluding."
(org-global-tags-completion-table)))
(let ((completion-ignore-case t))
(setq tag (completing-read
- "Tag: " org-global-tags-completion-table))))
+ "Tag: " org-global-tags-completion-table nil t))))
(cond
((eq char ?\r)
(org-agenda-filter-show-all-tag)
--
2.10.1 (Apple Git-78)
next prev parent reply other threads:[~2017-07-13 17:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 0:23 [PATCH] org-agenda tag completion works with ido Nathaniel Flath
2017-07-13 4:35 ` Kyle Meyer
2017-07-13 17:07 ` Nathaniel Flath [this message]
2017-07-13 18:02 ` Kyle Meyer
2017-07-13 18:14 ` Kyle Meyer
2017-07-13 18:19 ` Nathaniel Flath
2017-07-13 19:03 ` Nathaniel Flath
2017-07-13 19:19 ` Kyle Meyer
2017-07-13 19:52 ` Nathaniel Flath
2017-07-13 20:31 ` Kyle Meyer
2017-07-16 16:42 ` Nathaniel Flath
2017-07-16 21:03 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPrg3HARqWPav4FVLfE2qfjsG8PQx6_dbFenZVanhxBbB5rV7g@mail.gmail.com \
--to=flat0103@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).