From: Kyle Meyer <kyle@kyleam.com>
To: Nathaniel Flath <flat0103@gmail.com>
Cc: org-mode List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-agenda tag completion works with ido
Date: Thu, 13 Jul 2017 14:02:31 -0400 [thread overview]
Message-ID: <878tjsdxl4.fsf@kyleam.com> (raw)
In-Reply-To: <CAPrg3HARqWPav4FVLfE2qfjsG8PQx6_dbFenZVanhxBbB5rV7g@mail.gmail.com>
Nathaniel Flath <flat0103@gmail.com> writes:
[...]
>> I'm not an ido user, but testing with
>>
>> (require 'ido-ubiquitous)
>> (ido-ubiquitous-mode 1)
>>
>> partial completion seems to work fine when I hit tab after calling
>> org-agenda-filter-by-tag. Are you using ido-ubiquitous, or are you
>> using some other package to get ido completion for non-file/buffer
>> completion?
>
> The issue is that that 'tab' is required - in the previous version of
> org, this was not required and 'enter' would do the completion for
> you.
I'm only using tab right after calling org-agenda-filter-by-tag to get
to the initial tag prompt, following the instructions in the minibuffer.
Isn't that always needed?
Here is how I'm testing (with emacs -Q):
* list TODOs with the agenda (org-agenda, follow by "t")
* on an entry, hit "/" for org-agenda-filter-by-tag
* hit tab to get to the tag prompt
Once in the prompt, I can select a partial completion by just hitting
enter.
I've executed the above steps with two setups:
release_8.3.6/org-completion-use-ido and release_9.0.9/ido-ubiquitous.
I couldn't spot any differences. Hitting enter for partial completion
worked in both cases.
>> In this particular case, your change looks OK because I think all useful
>> values should be in the collection. But I don't understand why you're
>> not able to do partial completion without this change. Are you running
>> into the same issue everywhere else that completing-read is called with
>> a nil value for require-match?
>
> I haven't checked everywhere else - presumably.
It'd be good to figure out why you're seeing different behavior than I
am. Perhaps the steps I list above aren't the right steps to trigger
it. Or maybe you have some non-default ido configuration. Or maybe the
difference comes from an ido version mismatch. (I'm using the ido from
Emacs 25.2 and ido-ubiquitous checked out at v3.14-4-ga1c2965.)
As it stands, I can't reproduce the problem described in your commit
message.
--
Kyle
next prev parent reply other threads:[~2017-07-13 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 0:23 [PATCH] org-agenda tag completion works with ido Nathaniel Flath
2017-07-13 4:35 ` Kyle Meyer
2017-07-13 17:07 ` Nathaniel Flath
2017-07-13 18:02 ` Kyle Meyer [this message]
2017-07-13 18:14 ` Kyle Meyer
2017-07-13 18:19 ` Nathaniel Flath
2017-07-13 19:03 ` Nathaniel Flath
2017-07-13 19:19 ` Kyle Meyer
2017-07-13 19:52 ` Nathaniel Flath
2017-07-13 20:31 ` Kyle Meyer
2017-07-16 16:42 ` Nathaniel Flath
2017-07-16 21:03 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tjsdxl4.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=flat0103@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).