emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Anthony Lander <anthony@landerfamily.ca>
To: Alan Schmitt <alan.schmitt@polytechnique.org>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: small patch to org-mac-link (grab selected messages in Mail.app)
Date: Fri, 6 Jun 2014 10:58:11 -0400	[thread overview]
Message-ID: <CAPgrogcdBAH7fGe6j7YWZXOKm890kE+XmLnGb+A=Vrne8jAvsA@mail.gmail.com> (raw)
In-Reply-To: <m261khyo84.fsf@polytechnique.org>

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

Hi Alan,

Thanks for the patch. It looks OK to me - can you please go ahead and apply
it to the file? Also, feel free to add your name to the contributor list at
the top of the file.

Thanks!

  -Anthony



On Wed, Jun 4, 2014 at 6:15 AM, Alan Schmitt <alan.schmitt@polytechnique.org
> wrote:

> Hello,
>
> Please find attached a small patch to org-mac-link.el for the functions
> creating links to messages in Mail.app.
>
> The problem was that calling the org-mac-message-insert-selected would
> always add a spurious first link with empty url and an escaped quote as
> text. It would also leave another escaped quote at the end of the text
> of the real link.
>
> The patch makes sure that no extra empty line is created during the
> AppleScript call, and removes the escaped quotes around the whole value
> returned from AppleScript. I have left the code that removes additional
> quotes around individual links if they are there, but I don't think it's
> needed (I don't see how they could occur there).
>
> Best,
>
> Alan
>
>

[-- Attachment #2: Type: text/html, Size: 1510 bytes --]

next prev parent reply	other threads:[~2014-06-06 14:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 10:15 small patch to org-mac-link (grab selected messages in Mail.app) Alan Schmitt
2014-06-06 14:58 ` Anthony Lander [this message]
2014-06-07  7:35   ` Alan Schmitt
2014-06-07 13:32     ` Anthony Lander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPgrogcdBAH7fGe6j7YWZXOKm890kE+XmLnGb+A=Vrne8jAvsA@mail.gmail.com' \
    --to=anthony@landerfamily.ca \
    --cc=alan.schmitt@polytechnique.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).