emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Valentin Wüstholz" <wuestholz@gmail.com>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>,
	Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.
Date: Tue, 16 Aug 2011 23:33:21 +0200	[thread overview]
Message-ID: <CAPVO5rxqEWXHvjDN+ay1xaos-CWDMGgNjVvqZFdwzhOYThd2Og@mail.gmail.com> (raw)
In-Reply-To: <871uwljhch.fsf@gnu.org>

Hi Bastien,

thanks for the comments. I'll certainly keep that in mind for future
patches. Maybe that's something that could be added to the
corresponding worg page (http://orgmode.org/worg/org-contribute.html).

Best regards,

Valentin


On Tue, Aug 16, 2011 at 9:18 PM, Bastien <bzg@altern.org> wrote:
> Hi Valentin,
>
> Valentin Wüstholz <wuestholz@gmail.com> writes:
>
>>> Meanwhile, could you please reformat a bit your patch (no more than 80
>>> columns, no parents on their own line), add a commit message followed
>>> by TINYCHANGE (unless you have signed FSF papers already) and use git
>>> format-patch for the output?
>>
>> Sure. I have attached the output.
>
> Thanks for making the effort of reformatting patches this way.  With
> so many patches coming in, it's really important that everyone tries to
> stick to immediately-applicable patches.
>
>> From c64f1b607d937c6484dfc18110125b1287175ac4 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Valentin=20W=FCstholz?= <wuestholz@gmail.com>
>> Date: Tue, 9 Aug 2011 21:28:56 +0200
>> Subject: [PATCH] Preserve indentation of explicitly indented lines in example blocks
>>
>> * lisp/org.el (org-indent-line-function): Made the way in which example blocks are
>>   indented more flexible.
>
> This line a bit long and should be something like:
>
>> * lisp/org.el (org-indent-line-function): Made the way in which
>>   example blocks are indented more flexible.
>
> Use M-q in change-log-mode on the ChangeLog to fill the region
> correctly.
>
>> Before: Lines in example blocks were indented like the surrounding begin and end
>> delimiters.
>> After: By default, lines in example blocks are indented like the surrounding begin and end
>> delimiters, unless the user explicitly indents them differently.
>
> Here again, I prefer <80 characters lines, but that's less important
> than the ChangeLog entry.
>
> Thanks,
>
> --
>  Bastien
>

next prev parent reply	other threads:[~2011-08-16 21:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08 19:48 [PATCH] org.el: Preserve indentation of manually indented lines in example blocks Valentin Wüstholz
2011-08-08 20:40 ` Nicolas Goaziou
2011-08-08 21:04   ` Valentin Wüstholz
2011-08-08 22:33     ` Nicolas Goaziou
2011-08-09  5:42       ` Valentin Wüstholz
2011-08-09  9:18         ` Nicolas Goaziou
2011-08-09 12:10           ` Valentin Wüstholz
2011-08-09 13:21             ` Nicolas Goaziou
2011-08-09 19:37               ` Valentin Wüstholz
2011-08-10  9:00                 ` Nicolas Goaziou
2011-08-16 17:21                   ` Bastien
2011-08-16 19:18                 ` Bastien
2011-08-16 21:33                   ` Valentin Wüstholz [this message]
2011-08-17  9:40                     ` Bastien
2011-08-17 18:32                       ` Valentin Wüstholz
2011-08-18 16:44                         ` Bastien
2011-08-26  6:45                           ` Valentin Wüstholz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPVO5rxqEWXHvjDN+ay1xaos-CWDMGgNjVvqZFdwzhOYThd2Og@mail.gmail.com \
    --to=wuestholz@gmail.com \
    --cc=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).