From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Valentin_W=C3=BCstholz?= Subject: Re: [PATCH] org.el: Preserve indentation of manually indented lines in example blocks. Date: Tue, 16 Aug 2011 23:33:21 +0200 Message-ID: References: <87sjpbmyb1.fsf@gmail.com> <87obzzmt2p.fsf@gmail.com> <878vr3lz8c.fsf@gmail.com> <87vcu6lnzy.fsf@gmail.com> <871uwljhch.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:36447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QtRGa-000645-7z for emacs-orgmode@gnu.org; Tue, 16 Aug 2011 17:33:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QtRGZ-0001eT-3O for emacs-orgmode@gnu.org; Tue, 16 Aug 2011 17:33:44 -0400 Received: from mail-iy0-f175.google.com ([209.85.210.175]:57603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QtRGY-0001eG-VS for emacs-orgmode@gnu.org; Tue, 16 Aug 2011 17:33:43 -0400 Received: by iyn15 with SMTP id 15so439177iyn.6 for ; Tue, 16 Aug 2011 14:33:41 -0700 (PDT) In-Reply-To: <871uwljhch.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode , Nicolas Goaziou Hi Bastien, thanks for the comments. I'll certainly keep that in mind for future patches. Maybe that's something that could be added to the corresponding worg page (http://orgmode.org/worg/org-contribute.html). Best regards, Valentin On Tue, Aug 16, 2011 at 9:18 PM, Bastien wrote: > Hi Valentin, > > Valentin W=C3=BCstholz writes: > >>> Meanwhile, could you please reformat a bit your patch (no more than 80 >>> columns, no parents on their own line), add a commit message followed >>> by TINYCHANGE (unless you have signed FSF papers already) and use git >>> format-patch for the output? >> >> Sure. I have attached the output. > > Thanks for making the effort of reformatting patches this way. =C2=A0With > so many patches coming in, it's really important that everyone tries to > stick to immediately-applicable patches. > >> From c64f1b607d937c6484dfc18110125b1287175ac4 Mon Sep 17 00:00:00 2001 >> From: =3D?UTF-8?q?Valentin=3D20W=3DFCstholz?=3D >> Date: Tue, 9 Aug 2011 21:28:56 +0200 >> Subject: [PATCH] Preserve indentation of explicitly indented lines in ex= ample blocks >> >> * lisp/org.el (org-indent-line-function): Made the way in which example = blocks are >> =C2=A0 indented more flexible. > > This line a bit long and should be something like: > >> * lisp/org.el (org-indent-line-function): Made the way in which >> =C2=A0 example blocks are indented more flexible. > > Use M-q in change-log-mode on the ChangeLog to fill the region > correctly. > >> Before: Lines in example blocks were indented like the surrounding begin= and end >> delimiters. >> After: By default, lines in example blocks are indented like the surroun= ding begin and end >> delimiters, unless the user explicitly indents them differently. > > Here again, I prefer <80 characters lines, but that's less important > than the ChangeLog entry. > > Thanks, > > -- > =C2=A0Bastien >