* Patch org-timer-set-timer
@ 2013-09-03 9:59 Roberto Huelga
2013-09-06 14:02 ` Bastien
0 siblings, 1 reply; 2+ messages in thread
From: Roberto Huelga @ 2013-09-03 9:59 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 117 bytes --]
Patch proposal for org-timer-set-timer
Thanks for your great work, and I hope be sending all in the correct format.
[-- Attachment #1.2: Type: text/html, Size: 163 bytes --]
[-- Attachment #2: 0001-Timer-play-a-sound-as-configured-by-org-clock-sound-.patch --]
[-- Type: application/octet-stream, Size: 1331 bytes --]
From 3accc5c389ca001231c514a49bb58906b57f94f8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Roberto=20Huelga=20D=C3=ADaz?= <rhuelga@gmail.com>
Date: Tue, 3 Sep 2013 11:53:15 +0200
Subject: [PATCH] Timer: play a sound as configured by `org-clock-sound'
actualy only beep
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* lisp/org-timer.el (org-timer-set-timer): use the variable
`org-clock-sound' when calling `org-notify'
When org-notify second parameter is t we only get the standard beep.
Evaluating with coma we can use different sounds for differents
running timers, as `org-clock-sound' was set when
`org-timer-set-timer' get execute
Patch proposal by Roberto Huelga Díaz.
TINYCHANGE
---
lisp/org-timer.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-timer.el b/lisp/org-timer.el
index 2351c4c..2ea1c35 100644
--- a/lisp/org-timer.el
+++ b/lisp/org-timer.el
@@ -429,7 +429,7 @@ replace any running timer."
(run-with-timer
secs nil `(lambda ()
(setq org-timer-current-timer nil)
- (org-notify ,(format "%s: time out" hl) t)
+ (org-notify ,(format "%s: time out" hl) ,org-clock-sound)
(setq org-timer-timer-is-countdown nil)
(org-timer-set-mode-line 'off)
(run-hooks 'org-timer-done-hook))))
--
1.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Patch org-timer-set-timer
2013-09-03 9:59 Patch org-timer-set-timer Roberto Huelga
@ 2013-09-06 14:02 ` Bastien
0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2013-09-06 14:02 UTC (permalink / raw)
To: Roberto Huelga; +Cc: emacs-orgmode
Hi Roberto,
Roberto Huelga <rhuelga@gmail.com> writes:
> Patch proposal for org-timer-set-timer
Applied, thanks!
> Thanks for your great work, and I hope be sending all in the correct
> format.
Nearly perfect: you just need to start sentences with capitalized
letters and to end them with "." (full-stop). Nitpicking, but that
saves me a lot of time when preparing the Emacs merge.
Thanks again,
--
Bastien
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-06 14:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-03 9:59 Patch org-timer-set-timer Roberto Huelga
2013-09-06 14:02 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).