emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
To: Leo Butler <Leo.Butler@umanitoba.ca>
Cc: Ihor Radchenko <yantar92@posteo.net>,
	Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink
Date: Wed, 13 Mar 2024 08:16:12 +0100	[thread overview]
Message-ID: <CAO48Bk91MpdN-MzpxdcFW-2n8fUF3bdCZ+yLGa8L2=k4rn6ghA@mail.gmail.com> (raw)
In-Reply-To: <87plvzqjhv.fsf@t14.reltub.ca>

[-- Attachment #1: Type: text/plain, Size: 2942 bytes --]

Hi Leo,

I really don't have anything to object to the original patch. I support the
need to circumvent the "\begin-or-end{frame} inside frame" problem and
using orgframe is a clean way of doing so.
My only concern is the _default_ value for `org-beamer-frame-environment'.
If we set it to "frame", we only need to customise it in the file local
variables in files where it needs to be changed and we catch all flies in a
stroke:

Situation 1: presentation has no "\begin-or-end{frame} inside frame" -> no
extra stuff in file local variables AND newenvironment is not generated AND
frames are between \begin{frame} and \end{frame}
Situation 2: presentation needs to circumvent "\begin-or-end{frame} inside
frame" -> set local variable in file AND newenvironment is generated AND
frame is changed where it is strictly necessary,

Cheers, /PA

On Tue, 12 Mar 2024 at 21:32, Leo Butler <Leo.Butler@umanitoba.ca> wrote:

> On Tue, Mar 12 2024, Ihor Radchenko <yantar92@posteo.net> wrote:
>
> > Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
> >
> >> Jup, of course. If you look in org-lint.el, one of the cases that would
> >> trigger a message is when the frame environment uses "frame" directly
> and
> >> there is a \begin{frame} in the org.
> >> Line 1522 onwards in org-lint.el
> >
> > (1)
> > Sure, but we should not demand users to run org-lint. Ideally, exporting
> > any valid Org file should work.
> > The fact that the presence of \begin{frame} breaks beamer is a technical
> > detail users should better not be bothered with. That's why we added the
> > orgframe construct.
> >
> > (2)
> > On the other hand, it is clear that Org mode users are unwilling to
> > tolerate too much of machine generated latex output. So, going further
> > and trying to generate unique orgframe environments might not be ideal.
> >
> > The current approach is a balance between the above considerations.
> >
> > AFAIU, what you propose is reverting the orgframe code; that goes
> > against the first point.
>
> Current git HEAD allows a user like Pedro to effectively turn off the
> orgframe code via
>
> (setq org-beamer-frame-environment "frame")
>
> or an equivalent.
>
> >
> > What I proposed is to reduce the amount of machine-generated code by
> > using `org-beamer-frame-environment' only when strictly necessary.
>
> Attached is a patch that limits the use of
> `org-beamer-frame-environment' to those frames that contain either
> \begin{frame} or \end{frame} in their body.
>
> This has the nice side-effect that one can include example frames
> generated by Org without causing an error (previously, Org exported
> latex that would not compile). See the attachments.
>
> Leo
>
>

-- 
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet

[-- Attachment #2: Type: text/html, Size: 4041 bytes --]

  reply	other threads:[~2024-03-13  7:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 11:33 The orgframe construct in the Beamer exporter as a default needs a rethink Pedro Andres Aranda Gutierrez
2024-03-01 16:03 ` Fraga, Eric
2024-03-01 16:17   ` Pedro Andres Aranda Gutierrez
2024-03-01 17:23   ` Pedro Andres Aranda Gutierrez
2024-03-01 23:11 ` [BUG] " Leo Butler
2024-03-02  6:24   ` Pedro Andres Aranda Gutierrez
2024-03-02  6:39     ` Pedro Andres Aranda Gutierrez
2024-03-02  8:25       ` Pedro Andres Aranda Gutierrez
2024-03-02 12:22         ` Ihor Radchenko
2024-03-02 19:03           ` Pedro Andres Aranda Gutierrez
2024-03-04 11:10             ` Ihor Radchenko
2024-03-09  8:33               ` Pedro Andres Aranda Gutierrez
2024-03-12 12:33                 ` Ihor Radchenko
2024-03-12 20:32                   ` Leo Butler
2024-03-13  7:16                     ` Pedro Andres Aranda Gutierrez [this message]
2024-03-13 13:12                       ` Ihor Radchenko
2024-03-14 15:49                         ` Leo Butler
2024-03-15 14:02                           ` Ihor Radchenko
2024-03-16 13:12                             ` Leo Butler
2024-03-16 23:24                               ` Leo Butler
2024-03-17  9:53                                 ` Ihor Radchenko
2024-03-17 13:18                                   ` Leo Butler
2024-03-17 14:36                                     ` Ihor Radchenko
2024-03-02 12:21       ` Ihor Radchenko
2024-03-02 12:20   ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO48Bk91MpdN-MzpxdcFW-2n8fUF3bdCZ+yLGa8L2=k4rn6ghA@mail.gmail.com' \
    --to=paaguti@gmail.com \
    --cc=Leo.Butler@umanitoba.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).