From: Matt Price <moptop99@gmail.com>
To: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] don't always restore previous window configuration?
Date: Sun, 25 Nov 2018 15:56:24 -0500 [thread overview]
Message-ID: <CAN_Dec_yCd6RPsaE1zZSkbNthv8JcN2sPxn57xYL-ykWvbfZwQ@mail.gmail.com> (raw)
In-Reply-To: <87d0qt1qem.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 2182 bytes --]
On Sun, Nov 25, 2018, 4:02 AM Nicolas Goaziou <mail@nicolasgoaziou.fr wrote:
> Hello,
>
> Matt Price <moptop99@gmail.com> writes:
>
> > Then I'm sorry for the noise (and also for this aside!). Magit, or git,
> or
> > some other tool was doing something quite strange and disturbing, and I
> am
> > now seeing these remotes in my repo:
> > dup /tmp/tmp-orgtest/org-annex-testoRSq4r/ (fetch)
> > dup /tmp/tmp-orgtest/org-annex-testoRSq4r/ (push)
> > origin https://code.orgmode.org/bzg/org-mode.git (fetch)
> > origin https://code.orgmode.org/bzg/org-mode.git (push)
> > original /tmp/tmp-orgtest/org-annex-testrgbPft/ (fetch)
> > original /tmp/tmp-orgtest/org-annex-testrgbPft/ (push)
>
> My bad. It seems "test-org-annex.el" messes with "git init". Since
> I don't have git-annex command, these tests are usually skipped, so
> I hadn't noticed.
>
> > I'm not sure. Until now only Eric and I had commented on this feature. I
> > will say that I will probably never go back to the old behavior, but
> maybe
> > there are people who prefer it. I believe there are 6 possible options
> for
> > org-src-window-setup (though only 5 are listed in the defcustom
> definition,
> > I think that org-src-switch-to-buffer also recognizes 'silently). It may
> be
> > that some of those options only make sense if the window config is
> restored
> > after closing the src buffer.
> >
> > ~org-src--saved-window-config~ is only used in this function, so instead
> of
> > adding a new variable we could just get rid of an old one :-).
>
> IMO, the only value for `org-src-window-setup' where it might be
> meaningful to preserve windows excursion is `reorganize-frame', since it
> can disturb a lot the configuration used before editing the block.
> However, the docstring disagrees: "When exiting the edit buffer, return
> to one window."
>
> Therefore, I suggest to simply do not restore previous configuration in
> Org 9.3, and document it in incompatible changes. It will leave time to
> test it and complain if something is not right.
>
> WDYT?
>
Personally I prefer your solution. Would you like me to make a new patch or
would you prefer to do this yourself?
>
[-- Attachment #2: Type: text/html, Size: 3317 bytes --]
next prev parent reply other threads:[~2018-11-25 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 19:09 don't always restore previous window configuration? Matt Price
2018-11-23 6:31 ` Eric S Fraga
2018-11-23 15:20 ` [PATCH] " Matt Price
2018-11-24 10:55 ` Nicolas Goaziou
2018-11-24 15:24 ` Matt Price
2018-11-25 9:02 ` Nicolas Goaziou
2018-11-25 20:56 ` Matt Price [this message]
2018-11-25 22:30 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN_Dec_yCd6RPsaE1zZSkbNthv8JcN2sPxn57xYL-ykWvbfZwQ@mail.gmail.com \
--to=moptop99@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).