From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Price Subject: Re: [PATCH] don't always restore previous window configuration? Date: Sun, 25 Nov 2018 15:56:24 -0500 Message-ID: References: <87zhu0nw36.fsf@gmail.com> <87tvk62199.fsf@nicolasgoaziou.fr> <87d0qt1qem.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c97ad6057b837493" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gR1Si-0005S9-6K for emacs-orgmode@gnu.org; Sun, 25 Nov 2018 15:57:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gR1Se-00012o-AZ for emacs-orgmode@gnu.org; Sun, 25 Nov 2018 15:57:02 -0500 Received: from mail-it1-x141.google.com ([2607:f8b0:4864:20::141]:51642) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gR1Sc-0000yM-9m for emacs-orgmode@gnu.org; Sun, 25 Nov 2018 15:56:58 -0500 Received: by mail-it1-x141.google.com with SMTP id x19so25277041itl.1 for ; Sun, 25 Nov 2018 12:56:54 -0800 (PST) In-Reply-To: <87d0qt1qem.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org Mode --000000000000c97ad6057b837493 Content-Type: text/plain; charset="UTF-8" On Sun, Nov 25, 2018, 4:02 AM Nicolas Goaziou Hello, > > Matt Price writes: > > > Then I'm sorry for the noise (and also for this aside!). Magit, or git, > or > > some other tool was doing something quite strange and disturbing, and I > am > > now seeing these remotes in my repo: > > dup /tmp/tmp-orgtest/org-annex-testoRSq4r/ (fetch) > > dup /tmp/tmp-orgtest/org-annex-testoRSq4r/ (push) > > origin https://code.orgmode.org/bzg/org-mode.git (fetch) > > origin https://code.orgmode.org/bzg/org-mode.git (push) > > original /tmp/tmp-orgtest/org-annex-testrgbPft/ (fetch) > > original /tmp/tmp-orgtest/org-annex-testrgbPft/ (push) > > My bad. It seems "test-org-annex.el" messes with "git init". Since > I don't have git-annex command, these tests are usually skipped, so > I hadn't noticed. > > > I'm not sure. Until now only Eric and I had commented on this feature. I > > will say that I will probably never go back to the old behavior, but > maybe > > there are people who prefer it. I believe there are 6 possible options > for > > org-src-window-setup (though only 5 are listed in the defcustom > definition, > > I think that org-src-switch-to-buffer also recognizes 'silently). It may > be > > that some of those options only make sense if the window config is > restored > > after closing the src buffer. > > > > ~org-src--saved-window-config~ is only used in this function, so instead > of > > adding a new variable we could just get rid of an old one :-). > > IMO, the only value for `org-src-window-setup' where it might be > meaningful to preserve windows excursion is `reorganize-frame', since it > can disturb a lot the configuration used before editing the block. > However, the docstring disagrees: "When exiting the edit buffer, return > to one window." > > Therefore, I suggest to simply do not restore previous configuration in > Org 9.3, and document it in incompatible changes. It will leave time to > test it and complain if something is not right. > > WDYT? > Personally I prefer your solution. Would you like me to make a new patch or would you prefer to do this yourself? > --000000000000c97ad6057b837493 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


= On Sun, Nov 25, 2018, 4:02 AM Nicolas Goaziou <mail@nicolasgoaziou.fr wrote:
Hello,

Matt Price <moptop99@gmail.com> writes:

> Then I'm sorry for the noise (and also for this aside!).=C2=A0 Mag= it, or git, or
> some other tool was doing something quite strange and disturbing, and = I am
> now seeing these remotes in my repo:
> dup=C2=A0 =C2=A0 =C2=A0 =C2=A0/tmp/tmp-orgtest/org-annex-testoRSq4r/ (= fetch)
> dup=C2=A0 =C2=A0 =C2=A0/tmp/tmp-orgtest/org-annex-testoRSq4r/ (push) > origin=C2=A0 https://code.orgmode.org/bzg/o= rg-mode.git (fetch)
> origin=C2=A0 https://code.orgmode.org/bzg/o= rg-mode.git (push)
> original=C2=A0 =C2=A0 =C2=A0 =C2=A0 /tmp/tmp-orgtest/org-annex-testrgb= Pft/ (fetch)
> original=C2=A0 =C2=A0 =C2=A0 =C2=A0 /tmp/tmp-orgtest/org-annex-testrgb= Pft/ (push)

My bad. It seems "test-org-annex.el" messes with "git init&q= uot;. Since
I don't have git-annex command, these tests are usually skipped, so
I hadn't noticed.

> I'm not sure. Until now only Eric and I had commented on this feat= ure.=C2=A0 I
> will say that I will probably never go back to the old behavior, but m= aybe
> there are people who prefer it. I believe there are 6 possible options= for
> org-src-window-setup (though only 5 are listed in the defcustom defini= tion,
> I think that org-src-switch-to-buffer also recognizes 'silently). = It may be
> that some of those options only make sense if the window config is res= tored
> after closing the src buffer.
>
> ~org-src--saved-window-config~ is only used in this function, so inste= ad of
> adding a new variable we could just get rid of an old one :-).

IMO, the only value for `org-src-window-setup' where it might be
meaningful to preserve windows excursion is `reorganize-frame', since i= t
can disturb a lot the configuration used before editing the block.
However, the docstring disagrees: "When exiting the edit buffer, retur= n
to one window."

Therefore, I suggest to simply do not restore previous configuration in
Org 9.3, and document it in incompatible changes. It will leave time to
test it and complain if something is not right.

WDYT?
Personally I prefer you= r solution. Would you like me to make a new patch or would you prefer to do= this yourself?
--000000000000c97ad6057b837493--