* Release 9.0 test failed: test-ob/indented-cached-org-bracket-link
@ 2016-11-14 16:37 David Talmage
2016-11-18 8:44 ` Nicolas Goaziou
0 siblings, 1 reply; 10+ messages in thread
From: David Talmage @ 2016-11-14 16:37 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 1922 bytes --]
I built org 9.0 on my Mac today. 'make test' reported one failed test. I
don't know if it is important or not. Please advise me.
'make test' said:
1 unexpected results:
FAILED test-ob/indented-cached-org-bracket-link
make: *** [test] Error 1
I have bash 4.4 freshly installed from mac ports.
I have emacs 24.5.1.
Here is the backtrace:
Test test-ob/indented-cached-org-bracket-link backtrace:
(if (unwind-protect (setq value-1119 (let ((default-directory tempor
(let (form-description-1120) (if (unwind-protect (setq value-1119 (l
(let ((value-1119 (cl-gensym "ert-form-evaluation-aborted-"))) (let
(lambda nil (let ((value-1119 (cl-gensym "ert-form-evaluation-aborte
ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
ert-run-test([cl-struct-ert-test test-ob/indented-cached-org-bracket
ert-run-or-rerun-test([cl-struct-ert--stats "\\(org\\|ob\\)" [[cl-st
ert-run-tests("\\(org\\|ob\\)" #[385 "\306\307\"\203G\211\211G\310
ert-run-tests-batch("\\(org\\|ob\\)")
ert-run-tests-batch-and-exit("\\(org\\|ob\\)")
(let ((org-id-track-globally t) (org-test-selector (if org-test-sele
org-test-run-batch-tests("\\(org\\|ob\\)")
eval((org-test-run-batch-tests org-test-select-re))
command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
command-line()
normal-top-level()
Test test-ob/indented-cached-org-bracket-link condition:
(ert-test-failed
((should
(let
(...)
(org-test-with-temp-text "
* Test
#+<point>BEGIN_SRC emacs-lisp :file test.txt :cache yes
(message \"test\")
#+END_SRC" ... ...)))
:form
(let
((default-directory temporary-file-directory))
(org-test-with-temp-text "
* Test
#+<point>BEGIN_SRC emacs-lisp :file test.txt :cache yes
(message \"test\")
#+END_SRC"
(org-babel-execute-src-block)
(string= ... ...)))
:value nil))
FAILED 166/670 test-ob/indented-cached-org-bracket-link
[-- Attachment #2: Type: text/html, Size: 3168 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Release 9.0 test failed: test-ob/indented-cached-org-bracket-link
2016-11-14 16:37 Release 9.0 test failed: test-ob/indented-cached-org-bracket-link David Talmage
@ 2016-11-18 8:44 ` Nicolas Goaziou
2016-11-18 18:50 ` Charles C. Berry
0 siblings, 1 reply; 10+ messages in thread
From: Nicolas Goaziou @ 2016-11-18 8:44 UTC (permalink / raw)
To: David Talmage; +Cc: emacs-orgmode
Hello,
David Talmage <david.talmage@shoutpoint.com> writes:
> I built org 9.0 on my Mac today. 'make test' reported one failed test. I
> don't know if it is important or not. Please advise me.
>
> 'make test' said:
>
> 1 unexpected results:
> FAILED test-ob/indented-cached-org-bracket-link
Our build bot doesn't report this error and I cannot reproduce it
either. None of us is using a Mac, though.
> Test test-ob/indented-cached-org-bracket-link condition:
> (ert-test-failed
> ((should
> (let
> (...)
> (org-test-with-temp-text "
> * Test
> #+<point>BEGIN_SRC emacs-lisp :file test.txt :cache yes
> (message \"test\")
> #+END_SRC" ... ...)))
> :form
> (let
> ((default-directory temporary-file-directory))
> (org-test-with-temp-text "
> * Test
> #+<point>BEGIN_SRC emacs-lisp :file test.txt :cache yes
> (message \"test\")
> #+END_SRC"
> (org-babel-execute-src-block)
> (string= ... ...)))
> :value nil))
> FAILED 166/670 test-ob/indented-cached-org-bracket-link
Unfortunately, the backtrace is missing important information. It might
be enlightening to know why (string= ... ...) returns nil, i.e., what
strings are compared.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Release 9.0 test failed: test-ob/indented-cached-org-bracket-link
2016-11-18 8:44 ` Nicolas Goaziou
@ 2016-11-18 18:50 ` Charles C. Berry
2016-11-19 6:49 ` Nicolas Goaziou
0 siblings, 1 reply; 10+ messages in thread
From: Charles C. Berry @ 2016-11-18 18:50 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: David Talmage, emacs-orgmode
On Fri, 18 Nov 2016, Nicolas Goaziou wrote:
> Hello,
>
> David Talmage <david.talmage@shoutpoint.com> writes:
>
>> I built org 9.0 on my Mac today. 'make test' reported one failed test. I
>> don't know if it is important or not. Please advise me.
>>
>> 'make test' said:
>>
>> 1 unexpected results:
>> FAILED test-ob/indented-cached-org-bracket-link
>
> Our build bot doesn't report this error and I cannot reproduce it
> either. None of us is using a Mac, though.
>
I have a Mac and I *can* reproduce this running `make test'. But following
the README for interactive testing, the test succeeds:
Selector: test-ob/indented-cached-org-bracket-link
Passed: 1
Failed: 0
Skipped: 0
Total: 1/1
I do not know what further steps to take to debug this.
??
Chuck
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Release 9.0 test failed: test-ob/indented-cached-org-bracket-link
2016-11-18 18:50 ` Charles C. Berry
@ 2016-11-19 6:49 ` Nicolas Goaziou
2016-11-19 17:40 ` Charles C. Berry
0 siblings, 1 reply; 10+ messages in thread
From: Nicolas Goaziou @ 2016-11-19 6:49 UTC (permalink / raw)
To: Charles C. Berry; +Cc: David Talmage, emacs-orgmode
Hello,
"Charles C. Berry" <ccberry@ucsd.edu> writes:
> On Fri, 18 Nov 2016, Nicolas Goaziou wrote:
>
>> Hello,
>>
>> David Talmage <david.talmage@shoutpoint.com> writes:
>>
>>> I built org 9.0 on my Mac today. 'make test' reported one failed test. I
>>> don't know if it is important or not. Please advise me.
>>>
>>> 'make test' said:
>>>
>>> 1 unexpected results:
>>> FAILED test-ob/indented-cached-org-bracket-link
>>
>> Our build bot doesn't report this error and I cannot reproduce it
>> either. None of us is using a Mac, though.
>>
>
> I have a Mac and I *can* reproduce this running `make test'. But
> following the README for interactive testing, the test succeeds:
>
> Selector: test-ob/indented-cached-org-bracket-link
> Passed: 1
> Failed: 0
> Skipped: 0
> Total: 1/1
>
> I do not know what further steps to take to debug this.
You can mimic the test:
- create a new file in `temporary-file-directory'.
- insert
* Test
#+BEGIN_SRC emacs-lisp :file test.txt :cache yes
(message "test")
#+END_SRC"
- Put point on "BEGIN"
- Call (org-babel-execute-src-block) and compare return value with
(concat default-directory "test.text")
Another option is to modify the test so it prints some useful debugging
information before failing (e.g., contents of default-directory and
return value of (org-babel-execute-src-block)).
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Release 9.0 test failed: test-ob/indented-cached-org-bracket-link
2016-11-19 6:49 ` Nicolas Goaziou
@ 2016-11-19 17:40 ` Charles C. Berry
2016-11-19 17:55 ` Achim Gratz
0 siblings, 1 reply; 10+ messages in thread
From: Charles C. Berry @ 2016-11-19 17:40 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: David Talmage, emacs-orgmode
On Fri, 18 Nov 2016, Nicolas Goaziou wrote:
> Hello,
>
> "Charles C. Berry" <ccberry@ucsd.edu> writes:
>
>> On Fri, 18 Nov 2016, Nicolas Goaziou wrote:
>>
>>> Hello,
>>>
>>> David Talmage <david.talmage@shoutpoint.com> writes:
>>>
>>>> I built org 9.0 on my Mac today. 'make test' reported one failed test. I
>>>> don't know if it is important or not. Please advise me.
>>>>
>>>> 'make test' said:
>>>>
>>>> 1 unexpected results:
>>>> FAILED test-ob/indented-cached-org-bracket-link
>>>
[snip]
>
>
> Another option is to modify the test so it prints some useful debugging
> information before failing (e.g., contents of default-directory and
> return value of (org-babel-execute-src-block)).
>
Doing this with `make test', I see that default-directory is let bound to
"/var/folders/kb/2hchpbyj7lb6z76l0q73w_fh0000gn/T//tmp-orgtest/"
and (concat default-directory "test.txt") will retain the double slash.
The return value from the second (org-babel-execute-src-block) has only a
single slash between 'T' and 'tmp'. Hence the failure.
When run interactively, there is no double slash and the test succeeds.
Using
: (expand-file-name "test.txt")
in place of
: (concat default-directory "test.txt)
cleans out the double slash and succeeds either with `make test' or
interactively.
So, maybe make that change?
Chuck
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Release 9.0 test failed: test-ob/indented-cached-org-bracket-link
2016-11-19 17:40 ` Charles C. Berry
@ 2016-11-19 17:55 ` Achim Gratz
2016-11-19 19:15 ` John Kitchin
0 siblings, 1 reply; 10+ messages in thread
From: Achim Gratz @ 2016-11-19 17:55 UTC (permalink / raw)
To: emacs-orgmode
Charles C. Berry writes:
> Doing this with `make test', I see that default-directory is let bound to
>
> "/var/folders/kb/2hchpbyj7lb6z76l0q73w_fh0000gn/T//tmp-orgtest/"
>
> and (concat default-directory "test.txt") will retain the double slash.
Not to sound facetious, but it seems that the make variable testdir gets
set to a path that has a trailing slash. Fix that and the problem
should go away (most likely TMPDIR has a trailing slash). Check with
: make config
or even
: make config-all
that the variable is set correctly.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
SD adaptations for KORG EX-800 and Poly-800MkII V0.9:
http://Synth.Stromeko.net/Downloads.html#KorgSDada
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Release 9.0 test failed: test-ob/indented-cached-org-bracket-link
2016-11-19 17:55 ` Achim Gratz
@ 2016-11-19 19:15 ` John Kitchin
2016-11-20 4:03 ` Charles C. Berry
0 siblings, 1 reply; 10+ messages in thread
From: John Kitchin @ 2016-11-19 19:15 UTC (permalink / raw)
To: Achim Gratz; +Cc: emacs-orgmode
I have also seen this error on my mac. I guess it is from the trailing
slash as you suggest:
> echo $TMPDIR
/var/folders/5q/lllv2yf95hg_n6h6kjttbmdw0000gn/T/
Achim Gratz writes:
> Charles C. Berry writes:
>> Doing this with `make test', I see that default-directory is let bound to
>>
>> "/var/folders/kb/2hchpbyj7lb6z76l0q73w_fh0000gn/T//tmp-orgtest/"
>>
>> and (concat default-directory "test.txt") will retain the double slash.
>
> Not to sound facetious, but it seems that the make variable testdir gets
> set to a path that has a trailing slash. Fix that and the problem
> should go away (most likely TMPDIR has a trailing slash). Check with
>
> : make config
>
> or even
>
> : make config-all
>
> that the variable is set correctly.
>
> Regards,
> Achim.
--
Professor John Kitchin
Doherty Hall A207F
Department of Chemical Engineering
Carnegie Mellon University
Pittsburgh, PA 15213
412-268-7803
@johnkitchin
http://kitchingroup.cheme.cmu.edu
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Release 9.0 test failed: test-ob/indented-cached-org-bracket-link
2016-11-19 19:15 ` John Kitchin
@ 2016-11-20 4:03 ` Charles C. Berry
2016-11-20 8:38 ` Nicolas Goaziou
0 siblings, 1 reply; 10+ messages in thread
From: Charles C. Berry @ 2016-11-20 4:03 UTC (permalink / raw)
To: John Kitchin; +Cc: Achim Gratz, emacs-orgmode
On Sat, 19 Nov 2016, John Kitchin wrote:
> I have also seen this error on my mac. I guess it is from the trailing
> slash as you suggest:
>
>> echo $TMPDIR
> /var/folders/5q/lllv2yf95hg_n6h6kjttbmdw0000gn/T/
>
>
So,
: testdir=${TMPDIR%/}/tmp-orgtest
in mk/default.mk would handle this on my mac, but I do not know if
this is fully portable.
OTOH, (expand-file-name "test.txt") resolves double-slashes and seems like
the right idiom in any case.
Chuck
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Release 9.0 test failed: test-ob/indented-cached-org-bracket-link
2016-11-20 4:03 ` Charles C. Berry
@ 2016-11-20 8:38 ` Nicolas Goaziou
2016-11-22 14:18 ` David Talmage
0 siblings, 1 reply; 10+ messages in thread
From: Nicolas Goaziou @ 2016-11-20 8:38 UTC (permalink / raw)
To: Charles C. Berry; +Cc: Achim Gratz, emacs-orgmode, John Kitchin
Hello,
"Charles C. Berry" <ccberry@ucsd.edu> writes:
> OTOH, (expand-file-name "test.txt") resolves double-slashes and seems
> like the right idiom in any case.
Fixed. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Release 9.0 test failed: test-ob/indented-cached-org-bracket-link
2016-11-20 8:38 ` Nicolas Goaziou
@ 2016-11-22 14:18 ` David Talmage
0 siblings, 0 replies; 10+ messages in thread
From: David Talmage @ 2016-11-22 14:18 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
On Sun, Nov 20, 2016 at 3:38 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Hello,
>
> "Charles C. Berry" <ccberry@ucsd.edu> writes:
>
> > OTOH, (expand-file-name "test.txt") resolves double-slashes and seems
> > like the right idiom in any case.
>
> Fixed. Thank you.
>
It worked for me, too! Thank you all!
[-- Attachment #2: Type: text/html, Size: 789 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-11-22 14:18 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-14 16:37 Release 9.0 test failed: test-ob/indented-cached-org-bracket-link David Talmage
2016-11-18 8:44 ` Nicolas Goaziou
2016-11-18 18:50 ` Charles C. Berry
2016-11-19 6:49 ` Nicolas Goaziou
2016-11-19 17:40 ` Charles C. Berry
2016-11-19 17:55 ` Achim Gratz
2016-11-19 19:15 ` John Kitchin
2016-11-20 4:03 ` Charles C. Berry
2016-11-20 8:38 ` Nicolas Goaziou
2016-11-22 14:18 ` David Talmage
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).