From: Charles Durst <cwdurst+orgmode@gmail.com>
To: Lungang Fang <lungang.fang@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Fwd: [PATCH] Add support for ordered list to ox-confluence.el
Date: Thu, 8 Dec 2016 22:39:16 -0500 [thread overview]
Message-ID: <CAM4wePjxs01DfA8hfZr8cPk8y5KcTo9MO0PgHKpck0=MnBOyEQ@mail.gmail.com> (raw)
In-Reply-To: <CAFfEE6MDpv+=kyDh3xn+KY-Cp33scNvUpkcOdkj99VjzOfLfxw@mail.gmail.com>
I have tried the results of both versions and loaded them into the
Confluence Wiki, and Lungang is correct, from what I can tell, they
both will work.
So I don't really care which one you choose either. I just needed the
functionality.
--
Charles Durst
cwdurst+orgmode@gmail.com
On Thu, Dec 8, 2016 at 9:32 PM, Lungang Fang <lungang.fang@gmail.com> wrote:
> Hi Charles and Nicholas,
>
> My code also supports nested mixed lists but is simpler. I mean, my code
> will convert the list given by Charles to
>
> # Here
> -- is
> -- an
> # example
> -- of
> -- a
> # mixed
> # list
>
> Although this format is not mentioned in confluence wiki, it is supported by
> conflucence according to my test (in Jira).
>
> So, in my opinion, it is a matter of personal preference: more complicated
> code complies with documented interface, or simpler code that exploits
> undocumented feature.
>
> I prefer my code. But you guys feel free to make decision. I am OK with
> whatever you choose.
>
> Cheers,
> Lungang
>
> On Fri, Dec 9, 2016 at 10:37 AM, Charles Durst <cwdurst+orgmode@gmail.com>
> wrote:
>>
>> They do conflict. My version is slightly more complicated since it
>> also supports nested mixed lists.
>>
>> For example:
>>
>> 1. Here
>> * is
>> * an
>> 2. example
>> * of
>> * a
>> 3. mixed
>> 4. list
>>
>> Which translates to:
>>
>> # Here
>> #- is
>> #- an
>> # example
>> #- of
>> #- a
>> # mixed
>> # list
>>
>> Which is effectively the same as the example in the Confluence
>> documentation:
>>
>> https://confluence.atlassian.com/confcloud/confluence-wiki-markup-724765099.html#ConfluenceWikiMarkup-Mixedlists
>>
>> --
>> Charles Durst
>> cwdurst+orgmode@gmail.com
>>
>>
>> On Thu, Dec 8, 2016 at 5:49 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> wrote:
>> > Hello,
>> >
>> > Lungang Fang <lungang.fang@gmail.com> writes:
>> >
>> >> Attached is a patch for contrib/lisp/ox-confluence.el generated
>> >> following
>> >> instructions on http://orgmode.org/worg/org-contribute.html#patches .
>> >> It
>> >> adds support for ordered list.
>> >
>> > Thank you.
>> >
>> > However, this somewhat conflicts with a patch recently sent on the ML,
>> > but not yet applied, by Charles Durst (Cc'ed).
>> >
>> > Could one double-check if one doesn't supersede the other, or if they
>> > could be merged (although I suspect the former) and report back so
>> > I know what patch to apply?
>> >
>> > Regards,
>> >
>> > --
>> > Nicolas Goaziou
>
>
next prev parent reply other threads:[~2016-12-09 3:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 6:47 [PATCH] Add support for ordered list to ox-confluence.el Lungang Fang
2016-12-08 5:26 ` Fwd: " Lungang Fang
2016-12-08 22:49 ` Nicolas Goaziou
2016-12-08 23:35 ` Charles Durst
2016-12-08 23:37 ` Charles Durst
2016-12-09 2:32 ` Lungang Fang
2016-12-09 3:39 ` Charles Durst [this message]
2016-12-09 8:34 ` Lungang Fang
2016-12-09 20:34 ` Nicolas Goaziou
2016-12-10 7:54 ` Lungang Fang
2016-12-12 23:07 ` Charles Durst
2016-12-13 12:50 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM4wePjxs01DfA8hfZr8cPk8y5KcTo9MO0PgHKpck0=MnBOyEQ@mail.gmail.com' \
--to=cwdurst+orgmode@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=lungang.fang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).