From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Durst Subject: Re: Fwd: [PATCH] Add support for ordered list to ox-confluence.el Date: Thu, 8 Dec 2016 22:39:16 -0500 Message-ID: References: <87pol2f34e.fsf@nicolasgoaziou.fr> Reply-To: cwdurst+orgmode@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFC37-0006VT-1I for emacs-orgmode@gnu.org; Thu, 08 Dec 2016 22:40:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFC33-00061h-NO for emacs-orgmode@gnu.org; Thu, 08 Dec 2016 22:40:40 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:36733) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cFC33-00061c-Hk for emacs-orgmode@gnu.org; Thu, 08 Dec 2016 22:40:37 -0500 Received: by mail-qt0-f194.google.com with SMTP id n34so663178qtb.3 for ; Thu, 08 Dec 2016 19:40:37 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Lungang Fang Cc: emacs-orgmode@gnu.org I have tried the results of both versions and loaded them into the Confluence Wiki, and Lungang is correct, from what I can tell, they both will work. So I don't really care which one you choose either. I just needed the functionality. -- Charles Durst cwdurst+orgmode@gmail.com On Thu, Dec 8, 2016 at 9:32 PM, Lungang Fang wrote: > Hi Charles and Nicholas, > > My code also supports nested mixed lists but is simpler. I mean, my code > will convert the list given by Charles to > > # Here > -- is > -- an > # example > -- of > -- a > # mixed > # list > > Although this format is not mentioned in confluence wiki, it is supported by > conflucence according to my test (in Jira). > > So, in my opinion, it is a matter of personal preference: more complicated > code complies with documented interface, or simpler code that exploits > undocumented feature. > > I prefer my code. But you guys feel free to make decision. I am OK with > whatever you choose. > > Cheers, > Lungang > > On Fri, Dec 9, 2016 at 10:37 AM, Charles Durst > wrote: >> >> They do conflict. My version is slightly more complicated since it >> also supports nested mixed lists. >> >> For example: >> >> 1. Here >> * is >> * an >> 2. example >> * of >> * a >> 3. mixed >> 4. list >> >> Which translates to: >> >> # Here >> #- is >> #- an >> # example >> #- of >> #- a >> # mixed >> # list >> >> Which is effectively the same as the example in the Confluence >> documentation: >> >> https://confluence.atlassian.com/confcloud/confluence-wiki-markup-724765099.html#ConfluenceWikiMarkup-Mixedlists >> >> -- >> Charles Durst >> cwdurst+orgmode@gmail.com >> >> >> On Thu, Dec 8, 2016 at 5:49 PM, Nicolas Goaziou >> wrote: >> > Hello, >> > >> > Lungang Fang writes: >> > >> >> Attached is a patch for contrib/lisp/ox-confluence.el generated >> >> following >> >> instructions on http://orgmode.org/worg/org-contribute.html#patches . >> >> It >> >> adds support for ordered list. >> > >> > Thank you. >> > >> > However, this somewhat conflicts with a patch recently sent on the ML, >> > but not yet applied, by Charles Durst (Cc'ed). >> > >> > Could one double-check if one doesn't supersede the other, or if they >> > could be merged (although I suspect the former) and report back so >> > I know what patch to apply? >> > >> > Regards, >> > >> > -- >> > Nicolas Goaziou > >