From: Michael Brand <michael.ch.brand@gmail.com>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: column view uses non-existent org-whitespace face
Date: Mon, 8 Feb 2016 20:01:11 +0100 [thread overview]
Message-ID: <CALn3zoihQy2H3v4SvZDhQ8c5oj-kt0r6FD4kUkSdi67U2dC0nQ@mail.gmail.com> (raw)
In-Reply-To: <CALn3zoiHxhycoRPZPgSOVSPDK2bgtvN18kT3OKwwHhdb=8QLTg@mail.gmail.com>
Hi Eric
On Thu, Sep 25, 2014 at 6:09 PM, Michael Brand
<michael.ch.brand@gmail.com> wrote:
> On Tue, Aug 5, 2014 at 4:53 AM, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>> 2. The text for %ITEM has the face org-whitespace applied to the leading
>> stars, which doesn't exist anymore. I assume the intended effect was
>> that the stars take up space, emulating indentation, but not themselves
>> be visible. I guess that would be done by replacing the org-whitespace
>> face with whatever's being used as the column background color but I
>> don't know enough about faces to make that work. I also tried switching
>> 'org-whitespace to 'invisible, but that didn't do anything. This is in
>> org-columns-cleanup-item.
>>
>> [...]
>> The second would be nice to resolve --
>> it's ugly!
>
> Same here. I just tried to hide the leading stars in column view by
> shifting the beginning of the overlay to the right in
> `org-columns-new-overlay' with
>
> (let ((ov (make-overlay
> (if org-hide-leading-stars (+ beg (org-current-level) -1) beg)
> end)))
>
> but this trial seems to have several issues and I don't know how to do
> it right.
>
> Michael
With recent changes made by Nicolas the solution became obvious to me,
fixed in master. (I don't consider hidden stars useful in column view
of agenda view as it is not a folded hierarchy and as the headings can
origin from different settings for hidden stars, so I didn't repeat my
change there.)
Michael
next prev parent reply other threads:[~2016-02-08 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 2:53 column view uses non-existent org-whitespace face Eric Abrahamsen
2014-09-25 16:09 ` Michael Brand
2016-02-08 19:01 ` Michael Brand [this message]
2016-02-09 2:53 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALn3zoihQy2H3v4SvZDhQ8c5oj-kt0r6FD4kUkSdi67U2dC0nQ@mail.gmail.com \
--to=michael.ch.brand@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).