From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: column view uses non-existent org-whitespace face Date: Mon, 8 Feb 2016 20:01:11 +0100 Message-ID: References: <87fvhb4pfz.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSr3i-0006Ck-CD for emacs-orgmode@gnu.org; Mon, 08 Feb 2016 14:01:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSr3h-0004qH-EN for emacs-orgmode@gnu.org; Mon, 08 Feb 2016 14:01:14 -0500 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:35299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSr3h-0004qC-7M for emacs-orgmode@gnu.org; Mon, 08 Feb 2016 14:01:13 -0500 Received: by mail-wm0-x22f.google.com with SMTP id c200so29834496wme.0 for ; Mon, 08 Feb 2016 11:01:12 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Abrahamsen Cc: Org Mode Hi Eric On Thu, Sep 25, 2014 at 6:09 PM, Michael Brand wrote: > On Tue, Aug 5, 2014 at 4:53 AM, Eric Abrahamsen wrote: >> 2. The text for %ITEM has the face org-whitespace applied to the leading >> stars, which doesn't exist anymore. I assume the intended effect was >> that the stars take up space, emulating indentation, but not themselves >> be visible. I guess that would be done by replacing the org-whitespace >> face with whatever's being used as the column background color but I >> don't know enough about faces to make that work. I also tried switching >> 'org-whitespace to 'invisible, but that didn't do anything. This is in >> org-columns-cleanup-item. >> >> [...] >> The second would be nice to resolve -- >> it's ugly! > > Same here. I just tried to hide the leading stars in column view by > shifting the beginning of the overlay to the right in > `org-columns-new-overlay' with > > (let ((ov (make-overlay > (if org-hide-leading-stars (+ beg (org-current-level) -1) beg) > end))) > > but this trial seems to have several issues and I don't know how to do > it right. > > Michael With recent changes made by Nicolas the solution became obvious to me, fixed in master. (I don't consider hidden stars useful in column view of agenda view as it is not a folded hierarchy and as the headings can origin from different settings for hidden stars, so I didn't repeat my change there.) Michael