* Parsing of todo state log lines
@ 2018-05-15 9:38 Michael Brand
2018-05-16 19:07 ` Nicolas Goaziou
0 siblings, 1 reply; 7+ messages in thread
From: Michael Brand @ 2018-05-15 9:38 UTC (permalink / raw)
To: Org Mode
Hi all
There seems to be an inconsistency in parsing. When
org-log-states-order-reversed is nil (which I am new to) and a TODO
with the manually written state log lines
- State "DONE" from "TODO" [2018-05-12 Sat]
- State "DONE" from [2018-05-13 Sun]
- State "DONE" from "TODO" [2018-05-14 Mon]
is changed to DONE the new state log line is expected to go after the
third line but it goes after the first like if the second was missed
by the parser. When the same state log lines are in a habit they are
all recognized for the consistency graph where they appear as a star,
but still the new state log line goes after the first line.
Found in Org release_9.1.13-751-g9dcc522.
Michael
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Parsing of todo state log lines
2018-05-15 9:38 Parsing of todo state log lines Michael Brand
@ 2018-05-16 19:07 ` Nicolas Goaziou
2018-05-16 19:49 ` Michael Brand
0 siblings, 1 reply; 7+ messages in thread
From: Nicolas Goaziou @ 2018-05-16 19:07 UTC (permalink / raw)
To: Michael Brand; +Cc: Org Mode
Hello,
Michael Brand <michael.ch.brand@gmail.com> writes:
> There seems to be an inconsistency in parsing. When
> org-log-states-order-reversed is nil (which I am new to) and a TODO
> with the manually written state log lines
>
> - State "DONE" from "TODO" [2018-05-12 Sat]
> - State "DONE" from [2018-05-13 Sun]
I think it should be
- State "DONE" from "" [whatever]
according to `org-log-note-headings'.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Parsing of todo state log lines
2018-05-16 19:07 ` Nicolas Goaziou
@ 2018-05-16 19:49 ` Michael Brand
2018-05-16 20:08 ` Nicolas Goaziou
0 siblings, 1 reply; 7+ messages in thread
From: Michael Brand @ 2018-05-16 19:49 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: Org Mode
Hi Nicolas
On Wed, May 16, 2018 at 9:07 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Michael Brand <michael.ch.brand@gmail.com> writes:
>
>> There seems to be an inconsistency in parsing. When
>> org-log-states-order-reversed is nil (which I am new to) and a TODO
>> with the manually written state log lines
>>
>> - State "DONE" from "TODO" [2018-05-12 Sat]
>> - State "DONE" from [2018-05-13 Sun]
>
> I think it should be
>
> - State "DONE" from "" [whatever]
>
> according to `org-log-note-headings'.
I don't see this happen: When starting with this (the % and the
ordering of the lines have been edited manually)
- State "DONE" from "TODO" [2018-05-15 Tue 10:00]
- State "DONE" from "%" [2018-05-15 Tue 10:00]
- State "DONE" from "" [2018-05-15 Tue 10:00]
- State "DONE" from [2018-05-15 Tue 10:00]
and without todo keyword in the heading the logs change to
- State "DONE" from "TODO" [2018-05-15 Tue 10:00]
- State "DONE" from "%" [2018-05-15 Tue 10:00]
- State "DONE" from [2018-05-16 Wed 21:45]
- State "DONE" from "" [2018-05-15 Tue 10:00]
- State "DONE" from [2018-05-15 Tue 10:00]
So also "" is not recognized. And the new middle line is produced without "".
Michael
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Parsing of todo state log lines
2018-05-16 19:49 ` Michael Brand
@ 2018-05-16 20:08 ` Nicolas Goaziou
2018-05-16 20:21 ` Michael Brand
0 siblings, 1 reply; 7+ messages in thread
From: Nicolas Goaziou @ 2018-05-16 20:08 UTC (permalink / raw)
To: Michael Brand; +Cc: Org Mode
Hello,
Michael Brand <michael.ch.brand@gmail.com> writes:
> I don't see this happen: When starting with this (the % and the
> ordering of the lines have been edited manually)
>
> - State "DONE" from "TODO" [2018-05-15 Tue 10:00]
> - State "DONE" from "%" [2018-05-15 Tue 10:00]
> - State "DONE" from "" [2018-05-15 Tue 10:00]
> - State "DONE" from [2018-05-15 Tue 10:00]
>
> and without todo keyword in the heading the logs change to
>
> - State "DONE" from "TODO" [2018-05-15 Tue 10:00]
> - State "DONE" from "%" [2018-05-15 Tue 10:00]
> - State "DONE" from [2018-05-16 Wed 21:45]
> - State "DONE" from "" [2018-05-15 Tue 10:00]
> - State "DONE" from [2018-05-15 Tue 10:00]
>
> So also "" is not recognized. And the new middle line is produced
> without "".
You are right. It should be empty, not "". I think I fixed it in maint.
Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Parsing of todo state log lines
2018-05-16 20:08 ` Nicolas Goaziou
@ 2018-05-16 20:21 ` Michael Brand
2018-05-16 20:42 ` Nicolas Goaziou
0 siblings, 1 reply; 7+ messages in thread
From: Michael Brand @ 2018-05-16 20:21 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: Org Mode
Hi
On Wed, May 16, 2018 at 10:08 PM, Nicolas Goaziou
<mail@nicolasgoaziou.fr> wrote:
> You are right. It should be empty, not "". I think I fixed it in maint.
I still get the new log in the middle line with
release_9.1.13-757-g463664b after restarting Emacs. Did you get the
new log after the last line?
Michael
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Parsing of todo state log lines
2018-05-16 20:21 ` Michael Brand
@ 2018-05-16 20:42 ` Nicolas Goaziou
2018-05-16 21:04 ` Michael Brand
0 siblings, 1 reply; 7+ messages in thread
From: Nicolas Goaziou @ 2018-05-16 20:42 UTC (permalink / raw)
To: Michael Brand; +Cc: Org Mode
Michael Brand <michael.ch.brand@gmail.com> writes:
> I still get the new log in the middle line with
> release_9.1.13-757-g463664b after restarting Emacs. Did you get the
> new log after the last line?
I didn't test logging, but `org-skip-over-state-notes' definitely goes
past the three items, so I guess `org-log-beginning' should put point at
the end of the three items, too.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Parsing of todo state log lines
2018-05-16 20:42 ` Nicolas Goaziou
@ 2018-05-16 21:04 ` Michael Brand
0 siblings, 0 replies; 7+ messages in thread
From: Michael Brand @ 2018-05-16 21:04 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: Org Mode
Hi Nicolas
On Wed, May 16, 2018 at 10:42 PM, Nicolas Goaziou
<mail@nicolasgoaziou.fr> wrote:
> I didn't test logging, but `org-skip-over-state-notes' definitely goes
> past the three items, so I guess `org-log-beginning' should put point at
> the end of the three items, too.
Indeed, it works all as expected. Thank you! (Sorry, my fault was that
the invalid example line with "" was not removed yet.)
Michael
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-05-16 21:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 9:38 Parsing of todo state log lines Michael Brand
2018-05-16 19:07 ` Nicolas Goaziou
2018-05-16 19:49 ` Michael Brand
2018-05-16 20:08 ` Nicolas Goaziou
2018-05-16 20:21 ` Michael Brand
2018-05-16 20:42 ` Nicolas Goaziou
2018-05-16 21:04 ` Michael Brand
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).