emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Org-mode link returned path is truncated when contains space
@ 2017-05-31  8:31 numbchild
  2017-05-31 14:06 ` Nicolas Goaziou
  0 siblings, 1 reply; 5+ messages in thread
From: numbchild @ 2017-05-31  8:31 UTC (permalink / raw)
  To: Org-mode

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

I have a link in org-moe file like this:

 #+BEGIN_SRC org
 [[file:Data/images/logos/Full color Git logo for light backgrounds.png]]
 #+END_SRC

 *The file did exist.*

 I have elisp code like this to fontify link when the file does not exist:

 #+BEGIN_SRC emacs-lisp
 (org-link-set-parameters
  "file"
  ;; TODO: fix path contains space case.
  :face (lambda (path) (if (file-exists-p path) 'org-link 'org-warning)))
 #+END_SRC

 But it is fontied as red. I tried to debug info by print of ~path~ in
upper `org-link-set-parameters` lambda function.

 It return for path:

 #+BEGIN_EXAMPLE
 "Data/images/logos/Full"
 #+END_EXAMPLE


[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

[-- Attachment #2: Type: text/html, Size: 3230 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Org-mode link returned path is truncated when contains space
  2017-05-31  8:31 Org-mode link returned path is truncated when contains space numbchild
@ 2017-05-31 14:06 ` Nicolas Goaziou
  2017-06-05 11:52   ` numbchild
  0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2017-05-31 14:06 UTC (permalink / raw)
  To: numbchild@gmail.com; +Cc: Org-mode

Hello,

"numbchild@gmail.com" <numbchild@gmail.com> writes:

> I have a link in org-moe file like this:
>
>  #+BEGIN_SRC org
>  [[file:Data/images/logos/Full color Git logo for light backgrounds.png]]
>  #+END_SRC
>
>
>  *The file did exist.*
>
>  I have elisp code like this to fontify link when the file does not exist:
>
>  #+BEGIN_SRC emacs-lisp
>  (org-link-set-parameters
>   "file"
>   ;; TODO: fix path contains space case.
>   :face (lambda (path) (if (file-exists-p path) 'org-link 'org-warning)))
>  #+END_SRC
>
>
>  But it is fontied as red. I tried to debug info by print of ~path~ in
> upper `org-link-set-parameters` lambda function.
>
>  It return for path:
>
>  #+BEGIN_EXAMPLE
>  "Data/images/logos/Full"
>  #+END_EXAMPLE

Could you update Org to a more recent version, e.g., 9.0.7. It may have
been fixed already.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Org-mode link returned path is truncated when contains space
  2017-05-31 14:06 ` Nicolas Goaziou
@ 2017-06-05 11:52   ` numbchild
  2017-06-06 10:49     ` Nicolas Goaziou
  0 siblings, 1 reply; 5+ messages in thread
From: numbchild @ 2017-06-05 11:52 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: Org-mode

[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]

I checked Org-mode package version with `org-version`, get `9.0.7`, still
have this issue. I updated to latest org-mode ELPA version.

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

On Wed, May 31, 2017 at 10:06 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> "numbchild@gmail.com" <numbchild@gmail.com> writes:
>
> > I have a link in org-moe file like this:
> >
> >  #+BEGIN_SRC org
> >  [[file:Data/images/logos/Full color Git logo for light backgrounds.png]]
> >  #+END_SRC
> >
> >
> >  *The file did exist.*
> >
> >  I have elisp code like this to fontify link when the file does not
> exist:
> >
> >  #+BEGIN_SRC emacs-lisp
> >  (org-link-set-parameters
> >   "file"
> >   ;; TODO: fix path contains space case.
> >   :face (lambda (path) (if (file-exists-p path) 'org-link 'org-warning)))
> >  #+END_SRC
> >
> >
> >  But it is fontied as red. I tried to debug info by print of ~path~ in
> > upper `org-link-set-parameters` lambda function.
> >
> >  It return for path:
> >
> >  #+BEGIN_EXAMPLE
> >  "Data/images/logos/Full"
> >  #+END_EXAMPLE
>
> Could you update Org to a more recent version, e.g., 9.0.7. It may have
> been fixed already.
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #2: Type: text/html, Size: 2462 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Org-mode link returned path is truncated when contains space
  2017-06-05 11:52   ` numbchild
@ 2017-06-06 10:49     ` Nicolas Goaziou
  2017-11-12  6:11       ` numbchild
  0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2017-06-06 10:49 UTC (permalink / raw)
  To: numbchild@gmail.com; +Cc: Org-mode

Hello,

"numbchild@gmail.com" <numbchild@gmail.com> writes:

> I checked Org-mode package version with `org-version`, get `9.0.7`, still
> have this issue. I updated to latest org-mode ELPA version.

Odd. You may have better luck with Org 9.0.8 then. In particular, commit
2d29269bb1b9af08011e091913798b6598e4b156 should prevent path from being
truncated.

Please report back if it works better (or not).

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Org-mode link returned path is truncated when contains space
  2017-06-06 10:49     ` Nicolas Goaziou
@ 2017-11-12  6:11       ` numbchild
  0 siblings, 0 replies; 5+ messages in thread
From: numbchild @ 2017-11-12  6:11 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: Org-mode

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

sorry for delay reply. I'm cleaning up my Org tasks, found this task. this
issue seems fixed.

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

On Tue, Jun 6, 2017 at 6:49 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> "numbchild@gmail.com" <numbchild@gmail.com> writes:
>
> > I checked Org-mode package version with `org-version`, get `9.0.7`, still
> > have this issue. I updated to latest org-mode ELPA version.
>
> Odd. You may have better luck with Org 9.0.8 then. In particular, commit
> 2d29269bb1b9af08011e091913798b6598e4b156 should prevent path from being
> truncated.
>
> Please report back if it works better (or not).
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #2: Type: text/html, Size: 1773 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-11-12  6:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-31  8:31 Org-mode link returned path is truncated when contains space numbchild
2017-05-31 14:06 ` Nicolas Goaziou
2017-06-05 11:52   ` numbchild
2017-06-06 10:49     ` Nicolas Goaziou
2017-11-12  6:11       ` numbchild

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).