From: Takaaki Ishikawa <takaxp@ieee.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>,
orgmode list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Add a custom list in org-mac-link.el
Date: Fri, 16 Jun 2017 03:38:55 +0900 [thread overview]
Message-ID: <CAJsv8TGOomBV4KoDg_+zhmHtv37QNANCdxYcWe-DCfv4FxTbdg@mail.gmail.com> (raw)
In-Reply-To: <87wp8dgqjv.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 2628 bytes --]
Dear Nicolas,
Thank you for your kind feedback. Please find my comments below.
> +(defcustom org-mac-link-descriptors
> > + `(("F" "inder" org-mac-finder-insert-selected
> ,org-mac-grab-Finder-app-p)
> > + ("m" "ail" org-mac-message-insert-selected
> ,org-mac-grab-Mail-app-p)
> > + ("d" "EVONthink Pro Office" org-mac-devonthink-item-insert-selected
> > + ,org-mac-grab-devonthink-app-p)
> > + ("o" "utlook" org-mac-outlook-message-insert-selected
> ,org-mac-grab-Outlook-app-p)
> > + ("a" "ddressbook" org-mac-addressbook-insert-selected
> ,org-mac-grab-Addressbook-app-p)
> > + ("s" "afari" org-mac-safari-insert-frontmost-url
> ,org-mac-grab-Safari-app-p)
> > + ("f" "irefox" org-mac-firefox-insert-frontmost-url
> ,org-mac-grab-Firefox-app-p)
> > + ("v" "imperator" org-mac-vimperator-insert-frontmost-url
> ,org-mac-grab-Firefox+Vimperator-p)
> > + ("c" "hrome" org-mac-chrome-insert-frontmost-url
> ,org-mac-grab-Chrome-app-p)
> > + ("e" "evernote" org-mac-evernote-note-insert-selected
> ,org-mac-grab-Evernote-app-p)
> > + ("t" "ogether" org-mac-together-insert-selected
> ,org-mac-grab-Together-app-p)
> > + ("S" "kim" org-mac-skim-insert-page ,org-mac-grab-Skim-app-p)
> > + ("A" "crobat" org-mac-acrobat-insert-page
> ,org-mac-grab-Acrobat-app-p))
> > + "Descriptors to select an application."
>
> Could you expand the docstring a bit? What is a descriptor, what type of
> data structure is it?
>
Updated docstring is
"Alist of descriptors. Each descriptor consists of four elements to build
the link grabber menu in the minibuffer. A single character shall be used
for the first element to select an application, and the pair with the second
element represents the name of the application. The third element is a
function to insert information grabbed from selected application. And the
last
element is a flag to indicate whether the descriptor appears in the link
grabber menu."
Do we need more detail?
> + :tag "A list of descriptors"
> > + :group 'org-mac-link'
> > + :type 'symbol)
>
> The :type value is wrong. You need a composite type here.
>
What do you feel about the following composite type.
:type '(alist :value-type (string string function boolean)
Is it useful to let the °descriptors' binding? We could simply replace
> `descriptors' with `org-mac-link-descriptors' in the `let' body. WDYT?
Yes, agree with you. I'll replace two `descriptors' in the function with
`org-mac-link-descriptors' when I produce an updated patch after receiving
your comments.
Best,
Takaaki
[-- Attachment #2: Type: text/html, Size: 3924 bytes --]
next prev parent reply other threads:[~2017-06-15 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-11 8:25 [PATCH] Add a custom list in org-mac-link.el Takaaki Ishikawa
2017-06-14 16:37 ` Nicolas Goaziou
2017-06-15 13:56 ` Takaaki Ishikawa
2017-06-15 16:32 ` Nicolas Goaziou
2017-06-15 18:38 ` Takaaki Ishikawa [this message]
2017-06-15 19:03 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJsv8TGOomBV4KoDg_+zhmHtv37QNANCdxYcWe-DCfv4FxTbdg@mail.gmail.com \
--to=takaxp@ieee.org \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).