From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Takaaki Ishikawa <takaxp@ieee.org>
Cc: orgmode list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Add a custom list in org-mac-link.el
Date: Thu, 15 Jun 2017 18:32:20 +0200 [thread overview]
Message-ID: <87wp8dgqjv.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAJsv8THHp1gZ3rVEuXUbtOUO2S2LMqSemUP_A0o+5uCMrPA57A@mail.gmail.com> (Takaaki Ishikawa's message of "Thu, 15 Jun 2017 22:56:07 +0900")
Hello,
Takaaki Ishikawa <takaxp@ieee.org> writes:
> I tried to generate a patch for this proposal. Please find an attached
> file.
Thank you.
> +(defcustom org-mac-link-descriptors
> + `(("F" "inder" org-mac-finder-insert-selected ,org-mac-grab-Finder-app-p)
> + ("m" "ail" org-mac-message-insert-selected ,org-mac-grab-Mail-app-p)
> + ("d" "EVONthink Pro Office" org-mac-devonthink-item-insert-selected
> + ,org-mac-grab-devonthink-app-p)
> + ("o" "utlook" org-mac-outlook-message-insert-selected ,org-mac-grab-Outlook-app-p)
> + ("a" "ddressbook" org-mac-addressbook-insert-selected ,org-mac-grab-Addressbook-app-p)
> + ("s" "afari" org-mac-safari-insert-frontmost-url ,org-mac-grab-Safari-app-p)
> + ("f" "irefox" org-mac-firefox-insert-frontmost-url ,org-mac-grab-Firefox-app-p)
> + ("v" "imperator" org-mac-vimperator-insert-frontmost-url ,org-mac-grab-Firefox+Vimperator-p)
> + ("c" "hrome" org-mac-chrome-insert-frontmost-url ,org-mac-grab-Chrome-app-p)
> + ("e" "evernote" org-mac-evernote-note-insert-selected ,org-mac-grab-Evernote-app-p)
> + ("t" "ogether" org-mac-together-insert-selected ,org-mac-grab-Together-app-p)
> + ("S" "kim" org-mac-skim-insert-page ,org-mac-grab-Skim-app-p)
> + ("A" "crobat" org-mac-acrobat-insert-page ,org-mac-grab-Acrobat-app-p))
> + "Descriptors to select an application."
Could you expand the docstring a bit? What is a descriptor, what type of
data structure is it?
> + :tag "A list of descriptors"
> + :group 'org-mac-link'
> + :type 'symbol)
The :type value is wrong. You need a composite type here.
> \f
> ;; In mac.c, removed in Emacs 23.
> (declare-function do-applescript "org-mac-message" (script))
> @@ -238,21 +258,7 @@
> "Prompt for an application to grab a link from.
> When done, go grab the link, and insert it at point."
> (interactive)
> - (let* ((descriptors
> - `(("F" "inder" org-mac-finder-insert-selected ,org-mac-grab-Finder-app-p)
> - ("m" "ail" org-mac-message-insert-selected ,org-mac-grab-Mail-app-p)
> - ("d" "EVONthink Pro Office" org-mac-devonthink-item-insert-selected
> - ,org-mac-grab-devonthink-app-p)
> - ("o" "utlook" org-mac-outlook-message-insert-selected ,org-mac-grab-Outlook-app-p)
> - ("a" "ddressbook" org-mac-addressbook-insert-selected ,org-mac-grab-Addressbook-app-p)
> - ("s" "afari" org-mac-safari-insert-frontmost-url ,org-mac-grab-Safari-app-p)
> - ("f" "irefox" org-mac-firefox-insert-frontmost-url ,org-mac-grab-Firefox-app-p)
> - ("v" "imperator" org-mac-vimperator-insert-frontmost-url ,org-mac-grab-Firefox+Vimperator-p)
> - ("c" "hrome" org-mac-chrome-insert-frontmost-url ,org-mac-grab-Chrome-app-p)
> - ("e" "evernote" org-mac-evernote-note-insert-selected ,org-mac-grab-Evernote-app-p)
> - ("t" "ogether" org-mac-together-insert-selected ,org-mac-grab-Together-app-p)
> - ("S" "kim" org-mac-skim-insert-page ,org-mac-grab-Skim-app-p)
> - ("A" "crobat" org-mac-acrobat-insert-page ,org-mac-grab-Acrobat-app-p)))
> + (let* ((descriptors org-mac-link-descriptors)
> (menu-string (make-string 0 ?x))
> input)
Is it useful to let the °descriptors' binding? We could simply replace
`descriptors' with `org-mac-link-descriptors' in the `let' body. WDYT?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-06-15 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-11 8:25 [PATCH] Add a custom list in org-mac-link.el Takaaki Ishikawa
2017-06-14 16:37 ` Nicolas Goaziou
2017-06-15 13:56 ` Takaaki Ishikawa
2017-06-15 16:32 ` Nicolas Goaziou [this message]
2017-06-15 18:38 ` Takaaki Ishikawa
2017-06-15 19:03 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp8dgqjv.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=takaxp@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).