emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* comment trees in 8.3
@ 2015-08-06  3:31 Samuel Wales
  2015-08-06  3:32 ` Samuel Wales
  0 siblings, 1 reply; 16+ messages in thread
From: Samuel Wales @ 2015-08-06  3:31 UTC (permalink / raw)
  To: emacs-orgmode

agenda shows them.

org-agenda-skip-comment-trees is non-nil.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-06  3:31 comment trees in 8.3 Samuel Wales
@ 2015-08-06  3:32 ` Samuel Wales
  2015-08-06  4:01   ` Kyle Meyer
  0 siblings, 1 reply; 16+ messages in thread
From: Samuel Wales @ 2015-08-06  3:32 UTC (permalink / raw)
  To: emacs-orgmode

git maint -> new git maint caused this.

On 8/5/15, Samuel Wales <samologist@gmail.com> wrote:
> agenda shows them.
>
> org-agenda-skip-comment-trees is non-nil.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-06  3:32 ` Samuel Wales
@ 2015-08-06  4:01   ` Kyle Meyer
  2015-08-06  4:29     ` Samuel Wales
  0 siblings, 1 reply; 16+ messages in thread
From: Kyle Meyer @ 2015-08-06  4:01 UTC (permalink / raw)
  To: Samuel Wales; +Cc: emacs-orgmode


Samuel Wales <samologist@gmail.com> wrote:
> git maint -> new git maint caused this.
>
> On 8/5/15, Samuel Wales <samologist@gmail.com> wrote:
>> agenda shows them.
>>
>> org-agenda-skip-comment-trees is non-nil.

I can't reproduce this running emacs -Q with the current master
(b5f5d66) and Emacs 24.5.1 using the following test file as the sole
agenda file.

    * TODO yes
    DEADLINE: <2015-08-05 Wed>

    * TODO COMMENT no
    DEADLINE: <2015-08-05 Wed>

Running org-agenda-list shows only the 'yes' heading.  Setting
org-agenda-skip-comment-trees to nil and running again shows both.

--
Kyle

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-06  4:01   ` Kyle Meyer
@ 2015-08-06  4:29     ` Samuel Wales
  2015-08-07  0:30       ` Nicolas Goaziou
  2015-08-09 23:59       ` Samuel Wales
  0 siblings, 2 replies; 16+ messages in thread
From: Samuel Wales @ 2015-08-06  4:29 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode

24.4.1

can repro with -Q and this old testcase code and restriction lock and
org-agenda-list.

===

;;;
;;;alpha-org-testcase.el
;;;
;;;minimal testcase for org
;;;
;;;   dorg=your-org-dir delorgsrc=your-org-src-dir emacs -Q -l
alpha-org-testcase.el
;;;

;;;
;;;for my use i do this:
;;;
"
mep=t emacs -Q -l $del/tests-and-publish/alpha-org-testcase.el \
  --geometry +0+0 \
  --geometry 60x30 \
  $dorg/tests--org--xyzzy-big/comment.org
"
;;;

(require 'cl)

;;my org files use these
(setq org-odd-levels-only t)
;; (setf org-export-initial-scope 'subtree)

;;fix abominations
(blink-cursor-mode 0)
(setf visible-bell 'top-bottom)

;;basics
(defun alpha-add-path (p) (setq load-path (cons p load-path)))
(alpha-add-path (concat (getenv "delorgsrc") "/lisp"))
(add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
(require 'org-install)

(setq org-agenda-files (list (substitute-in-file-name "$dorg/todo-new--a.org")))

;;;
;;;stuff make things easier
;;;

(setq org-completion-use-ido t)
(setf org-outline-path-complete-in-steps nil)

;;;
;;;compatibility fixes
;;;

;; ;;fix compatibility bug in org [2011-05-25 Wed 08:59]
;; (when (= emacs-major-version 22)
;;   (defun activate-mark ()
;;     "Activate the mark."
;;     (when (mark t)
;;       (setq mark-active t)
;;       (unless transient-mark-mode
;;         (setq transient-mark-mode 'lambda))
;;       (when (and select-active-regions
;;                  (display-selections-p))
;;         (x-set-selection 'PRIMARY (current-buffer))))))

;; ;;[2011-05-25 Wed 09:23] fix compatibility bug in Org.
;; ;;this is redefinition.  it is for 22 for export.
;; (defcustom select-active-regions nil
;;  "If non-nil, an active region automatically becomes the window selection."
;;  :type 'boolean
;;  :group 'killing
;;  :version "23.1")

;;;
;;;accessibility fixes
;;;

(defun p ()
  (interactive)
  (message "fixing pop-up-windows")
  ;;i have /pop-up-windows/ set to nil, which works for most of
  ;;emacs.  for org, i do the following.  i need all of this just
  ;;as i need the large font above for accessibility reasons.
  ;;
  ;;(setf (cdr (assoc* 'file org-link-frame-setup)) 'find-file)
  (pushnew '(file . find-file) org-link-frame-setup :test #'equal)
  ;;it might be nice to have a 'dedicated-buffer option
  (setf org-indirect-buffer-display 'current-window)
  ;;could make pop kill the buffer
;;;(setf org-display-internal-link-with-indirect-buffer t)
  (setf org-src-window-setup 'current-window)
  (add-hook 'org-capture-mode-hook 'delete-other-windows)
  (defadvice org-agenda-set-tags (around fix-windows activate compile)
    "Restore windows."
    (save-window-excursion
      ad-do-it))
  (defadvice org-export (after fix-windows activate compile)
    "Delete other windows after every export."
    (delete-other-windows))

  (setf pop-up-windows nil)

  ;;for emacs i do this

  (add-to-list 'same-window-regexps "\\*Customize.*") ;notwork?
  (setf Man-notify-method 'pushy)
  (add-to-list 'same-window-regexps "\\*Man .*") ;notwork
  (add-to-list 'same-window-regexps "\\*.*\\*")
  (add-to-list 'same-window-buffer-names "*Remember*")
  (add-to-list 'same-window-buffer-names "*Help*")
  (add-to-list 'same-window-buffer-names "*Apropos*")
  (add-to-list 'same-window-buffer-names "*Summary*")
  (add-to-list 'same-window-buffer-names "*Compile-Log*")
  (add-to-list 'same-window-buffer-names "*Ibuffer*")
  (add-to-list 'same-window-buffer-names " *Ibuffer*")
  (message "done fixing pop-up-windows"))
(when (getenv "mep")
  ;;it is i
  (defconst alpha-alpha-p t)
  (require 'org)
  (p)
  ;;necessary for large fonts
  (scroll-bar-mode -1))

;;;
;;;basic org features likely to affect many bug reports
;;;

(setq org-todo-keywords
      '((type  "NAKA(i)" "TODO(T)" "MAYBE(y)" "DOUBTFUL(l)"
         "|"
         "MOOT(m)")))

(setq org-agenda-window-setup 'current-window)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-06  4:29     ` Samuel Wales
@ 2015-08-07  0:30       ` Nicolas Goaziou
  2015-08-07  0:40         ` Samuel Wales
  2015-08-09 23:59       ` Samuel Wales
  1 sibling, 1 reply; 16+ messages in thread
From: Nicolas Goaziou @ 2015-08-07  0:30 UTC (permalink / raw)
  To: Samuel Wales; +Cc: Kyle Meyer, emacs-orgmode

Hello,

Samuel Wales <samologist@gmail.com> writes:

> can repro with -Q and this old testcase code and restriction lock and
> org-agenda-list.

I cannot reproduce it either. Did you try minimal example provided by
Kyle in this thread? Does it show the "no" headline?


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-07  0:30       ` Nicolas Goaziou
@ 2015-08-07  0:40         ` Samuel Wales
  2015-08-07  4:55           ` Samuel Wales
  0 siblings, 1 reply; 16+ messages in thread
From: Samuel Wales @ 2015-08-07  0:40 UTC (permalink / raw)
  To: Samuel Wales, Kyle Meyer, emacs-orgmode

On 8/6/15, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> I cannot reproduce it either. Did you try minimal example provided by
> Kyle in this thread? Does it show the "no" headline?

yes, i put the example into an entry, with odd levels only, in my
version of emacs as above, with my testcase as above, with -Q, and
restricted to that subtree.  then i called org-agenda-list.

it shows both yes and no headlines.

it seems as if org thinks that it is not commented.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-07  0:40         ` Samuel Wales
@ 2015-08-07  4:55           ` Samuel Wales
  2015-08-07  8:15             ` Nicolas Goaziou
  0 siblings, 1 reply; 16+ messages in thread
From: Samuel Wales @ 2015-08-07  4:55 UTC (permalink / raw)
  To: Samuel Wales, Kyle Meyer, emacs-orgmode

should (get-text-property (point-at-bol) :org-comment) be nil on a
commented headline?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-07  4:55           ` Samuel Wales
@ 2015-08-07  8:15             ` Nicolas Goaziou
  2015-08-07 20:29               ` Samuel Wales
  2015-08-07 20:30               ` Samuel Wales
  0 siblings, 2 replies; 16+ messages in thread
From: Nicolas Goaziou @ 2015-08-07  8:15 UTC (permalink / raw)
  To: Samuel Wales; +Cc: Kyle Meyer, emacs-orgmode

Samuel Wales <samologist@gmail.com> writes:

> should (get-text-property (point-at-bol) :org-comment) be nil on a
> commented headline?

Yes, once `org-agenda-prepare-buffers' has been called.

Regards,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-07  8:15             ` Nicolas Goaziou
@ 2015-08-07 20:29               ` Samuel Wales
  2015-08-07 20:30               ` Samuel Wales
  1 sibling, 0 replies; 16+ messages in thread
From: Samuel Wales @ 2015-08-07 20:29 UTC (permalink / raw)
  To: Samuel Wales, Kyle Meyer, emacs-orgmode

On 8/7/15, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Samuel Wales <samologist@gmail.com> writes:
>> should (get-text-property (point-at-bol) :org-comment) be nil on a
>> commented headline?
>
> Yes, once `org-agenda-prepare-buffers' has been called.

then i didn't understand the code.  (i thought that was how it
determined whether it was a commented headline to skip.)  (it's nil
but commented headers show.)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-07  8:15             ` Nicolas Goaziou
  2015-08-07 20:29               ` Samuel Wales
@ 2015-08-07 20:30               ` Samuel Wales
  2015-08-08  9:22                 ` Nicolas Goaziou
  1 sibling, 1 reply; 16+ messages in thread
From: Samuel Wales @ 2015-08-07 20:30 UTC (permalink / raw)
  To: Samuel Wales, Kyle Meyer, emacs-orgmode

On 8/7/15, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Samuel Wales <samologist@gmail.com> writes:
>> should (get-text-property (point-at-bol) :org-comment) be nil on a
>> commented headline?
>
> Yes, once `org-agenda-prepare-buffers' has been called.

ok, then i don't understand the code.  (i thought that was how it
determined whether it was a commented headline to skip.)  (it's nil
but commented headers show.)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-07 20:30               ` Samuel Wales
@ 2015-08-08  9:22                 ` Nicolas Goaziou
  2015-08-08 18:19                   ` Samuel Wales
  0 siblings, 1 reply; 16+ messages in thread
From: Nicolas Goaziou @ 2015-08-08  9:22 UTC (permalink / raw)
  To: Samuel Wales; +Cc: Kyle Meyer, emacs-orgmode

Samuel Wales <samologist@gmail.com> writes:

> ok, then i don't understand the code.  (i thought that was how it
> determined whether it was a commented headline to skip.)  (it's nil
> but commented headers show.)

My bad. I misread your question. It should be non-nil, indeed.

What is the return value of (org-in-commented-heading-p) on your
pseudo-commented headlines?

Regards,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-08  9:22                 ` Nicolas Goaziou
@ 2015-08-08 18:19                   ` Samuel Wales
  0 siblings, 0 replies; 16+ messages in thread
From: Samuel Wales @ 2015-08-08 18:19 UTC (permalink / raw)
  To: Samuel Wales, Kyle Meyer, emacs-orgmode

0 in outline
nil in agenda

On 8/8/15, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> What is the return value of (org-in-commented-heading-p) on your
> pseudo-commented headlines?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-06  4:29     ` Samuel Wales
  2015-08-07  0:30       ` Nicolas Goaziou
@ 2015-08-09 23:59       ` Samuel Wales
  2015-08-10  0:02         ` Samuel Wales
  1 sibling, 1 reply; 16+ messages in thread
From: Samuel Wales @ 2015-08-09 23:59 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode

can anybody else reproduce?

* x
*** TODO yes
DEADLINE: <2015-08-05 Wed>
**** TODO COMMENT no
DEADLINE: <2015-08-05 Wed>

On 8/5/15, Samuel Wales <samologist@gmail.com> wrote:
> 24.4.1
>
> can repro with -Q and this old testcase code and restriction lock and
> org-agenda-list.
>
> ===
>
> ;;;
> ;;;alpha-org-testcase.el
> ;;;
> ;;;minimal testcase for org
> ;;;
> ;;;   dorg=your-org-dir delorgsrc=your-org-src-dir emacs -Q -l
> alpha-org-testcase.el
> ;;;
>
> ;;;
> ;;;for my use i do this:
> ;;;
> "
> mep=t emacs -Q -l $del/tests-and-publish/alpha-org-testcase.el \
>   --geometry +0+0 \
>   --geometry 60x30 \
>   $dorg/tests--org--xyzzy-big/comment.org
> "
> ;;;
>
> (require 'cl)
>
> ;;my org files use these
> (setq org-odd-levels-only t)
> ;; (setf org-export-initial-scope 'subtree)
>
> ;;fix abominations
> (blink-cursor-mode 0)
> (setf visible-bell 'top-bottom)
>
> ;;basics
> (defun alpha-add-path (p) (setq load-path (cons p load-path)))
> (alpha-add-path (concat (getenv "delorgsrc") "/lisp"))
> (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
> (require 'org-install)
>
> (setq org-agenda-files (list (substitute-in-file-name
> "$dorg/todo-new--a.org")))
>
> ;;;
> ;;;stuff make things easier
> ;;;
>
> (setq org-completion-use-ido t)
> (setf org-outline-path-complete-in-steps nil)
>
> ;;;
> ;;;compatibility fixes
> ;;;
>
> ;; ;;fix compatibility bug in org [2011-05-25 Wed 08:59]
> ;; (when (= emacs-major-version 22)
> ;;   (defun activate-mark ()
> ;;     "Activate the mark."
> ;;     (when (mark t)
> ;;       (setq mark-active t)
> ;;       (unless transient-mark-mode
> ;;         (setq transient-mark-mode 'lambda))
> ;;       (when (and select-active-regions
> ;;                  (display-selections-p))
> ;;         (x-set-selection 'PRIMARY (current-buffer))))))
>
> ;; ;;[2011-05-25 Wed 09:23] fix compatibility bug in Org.
> ;; ;;this is redefinition.  it is for 22 for export.
> ;; (defcustom select-active-regions nil
> ;;  "If non-nil, an active region automatically becomes the window
> selection."
> ;;  :type 'boolean
> ;;  :group 'killing
> ;;  :version "23.1")
>
> ;;;
> ;;;accessibility fixes
> ;;;
>
> (defun p ()
>   (interactive)
>   (message "fixing pop-up-windows")
>   ;;i have /pop-up-windows/ set to nil, which works for most of
>   ;;emacs.  for org, i do the following.  i need all of this just
>   ;;as i need the large font above for accessibility reasons.
>   ;;
>   ;;(setf (cdr (assoc* 'file org-link-frame-setup)) 'find-file)
>   (pushnew '(file . find-file) org-link-frame-setup :test #'equal)
>   ;;it might be nice to have a 'dedicated-buffer option
>   (setf org-indirect-buffer-display 'current-window)
>   ;;could make pop kill the buffer
> ;;;(setf org-display-internal-link-with-indirect-buffer t)
>   (setf org-src-window-setup 'current-window)
>   (add-hook 'org-capture-mode-hook 'delete-other-windows)
>   (defadvice org-agenda-set-tags (around fix-windows activate compile)
>     "Restore windows."
>     (save-window-excursion
>       ad-do-it))
>   (defadvice org-export (after fix-windows activate compile)
>     "Delete other windows after every export."
>     (delete-other-windows))
>
>   (setf pop-up-windows nil)
>
>   ;;for emacs i do this
>
>   (add-to-list 'same-window-regexps "\\*Customize.*") ;notwork?
>   (setf Man-notify-method 'pushy)
>   (add-to-list 'same-window-regexps "\\*Man .*") ;notwork
>   (add-to-list 'same-window-regexps "\\*.*\\*")
>   (add-to-list 'same-window-buffer-names "*Remember*")
>   (add-to-list 'same-window-buffer-names "*Help*")
>   (add-to-list 'same-window-buffer-names "*Apropos*")
>   (add-to-list 'same-window-buffer-names "*Summary*")
>   (add-to-list 'same-window-buffer-names "*Compile-Log*")
>   (add-to-list 'same-window-buffer-names "*Ibuffer*")
>   (add-to-list 'same-window-buffer-names " *Ibuffer*")
>   (message "done fixing pop-up-windows"))
> (when (getenv "mep")
>   ;;it is i
>   (defconst alpha-alpha-p t)
>   (require 'org)
>   (p)
>   ;;necessary for large fonts
>   (scroll-bar-mode -1))
>
> ;;;
> ;;;basic org features likely to affect many bug reports
> ;;;
>
> (setq org-todo-keywords
>       '((type  "NAKA(i)" "TODO(T)" "MAYBE(y)" "DOUBTFUL(l)"
>          "|"
>          "MOOT(m)")))
>
> (setq org-agenda-window-setup 'current-window)
>


-- 
The Kafka Pandemic: http://thekafkapandemic.blogspot.com

Ramsay's disease DOES progress.  MANY people have died from it.  And
ANYBODY can get it.

Denmark: free Karina Hansen NOW.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-09 23:59       ` Samuel Wales
@ 2015-08-10  0:02         ` Samuel Wales
  2015-08-10  0:17           ` Samuel Wales
  0 siblings, 1 reply; 16+ messages in thread
From: Samuel Wales @ 2015-08-10  0:02 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode

oops, the previous test case file was wrong, but the code for -Q
reproduction was correct.  here is a correct test case file:

* x
*** y
***** TODO yes
DEADLINE: <2015-08-05 Wed>
***** TODO COMMENT no
DEADLINE: <2015-08-05 Wed>
***** asasasas
DEADLINE: <2015-08-05 Wed>
******* asdfasdfasdf
******* fdasdfasdfasdfasdf
******* asdfasdfasdfasdfasdfasdf

On 8/9/15, Samuel Wales <samologist@gmail.com> wrote:
> can anybody else reproduce?
>
> * x
> *** TODO yes
> DEADLINE: <2015-08-05 Wed>
> **** TODO COMMENT no
> DEADLINE: <2015-08-05 Wed>
>
> On 8/5/15, Samuel Wales <samologist@gmail.com> wrote:
>> 24.4.1
>>
>> can repro with -Q and this old testcase code and restriction lock and
>> org-agenda-list.
>>
>> ===
>>
>> ;;;
>> ;;;alpha-org-testcase.el
>> ;;;
>> ;;;minimal testcase for org
>> ;;;
>> ;;;   dorg=your-org-dir delorgsrc=your-org-src-dir emacs -Q -l
>> alpha-org-testcase.el
>> ;;;
>>
>> ;;;
>> ;;;for my use i do this:
>> ;;;
>> "
>> mep=t emacs -Q -l $del/tests-and-publish/alpha-org-testcase.el \
>>   --geometry +0+0 \
>>   --geometry 60x30 \
>>   $dorg/tests--org--xyzzy-big/comment.org
>> "
>> ;;;
>>
>> (require 'cl)
>>
>> ;;my org files use these
>> (setq org-odd-levels-only t)
>> ;; (setf org-export-initial-scope 'subtree)
>>
>> ;;fix abominations
>> (blink-cursor-mode 0)
>> (setf visible-bell 'top-bottom)
>>
>> ;;basics
>> (defun alpha-add-path (p) (setq load-path (cons p load-path)))
>> (alpha-add-path (concat (getenv "delorgsrc") "/lisp"))
>> (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
>> (require 'org-install)
>>
>> (setq org-agenda-files (list (substitute-in-file-name
>> "$dorg/todo-new--a.org")))
>>
>> ;;;
>> ;;;stuff make things easier
>> ;;;
>>
>> (setq org-completion-use-ido t)
>> (setf org-outline-path-complete-in-steps nil)
>>
>> ;;;
>> ;;;compatibility fixes
>> ;;;
>>
>> ;; ;;fix compatibility bug in org [2011-05-25 Wed 08:59]
>> ;; (when (= emacs-major-version 22)
>> ;;   (defun activate-mark ()
>> ;;     "Activate the mark."
>> ;;     (when (mark t)
>> ;;       (setq mark-active t)
>> ;;       (unless transient-mark-mode
>> ;;         (setq transient-mark-mode 'lambda))
>> ;;       (when (and select-active-regions
>> ;;                  (display-selections-p))
>> ;;         (x-set-selection 'PRIMARY (current-buffer))))))
>>
>> ;; ;;[2011-05-25 Wed 09:23] fix compatibility bug in Org.
>> ;; ;;this is redefinition.  it is for 22 for export.
>> ;; (defcustom select-active-regions nil
>> ;;  "If non-nil, an active region automatically becomes the window
>> selection."
>> ;;  :type 'boolean
>> ;;  :group 'killing
>> ;;  :version "23.1")
>>
>> ;;;
>> ;;;accessibility fixes
>> ;;;
>>
>> (defun p ()
>>   (interactive)
>>   (message "fixing pop-up-windows")
>>   ;;i have /pop-up-windows/ set to nil, which works for most of
>>   ;;emacs.  for org, i do the following.  i need all of this just
>>   ;;as i need the large font above for accessibility reasons.
>>   ;;
>>   ;;(setf (cdr (assoc* 'file org-link-frame-setup)) 'find-file)
>>   (pushnew '(file . find-file) org-link-frame-setup :test #'equal)
>>   ;;it might be nice to have a 'dedicated-buffer option
>>   (setf org-indirect-buffer-display 'current-window)
>>   ;;could make pop kill the buffer
>> ;;;(setf org-display-internal-link-with-indirect-buffer t)
>>   (setf org-src-window-setup 'current-window)
>>   (add-hook 'org-capture-mode-hook 'delete-other-windows)
>>   (defadvice org-agenda-set-tags (around fix-windows activate compile)
>>     "Restore windows."
>>     (save-window-excursion
>>       ad-do-it))
>>   (defadvice org-export (after fix-windows activate compile)
>>     "Delete other windows after every export."
>>     (delete-other-windows))
>>
>>   (setf pop-up-windows nil)
>>
>>   ;;for emacs i do this
>>
>>   (add-to-list 'same-window-regexps "\\*Customize.*") ;notwork?
>>   (setf Man-notify-method 'pushy)
>>   (add-to-list 'same-window-regexps "\\*Man .*") ;notwork
>>   (add-to-list 'same-window-regexps "\\*.*\\*")
>>   (add-to-list 'same-window-buffer-names "*Remember*")
>>   (add-to-list 'same-window-buffer-names "*Help*")
>>   (add-to-list 'same-window-buffer-names "*Apropos*")
>>   (add-to-list 'same-window-buffer-names "*Summary*")
>>   (add-to-list 'same-window-buffer-names "*Compile-Log*")
>>   (add-to-list 'same-window-buffer-names "*Ibuffer*")
>>   (add-to-list 'same-window-buffer-names " *Ibuffer*")
>>   (message "done fixing pop-up-windows"))
>> (when (getenv "mep")
>>   ;;it is i
>>   (defconst alpha-alpha-p t)
>>   (require 'org)
>>   (p)
>>   ;;necessary for large fonts
>>   (scroll-bar-mode -1))
>>
>> ;;;
>> ;;;basic org features likely to affect many bug reports
>> ;;;
>>
>> (setq org-todo-keywords
>>       '((type  "NAKA(i)" "TODO(T)" "MAYBE(y)" "DOUBTFUL(l)"
>>          "|"
>>          "MOOT(m)")))
>>
>> (setq org-agenda-window-setup 'current-window)
>>
>
>
> --
> The Kafka Pandemic: http://thekafkapandemic.blogspot.com
>
> Ramsay's disease DOES progress.  MANY people have died from it.  And
> ANYBODY can get it.
>
> Denmark: free Karina Hansen NOW.
>


-- 
The Kafka Pandemic: http://thekafkapandemic.blogspot.com

Ramsay's disease DOES progress.  MANY people have died from it.  And
ANYBODY can get it.

Denmark: free Karina Hansen NOW.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-10  0:02         ` Samuel Wales
@ 2015-08-10  0:17           ` Samuel Wales
  2015-08-10 12:00             ` Nicolas Goaziou
  0 siblings, 1 reply; 16+ messages in thread
From: Samuel Wales @ 2015-08-10  0:17 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode

ok, better testcase below.  please ignore last 2 messages.

complete with code, data, explanation, and steps to reproduce.

* commented subtrees show in agenda even if org-agenda-skip-comment-trees is t
to reproduce, load the code below, find this file, put
restriction lock on this subtree (< at bol above or c-c c-x
< here) and run m-x org-agenda-list.
*** what i get
Day-agenda (W32):
2015-08-09 Sun
  comment:    Deadline:   no should not show
  comment:    Deadline:   no should not show
  comment:     4 d. ago:  TODO yes this should show
  comment:     4 d. ago:  TODO COMMENT this one is possibly bad
syntax, so don't know if it should show
  comment:     4 d. ago:  COMMENT TODO no this should not show
  comment:     4 d. ago:  yes should show
  comment:     4 d. ago:  COMMENT no should not show
*** y
***** TODO yes this should show
DEADLINE: <2015-08-05 Wed>
***** TODO COMMENT this one is possibly bad syntax, so don't know if
it should show
DEADLINE: <2015-08-05 Wed>
******* bad syntax
***** COMMENT TODO no this should not show
DEADLINE: <2015-08-05 Wed>
******* no should not show
DEADLINE: <2015-08-09 Sun>
***** yes should show
DEADLINE: <2015-08-05 Wed>
***** COMMENT no should not show
DEADLINE: <2015-08-05 Wed>
******* no should not show
DEADLINE: <2015-08-09 Sun>
*** code to reproduce with -Q
24.4.1

can repro with -Q and this old testcase code and restriction lock and
org-agenda-list.

===

;;;
;;;alpha-org-testcase.el
;;;
;;;minimal testcase for org
;;;
;;;   dorg=your-org-dir delorgsrc=your-org-src-dir emacs -Q -l
alpha-org-testcase.el
;;;

;;;
;;;for my use i do this:
;;;
"
mep=t emacs -Q -l $del/tests-and-publish/alpha-org-testcase.el \
  --geometry +0+0 \
  --geometry 60x30 \
  $dorg/tests--org--xyzzy-big/comment.org
"
;;;

(require 'cl)

;;my org files use these
(setq org-odd-levels-only t)
;; (setf org-export-initial-scope 'subtree)

;;fix abominations
(blink-cursor-mode 0)
(setf visible-bell 'top-bottom)

;;basics
(defun alpha-add-path (p) (setq load-path (cons p load-path)))
(alpha-add-path (concat (getenv "delorgsrc") "/lisp"))
(add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
(require 'org-install)

(setq org-agenda-files (list (substitute-in-file-name "$dorg/todo-new--a.org")))

;;;
;;;stuff make things easier
;;;

(setq org-completion-use-ido t)
(setf org-outline-path-complete-in-steps nil)

;;;
;;;compatibility fixes
;;;

;; ;;fix compatibility bug in org [2011-05-25 Wed 08:59]
;; (when (= emacs-major-version 22)
;;   (defun activate-mark ()
;;     "Activate the mark."
;;     (when (mark t)
;;       (setq mark-active t)
;;       (unless transient-mark-mode
;;         (setq transient-mark-mode 'lambda))
;;       (when (and select-active-regions
;;                  (display-selections-p))
;;         (x-set-selection 'PRIMARY (current-buffer))))))

;; ;;[2011-05-25 Wed 09:23] fix compatibility bug in Org.
;; ;;this is redefinition.  it is for 22 for export.
;; (defcustom select-active-regions nil
;;  "If non-nil, an active region automatically becomes the window selection."
;;  :type 'boolean
;;  :group 'killing
;;  :version "23.1")

;;;
;;;accessibility fixes
;;;

(defun p ()
  (interactive)
  (message "fixing pop-up-windows")
  ;;i have /pop-up-windows/ set to nil, which works for most of
  ;;emacs.  for org, i do the following.  i need all of this just
  ;;as i need the large font above for accessibility reasons.
  ;;
  ;;(setf (cdr (assoc* 'file org-link-frame-setup)) 'find-file)
  (pushnew '(file . find-file) org-link-frame-setup :test #'equal)
  ;;it might be nice to have a 'dedicated-buffer option
  (setf org-indirect-buffer-display 'current-window)
  ;;could make pop kill the buffer
;;;(setf org-display-internal-link-with-indirect-buffer t)
  (setf org-src-window-setup 'current-window)
  (add-hook 'org-capture-mode-hook 'delete-other-windows)
  (defadvice org-agenda-set-tags (around fix-windows activate compile)
    "Restore windows."
    (save-window-excursion
      ad-do-it))
  (defadvice org-export (after fix-windows activate compile)
    "Delete other windows after every export."
    (delete-other-windows))

  (setf pop-up-windows nil)

  ;;for emacs i do this

  (add-to-list 'same-window-regexps "\\*Customize.*") ;notwork?
  (setf Man-notify-method 'pushy)
  (add-to-list 'same-window-regexps "\\*Man .*") ;notwork
  (add-to-list 'same-window-regexps "\\*.*\\*")
  (add-to-list 'same-window-buffer-names "*Remember*")
  (add-to-list 'same-window-buffer-names "*Help*")
  (add-to-list 'same-window-buffer-names "*Apropos*")
  (add-to-list 'same-window-buffer-names "*Summary*")
  (add-to-list 'same-window-buffer-names "*Compile-Log*")
  (add-to-list 'same-window-buffer-names "*Ibuffer*")
  (add-to-list 'same-window-buffer-names " *Ibuffer*")
  (message "done fixing pop-up-windows"))
(when (getenv "mep")
  ;;it is i
  (defconst alpha-alpha-p t)
  (require 'org)
  (p)
  ;;necessary for large fonts
  (scroll-bar-mode -1))

;;;
;;;basic org features likely to affect many bug reports
;;;

(setq org-todo-keywords
      '((type  "NAKA(i)" "TODO(T)" "MAYBE(y)" "DOUBTFUL(l)"
         "|"
         "MOOT(m)")))

(setq org-agenda-window-setup 'current-window)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: comment trees in 8.3
  2015-08-10  0:17           ` Samuel Wales
@ 2015-08-10 12:00             ` Nicolas Goaziou
  0 siblings, 0 replies; 16+ messages in thread
From: Nicolas Goaziou @ 2015-08-10 12:00 UTC (permalink / raw)
  To: Samuel Wales; +Cc: Kyle Meyer, emacs-orgmode

Samuel Wales <samologist@gmail.com> writes:

> ok, better testcase below.  please ignore last 2 messages.
>
> complete with code, data, explanation, and steps to reproduce.

Reproduced, and fixed. Thank you.

>   comment:     4 d. ago:  TODO COMMENT this one is possibly bad syntax
>   comment:     4 d. ago:  COMMENT TODO no this should not show

This is the other way around:

  - TODO COMMENT is a commented task (i.e., a TODO headline)
  - COMMENT TODO is a commented headline whose title happens to start with "TODO"

Regards,

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2015-08-10 11:59 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-06  3:31 comment trees in 8.3 Samuel Wales
2015-08-06  3:32 ` Samuel Wales
2015-08-06  4:01   ` Kyle Meyer
2015-08-06  4:29     ` Samuel Wales
2015-08-07  0:30       ` Nicolas Goaziou
2015-08-07  0:40         ` Samuel Wales
2015-08-07  4:55           ` Samuel Wales
2015-08-07  8:15             ` Nicolas Goaziou
2015-08-07 20:29               ` Samuel Wales
2015-08-07 20:30               ` Samuel Wales
2015-08-08  9:22                 ` Nicolas Goaziou
2015-08-08 18:19                   ` Samuel Wales
2015-08-09 23:59       ` Samuel Wales
2015-08-10  0:02         ` Samuel Wales
2015-08-10  0:17           ` Samuel Wales
2015-08-10 12:00             ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).