emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* org-link-minor-mode.el broken by recent org maint
@ 2017-06-08  1:07 Samuel Wales
  2017-06-08  6:51 ` Nicolas Goaziou
  0 siblings, 1 reply; 9+ messages in thread
From: Samuel Wales @ 2017-06-08  1:07 UTC (permalink / raw)
  To: emacs-orgmode

org-link-minor-mode broken by recent maint.  both links and tses.

anybody else?

cannot bisect but these seem suspicious by name:

439fcfb * Fix link fontification
2d29269 * Fix link fontification

-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: org-link-minor-mode.el broken by recent org maint
  2017-06-08  1:07 org-link-minor-mode.el broken by recent org maint Samuel Wales
@ 2017-06-08  6:51 ` Nicolas Goaziou
  2017-06-08  9:55   ` Kaushal Modi
  0 siblings, 1 reply; 9+ messages in thread
From: Nicolas Goaziou @ 2017-06-08  6:51 UTC (permalink / raw)
  To: Samuel Wales; +Cc: emacs-orgmode

Hello,

Samuel Wales <samologist@gmail.com> writes:

> org-link-minor-mode broken by recent maint.  both links and tses.

I don't know what is `org-link-minor-mode'.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: org-link-minor-mode.el broken by recent org maint
  2017-06-08  6:51 ` Nicolas Goaziou
@ 2017-06-08  9:55   ` Kaushal Modi
  2017-06-08 11:06     ` Nicolas Goaziou
  0 siblings, 1 reply; 9+ messages in thread
From: Kaushal Modi @ 2017-06-08  9:55 UTC (permalink / raw)
  To: Nicolas Goaziou, Samuel Wales; +Cc: emacs-org list

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

On Thu, Jun 8, 2017, 2:52 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> Hello,
>
> Samuel Wales <samologist@gmail.com> writes:
>
> > org-link-minor-mode broken by recent maint.  both links and tses.
>
> I don't know what is `org-link-minor-mode'.
>

I don't use this package, but it looks like this one:
https://github.com/seanohalpin/org-link-minor-mode

Also it hasn't been updated in 5 years; it's from org 7 era.

> --

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1153 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: org-link-minor-mode.el broken by recent org maint
  2017-06-08  9:55   ` Kaushal Modi
@ 2017-06-08 11:06     ` Nicolas Goaziou
  2017-06-08 21:59       ` Samuel Wales
  0 siblings, 1 reply; 9+ messages in thread
From: Nicolas Goaziou @ 2017-06-08 11:06 UTC (permalink / raw)
  To: Kaushal Modi; +Cc: emacs-org list

Hello,

Kaushal Modi <kaushal.modi@gmail.com> writes:

> On Thu, Jun 8, 2017, 2:52 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
>> Hello,
>>
>> Samuel Wales <samologist@gmail.com> writes:
>>
>> > org-link-minor-mode broken by recent maint.  both links and tses.
>>
>> I don't know what is `org-link-minor-mode'.
>>
>
> I don't use this package, but it looks like this one:
> https://github.com/seanohalpin/org-link-minor-mode

OK. Thank you.

I added backward compatible aliases in "org-compat". Hopefully, this
should make the minor mode operational again.
>
> Also it hasn't been updated in 5 years; it's from org 7 era.

Samuel, would you want to contact the author and suggest him to make the
following change:

  (let ((org-link-minor-mode-keywords
         (list
          '(org-activate-angle-links (0 'org-link t))
          '(org-activate-plain-links)
          '(org-activate-bracket-links (0 'org-link t))
          '(org-activate-dates (0 'org-date t))
          ))
        ...))

  =>

  (let ((org-link-minor-mode-keywords
         '((org-activate-links))))
    ...)

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: org-link-minor-mode.el broken by recent org maint
@ 2017-06-08 15:28 Stefan Hahn
  2017-06-14 19:35 ` Samuel Wales
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Hahn @ 2017-06-08 15:28 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Please see:

https://github.com/swhahn/org-link-minor-mode

With kind regards,
Stefan

[-- Attachment #2: Type: text/html, Size: 176 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: org-link-minor-mode.el broken by recent org maint
  2017-06-08 11:06     ` Nicolas Goaziou
@ 2017-06-08 21:59       ` Samuel Wales
  0 siblings, 0 replies; 9+ messages in thread
From: Samuel Wales @ 2017-06-08 21:59 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-org list, Kaushal Modi

On 6/8/17, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>>> I don't know what is `org-link-minor-mode'.

it is rather nice to put org-id links in your elisp code [or any
non-org] so that you can click on them and get a description in your
org files.  or a website.  or a search link to a place in your code.

it does timestamps also.

> I added backward compatible aliases in "org-compat". Hopefully, this
> should make the minor mode operational again.

thank you.

stefan's link https://github.com/swhahn/org-link-minor-mode [possibly
his repo] looks like an up to date fork with additional changes.

> Samuel, would you want to contact the author and suggest him to make the
> following change:

swhahn seems to have made a similar change.

thanks.

-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: org-link-minor-mode.el broken by recent org maint
  2017-06-08 15:28 Stefan Hahn
@ 2017-06-14 19:35 ` Samuel Wales
  2017-06-15 15:59   ` Stefan-W. Hahn
  0 siblings, 1 reply; 9+ messages in thread
From: Samuel Wales @ 2017-06-14 19:35 UTC (permalink / raw)
  To: Stefan Hahn; +Cc: emacs-orgmode

On 6/8/17, Stefan Hahn <stefan.hahn@s-hahn.de> wrote:
> Please see:
>
> https://github.com/swhahn/org-link-minor-mode

this looks great!  thanks!

getting compilation issues:

In org-link-minor-mode-unfontify-region:
org-link-minor-mode.el:30:43:Warning: `org-decompose-region' is an obsolete
    function (as of Org 9.0); use `decompose-region' instead.

In org-link-minor-mode:
org-link-minor-mode.el:66:39:Warning: variable reference to nonvariable
    `(quote (org-activate-plain-links))'
org-link-minor-mode.el:66:39:Error: Wrong type argument: symbolp,
(quote (org-activate-plain-links))

-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: org-link-minor-mode.el broken by recent org maint
  2017-06-14 19:35 ` Samuel Wales
@ 2017-06-15 15:59   ` Stefan-W. Hahn
  2017-07-17  3:32     ` Samuel Wales
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan-W. Hahn @ 2017-06-15 15:59 UTC (permalink / raw)
  To: Samuel Wales; +Cc: emacs-orgmode

Mail von Samuel Wales, Wed, 14 Jun 2017 at 12:35:42 -0700:
> On 6/8/17, Stefan Hahn <stefan.hahn@s-hahn.de> wrote:
> > Please see:
> >
> > https://github.com/swhahn/org-link-minor-mode
> 
> this looks great!  thanks!

Thank you.

> 
> getting compilation issues:
> 
> In org-link-minor-mode-unfontify-region:
> org-link-minor-mode.el:30:43:Warning: `org-decompose-region' is an obsolete
>     function (as of Org 9.0); use `decompose-region' instead.
> 
> In org-link-minor-mode:
> org-link-minor-mode.el:66:39:Warning: variable reference to nonvariable
>     `(quote (org-activate-plain-links))'
> org-link-minor-mode.el:66:39:Error: Wrong type argument: symbolp,
> (quote (org-activate-plain-links))
> 

I just pushed a new version which now compiles without flaws togehter
with org v8 and org v9.

With kind regards,
Stefan


-- 
Stefan-W. Hahn                          It is easy to make things.
                                        It is hard to make things simple.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: org-link-minor-mode.el broken by recent org maint
  2017-06-15 15:59   ` Stefan-W. Hahn
@ 2017-07-17  3:32     ` Samuel Wales
  0 siblings, 0 replies; 9+ messages in thread
From: Samuel Wales @ 2017-07-17  3:32 UTC (permalink / raw)
  To: Stefan-W. Hahn; +Cc: emacs-orgmode

Thank you!  It's useful!

On 6/15/17, Stefan-W. Hahn <stefan.hahn@s-hahn.de> wrote:
> I just pushed a new version which now compiles without flaws togehter
> with org v8 and org v9.

-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-07-17  3:32 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-08  1:07 org-link-minor-mode.el broken by recent org maint Samuel Wales
2017-06-08  6:51 ` Nicolas Goaziou
2017-06-08  9:55   ` Kaushal Modi
2017-06-08 11:06     ` Nicolas Goaziou
2017-06-08 21:59       ` Samuel Wales
  -- strict thread matches above, loose matches on Subject: below --
2017-06-08 15:28 Stefan Hahn
2017-06-14 19:35 ` Samuel Wales
2017-06-15 15:59   ` Stefan-W. Hahn
2017-07-17  3:32     ` Samuel Wales

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).