emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Samuel Wales <samologist@gmail.com>
To: Karl Fogel <kfogel@red-bean.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: Removing obsolete function `org-truely-invisible-p'.
Date: Sat, 4 Dec 2021 15:19:27 -0700	[thread overview]
Message-ID: <CAJcAo8uUkzdcFHz5M6ig3qm4x1p6qXGkiVUZFfTt59TKnVtDWg@mail.gmail.com> (raw)
In-Reply-To: <87czmcccrp.fsf@red-bean.com>

idk and will go along with whatever developers decide, but your note
was a good reminder that visible mode can be checked.

also made me wonder if it is possible to move anything from org-macs
out to topic-specific files like org-visibility.el or so?  no?

[idk what org visibility functions do what.  although i suspect org
can do it, i still use htmlize-buffer-substring-no-invisible.]


On 12/4/21, Karl Fogel <kfogel@red-bean.com> wrote:
> The function `org-truely-invisible-p' is defined in
> 'lisp/org-macs.el', but it is not used anywhere anymore in Org
> Mode, nor is it used anywhere in GNU Emacs (I checked on both
> 'emacs-28' branch and 'master' branch).
>
> The last (and possibly only?) call to that function was removed
> from `org-beginning-of-line' in this commit:
>
>   commit 3baf246f4f73005a4eacd7c368f7222f95d50243
>   Author:     Nicolas Goaziou <mail@nicolasgoaziou.fr>
>   AuthorDate: Thu Apr 28 23:28:15 2016 +0200
>   Commit:     Nicolas Goaziou <mail@nicolasgoaziou.fr>
>   CommitDate: Thu Apr 28 23:28:15 2016 +0200
>
>       Handle correctly `shift-select-mode'
>
>       * lisp/org.el (org-beginning-of-line): Handle correctly
>       `shift-select-mode'.
>
>       Reported-by: Mathieu Marques <mathieumarques78@gmail.com>
>       <http://permalink.gmane.org/gmane.emacs.orgmode/106783>
>
> Then, a few months later in commit 87116700e6e, Nicholas moved the
> function to 'org-macs.el', where it has been sitting unused ever
> since.
>
> Should we just remove `org-truely-invisible-p'?  Or at least
> correct the spelling of its name ("truely" should be "truly")?
>
> It seems fairly unlikely to me that people are using it in their
> own code, although of course I cannot be sure of that.  Partly, I
> believe that because surely someone else would have noticed the
> misspelling by now, if enough people were using it :-).
>
> Best regards,
> -Karl
>
>


-- 
The Kafka Pandemic

A blog about science, health, human rights, and misopathy:
https://thekafkapandemic.blogspot.com


  reply	other threads:[~2021-12-04 22:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-04 20:53 Karl Fogel
2021-12-04 22:19 ` Samuel Wales [this message]
2021-12-19  9:14 ` Ihor Radchenko
2022-04-01  0:28   ` Karl Fogel
2022-04-04 11:55     ` Ihor Radchenko
2022-04-04 16:20       ` Karl Fogel
2022-04-05  6:14         ` Ihor Radchenko
2022-04-05 17:08           ` Linking by Message-ID Max Nikulin
2022-04-05 18:41           ` Removing obsolete function `org-truely-invisible-p' Karl Fogel
2022-04-07  4:59             ` Ihor Radchenko
2022-04-07 16:57               ` Karl Fogel
2022-04-15  9:33                 ` [PATCH] CONTRIBUTE: Link WORG page when explaining commit message format Ihor Radchenko
2022-04-15 12:47                   ` Robert Pluim
2022-04-15 21:13                     ` Karl Fogel
2022-04-16  9:35                     ` Ihor Radchenko
2022-04-23  8:06                   ` Ihor Radchenko
2022-04-23 15:47                     ` Karl Fogel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJcAo8uUkzdcFHz5M6ig3qm4x1p6qXGkiVUZFfTt59TKnVtDWg@mail.gmail.com \
    --to=samologist@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kfogel@red-bean.com \
    --subject='Re: Removing obsolete function `org-truely-invisible-p'\''.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).