From: Ihor Radchenko <firstname.lastname@example.org> To: Karl Fogel <email@example.com> Cc: Org Mode <firstname.lastname@example.org> Subject: Re: Removing obsolete function `org-truely-invisible-p'. Date: Thu, 07 Apr 2022 12:59:03 +0800 [thread overview] Message-ID: <87czht7alk.fsf@localhost> (raw) In-Reply-To: <email@example.com> Karl Fogel <firstname.lastname@example.org> writes: > Unfortunately, the 'CONTRIBUTE' file at the top level of the Org > Mode source tree gives incomplete guidance on commit messages (it > just says to follow what Emacs does, so I did that). I didn't > realize that > https://orgmode.org/worg/org-contribute.html#commit-messages has > further, slightly different guidance. Could you elaborate? We have the following in etc/CONTRIBUTE: >>> * Main contribution rules >>> ... >>> See [[https://orgmode.org/worg/org-contribute.html][worg/org-contribute]] for guidance on how to contribute effectively. > A revised patch is attached. Now it's so simple that I think the > commit message doesn't need to point to the mailing list > discussion anyway. Review welcome. Thanks! Merged as d80aa2776 to main. Best, Ihor
next prev parent reply other threads:[~2022-04-07 4:59 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-04 20:53 Karl Fogel 2021-12-04 22:19 ` Samuel Wales 2021-12-19 9:14 ` Ihor Radchenko 2022-04-01 0:28 ` Karl Fogel 2022-04-04 11:55 ` Ihor Radchenko 2022-04-04 16:20 ` Karl Fogel 2022-04-05 6:14 ` Ihor Radchenko 2022-04-05 17:08 ` Linking by Message-ID Max Nikulin 2022-04-05 18:41 ` Removing obsolete function `org-truely-invisible-p' Karl Fogel 2022-04-07 4:59 ` Ihor Radchenko [this message] 2022-04-07 16:57 ` Karl Fogel 2022-04-15 9:33 ` [PATCH] CONTRIBUTE: Link WORG page when explaining commit message format Ihor Radchenko 2022-04-15 12:47 ` Robert Pluim 2022-04-15 21:13 ` Karl Fogel 2022-04-16 9:35 ` Ihor Radchenko 2022-04-23 8:06 ` Ihor Radchenko 2022-04-23 15:47 ` Karl Fogel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87czht7alk.fsf@localhost \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Removing obsolete function `org-truely-invisible-p'\''.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).