From: Sacha Chua <sacha@sachachua.com>
To: Sacha Chua <sacha@sachachua.com>, emacs list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Add :target option for the TOC keyword
Date: Wed, 5 Jun 2019 15:20:01 -0400 [thread overview]
Message-ID: <CAJGZZeLs88KRBe5s25NbKVuLOcE6E+5bjMtO90gVHNJO3sH_SA@mail.gmail.com> (raw)
In-Reply-To: <87blziy4bw.fsf@nicolasgoaziou.fr>
[-- Attachment #1.1: Type: text/plain, Size: 687 bytes --]
Whoops, I'm so sorry - I accidentally used org-make-link-string instead of
org-link-make-string. Tiny patch fixing it attached.
Sacha Chua - sacha@sachachua.com - Blog: sachachua.com - Mobile: +1 416 823
2669
On Fri, May 31, 2019 at 12:30 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Hello,
>
> Sacha Chua <sacha@sachachua.com> writes:
>
> > - catch the signal raised by org-export-resolve-fuzzy-link and then
> check for the
> > special case of "local"
> > - always handle :target "local" as a local TOC
> > - or just leave the behaviour as it is. What would you recommend?
>
> The latter is fine.
>
> I applied you patch. Thank you.
>
> Regards,
>
> --
> Nicolas Goaziou
>
[-- Attachment #1.2: Type: text/html, Size: 1521 bytes --]
[-- Attachment #2: 0001-org-export-resolve-link-Use-org-link-make-string.patch --]
[-- Type: text/x-patch, Size: 881 bytes --]
From 265886aedf202cce3cc7ab4f88bab318dd69ca86 Mon Sep 17 00:00:00 2001
From: Sacha Chua <sacha@sachachua.com>
Date: Wed, 5 Jun 2019 15:17:57 -0400
Subject: [PATCH] org-export-resolve-link: Use org-link-make-string
* lisp/ox.el (org-export-resolve-link): Use org-link-make-string
instead of org-make-link-string.
---
lisp/ox.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/ox.el b/lisp/ox.el
index e989b37c6..05c8daebc 100644
--- a/lisp/ox.el
+++ b/lisp/ox.el
@@ -4478,7 +4478,7 @@ Return value can be an object or an element:
(when (stringp link)
(setq link (with-temp-buffer
(save-excursion
- (insert (org-make-link-string link)))
+ (insert (org-link-make-string link)))
(org-element-link-parser))))
(pcase (org-element-property :type link)
((or "custom-id" "id") (org-export-resolve-id-link link info))
--
2.17.1
prev parent reply other threads:[~2019-06-05 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 18:54 [PATCH] Add :target option for the TOC keyword Sacha Chua
2019-05-21 19:43 ` Nicolas Goaziou
2019-05-29 15:40 ` Sacha Chua
2019-05-31 16:30 ` Nicolas Goaziou
2019-06-05 19:20 ` Sacha Chua [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJGZZeLs88KRBe5s25NbKVuLOcE6E+5bjMtO90gVHNJO3sH_SA@mail.gmail.com \
--to=sacha@sachachua.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).