emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Sacha Chua <sacha@sachachua.com>
Cc: dc@toedt.com, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add :target option for the TOC keyword
Date: Tue, 21 May 2019 21:43:12 +0200	[thread overview]
Message-ID: <87zhnf1tm7.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87woir7dm5.fsf@sachachua.com> (Sacha Chua's message of "Wed, 15 May 2019 14:54:10 -0400")

Hello,

Sacha Chua <sacha@sachachua.com> writes:

> Hi! Here's a patch to allow table of contents to target a specified
> headline. I've added tests for HTML, ASCII, Markdown, and ODT export.
> I should have copyright assignment papers already on file.
>
> Does it work for anyone other than me? =)

Thank you! I cannot guess the use case, but you certainly have one :)

Even if this doesn't sound like a very common need, it doesn't add too
much overhead to the code base either. It would be nice if it really
generalized "local" keyword, i.e., with ":target local", "local" variant
being supported but not documented.

Also, there seems to be much code duplication in the export back-ends.
Would it make sense to factor this out into a function in "ox.el". For
example, `org-export-resolve-link-string' or some such? With some tests
for bonus points.

Speaking of tests, we usually don't write tests for export back-ends, so
you can drop them.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2019-05-21 19:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 18:54 [PATCH] Add :target option for the TOC keyword Sacha Chua
2019-05-21 19:43 ` Nicolas Goaziou [this message]
2019-05-29 15:40   ` Sacha Chua
2019-05-31 16:30     ` Nicolas Goaziou
2019-06-05 19:20       ` Sacha Chua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhnf1tm7.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=dc@toedt.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=sacha@sachachua.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).