emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* loss of text properties in org-export--generate-copy-script
@ 2018-11-27 18:21 John Kitchin
  2018-11-27 22:49 ` Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: John Kitchin @ 2018-11-27 18:21 UTC (permalink / raw)
  To: org-mode-email

[-- Attachment #1: Type: text/plain, Size: 1855 bytes --]

In the function org-export--generate-copy-script, the buffer contents are
copied over with buffer-substring-no-properties, so it appears that all
text properties are lost in the temporary copy.

I wondered why that is done?

I came across this because I was using text properties to find pieces of
text to modify before exporting in a org-export-before hook, but it doesn't
work since the text properties are gone.

The text properties are put on by font-lock. Curiously, if I add these
three lines

  (switch-to-buffer (current-buffer))
  (sem-mode 1)  # refontifies buffer
  (message-box "")

then the text-properties are put back on and I can find them again. If
leave the first or last line off though, this does not work. The last line
is especially mystifying.

Here is a minimal example that shows the issue. When you run the src block,
the word red will be italicized, and when you export it red will be turned
into the word yellow. without the unintuitive switch-to-buffer and message
box lines though, you will get an error.

Any ideas on what is happening here?

# begin
This is red.


#+BEGIN_SRC emacs-lisp :results silent :exports none
(font-lock-add-keywords
 nil
 '(("red" 0 '(face italic changeme t))))


(defun preprocess (backend)
  (switch-to-buffer (current-buffer))
  (font-lock-add-keywords
   nil
   '(("red" 0 '(face italic changeme t))))
  (message-box "")
  (let* ((start (next-single-property-change (point) 'changeme))
(end (next-single-property-change start 'changeme)))
    (setf (buffer-substring start end) "yellow")))

(add-hook 'org-export-before-processing-hook 'preprocess nil t)
#+END_SRC

John

-----------------------------------
Professor John Kitchin
Doherty Hall A207F
Department of Chemical Engineering
Carnegie Mellon University
Pittsburgh, PA 15213
412-268-7803
@johnkitchin
http://kitchingroup.cheme.cmu.edu

[-- Attachment #2: Type: text/html, Size: 3175 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: loss of text properties in org-export--generate-copy-script
  2018-11-27 18:21 loss of text properties in org-export--generate-copy-script John Kitchin
@ 2018-11-27 22:49 ` Nicolas Goaziou
  2018-11-27 23:14   ` John Kitchin
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2018-11-27 22:49 UTC (permalink / raw)
  To: John Kitchin; +Cc: org-mode-email

Hello,

John Kitchin <jkitchin@andrew.cmu.edu> writes:

> In the function org-export--generate-copy-script, the buffer contents are
> copied over with buffer-substring-no-properties, so it appears that all
> text properties are lost in the temporary copy.
>
> I wondered why that is done?

I feel more comfortable when I can assume no text property will get in
the way.

I turned `buffer-substring-no-properties' into `buffer-string' in
"master".

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: loss of text properties in org-export--generate-copy-script
  2018-11-27 22:49 ` Nicolas Goaziou
@ 2018-11-27 23:14   ` John Kitchin
  0 siblings, 0 replies; 3+ messages in thread
From: John Kitchin @ 2018-11-27 23:14 UTC (permalink / raw)
  To: org-mode-email

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

ok. I thought there might be a reason. I guess something like a read-only
property could be a problem if anything tries to change those. Are there
other properties you know of that could be problematic? maybe before/after
change properties? I think there are inhibit-* variables to avoid issues
with those if they become a problem.

I am still baffled on why the unusual workaround with message-box makes it
work though.

John

-----------------------------------
Professor John Kitchin
Doherty Hall A207F
Department of Chemical Engineering
Carnegie Mellon University
Pittsburgh, PA 15213
412-268-7803
@johnkitchin
http://kitchingroup.cheme.cmu.edu



On Tue, Nov 27, 2018 at 5:49 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> John Kitchin <jkitchin@andrew.cmu.edu> writes:
>
> > In the function org-export--generate-copy-script, the buffer contents are
> > copied over with buffer-substring-no-properties, so it appears that all
> > text properties are lost in the temporary copy.
> >
> > I wondered why that is done?
>
> I feel more comfortable when I can assume no text property will get in
> the way.
>
> I turned `buffer-substring-no-properties' into `buffer-string' in
> "master".
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #2: Type: text/html, Size: 1973 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-27 23:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-27 18:21 loss of text properties in org-export--generate-copy-script John Kitchin
2018-11-27 22:49 ` Nicolas Goaziou
2018-11-27 23:14   ` John Kitchin

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).