From: "Christoffer Stjernlöf" <christoffer@loop54.com>
To: emacs-orgmode@gnu.org
Subject: Bug: Org-drill defines advice causing infinite recursion [9.3.6 (release_9.3.6-465-g4fde1c @ /home/christoffer/.emacs.d/straight/build/org/)]
Date: Thu, 9 Apr 2020 12:19:50 +0200 [thread overview]
Message-ID: <CAGkrc4QC+awFg5abDiL40fN47KsTFTLivRR9z9LEO6wjDExzJw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
https://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------
Org-drill defines the following advice:
(when (version< org-version "9.2")
(advice-add 'org-get-tags :around #'org-drill-get-tags-advice))
(defun org-drill-get-tags-advice (orig-fun &rest args)
;; the two arg call obsoletes get-local-tags
(if (= 2 (length args))
;; and we don't want any byte compile errors
(if (fboundp 'org-get-local-tags) (org-get-local-tags))
;; the non-arg version doesn't return inherited tags, but
;; get-tags-at does.
(org-get-tags-at)))
The function being called at the end, org-get-tags-at, has the unfortunate
definition:
(define-obsolete-function-alias 'org-get-tags-at 'org-get-tags "Org
9.2")
This results in the advice calling the function it advises, leading to
infinite recursion.
Is the version check around the advice addition accidentally inverted? Or
is there anything else I'm missing?
Emacs : GNU Emacs 26.3 (build 1, x86_64-redhat-linux-gnu, GTK+ Version
3.24.13)
of 2020-01-28
Package: Org mode version 9.3.6 (release_9.3.6-465-g4fde1c @
/home/christoffer/.emacs.d/straight/build/org/)
[-- Attachment #2: Type: text/html, Size: 1841 bytes --]
next reply other threads:[~2020-04-09 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 10:19 Christoffer Stjernlöf [this message]
2020-05-02 4:36 ` Bug: Org-drill defines advice causing infinite recursion [9.3.6 (release_9.3.6-465-g4fde1c @ /home/christoffer/.emacs.d/straight/build/org/)] Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGkrc4QC+awFg5abDiL40fN47KsTFTLivRR9z9LEO6wjDExzJw@mail.gmail.com \
--to=christoffer@loop54.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).