From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id R87kL+X7jl6cUAAA0tVLHw (envelope-from ) for ; Thu, 09 Apr 2020 10:41:41 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aOsyLub7jl5MMAAA1q6Kng (envelope-from ) for ; Thu, 09 Apr 2020 10:41:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 471976821F9 for ; Thu, 9 Apr 2020 10:41:40 +0000 (UTC) Received: from localhost ([::1]:47576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMUcr-0003Wo-Rm for larch@yhetil.org; Thu, 09 Apr 2020 06:41:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37675) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMUI1-0000f4-3B for emacs-orgmode@gnu.org; Thu, 09 Apr 2020 06:20:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMUHz-0002sx-OI for emacs-orgmode@gnu.org; Thu, 09 Apr 2020 06:20:04 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:46854) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jMUHz-0002sb-BV for emacs-orgmode@gnu.org; Thu, 09 Apr 2020 06:20:03 -0400 Received: by mail-ed1-x52e.google.com with SMTP id dk4so1197922edb.13 for ; Thu, 09 Apr 2020 03:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=loop54-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=PoNeG4Sz5N8ZZ07OCd0P5pytUhIXubu6XWsg3iS5hKw=; b=mq44KaEDhTmXnAK+gqiD+wpDtDmPrQe+YVocWAXrd9VwCVwLVQa1I6Wpx2c2psRWxY Qr6yuvtqacNnSlEvUD2BaHb+xG5p0lVNUd1Frz8rajm15M+v64watSC7zEn7ch18KOab 5usdy/PvJwQQ3D9HfhT5yte/pI7MsjCjKgfK2Mzfw6WmOsaZkTIWlLuLXKzr6zb419n4 gO4q+JYvNok1D+kqJyniKZDskS2KyfJeOOEDStNeqyRsn6HM3FBCEXTzWzPFOF5U4pUU 0m73qgLm4Gwyo4dKNzaSOm8mN5qdxJBPP1tZX6Sez+/kMsUmJyzK5zO3cwPcP5wuEpce OfMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=PoNeG4Sz5N8ZZ07OCd0P5pytUhIXubu6XWsg3iS5hKw=; b=pcWbZ9/5bJrL11+RF+dQidPHZWvPJZyBlPZxpzjQKLz3eJYFLCQVLJFEDC/XVsm+tB X2sgceEQNBopLFf+UqZqggU02kPhZOhwm/x+E7wjkf9iWa6HwN882WFVqyM81y6ebE5g SuOka/fsP9yueoKM7cE5Q/cU9BT1Pm1Jb+uk4GvTjXcYuXj3Iltp8A4x+VAhjG7n99ui x4PvtWpPykXEZIxyGor1lJOLIHd7KLCuAUGUDRNIe2jqU1O+lVdKugr3yztSSIY1HqSr U5T3PASM/teCWIGtbUvGEEfIc8bSyJTGFoBHdg6xyxqr7TSuHagd08TeF6Wu4RdErXVd 7uUg== X-Gm-Message-State: AGi0PuZ+bojGa6lmfRZfBqsxViH6h7mqZijYnyk9XruyaYMkPVsj+lcZ 2k/Wt4+7Ws2GhQWZe3jQpBTWwjcI652N0F+HWP0llQm1W/I= X-Google-Smtp-Source: APiQypIZ+vDzsNdIB7x+bFnJjhHZlws4MggT9//MbseWP7mxhnENzx1E0Dp4qng5wTGZQkE/Sev82fwif0XymeObm00= X-Received: by 2002:a17:906:2994:: with SMTP id x20mr10365698eje.156.1586427601050; Thu, 09 Apr 2020 03:20:01 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?Christoffer_Stjernl=C3=B6f?= Date: Thu, 9 Apr 2020 12:19:50 +0200 Message-ID: Subject: Bug: Org-drill defines advice causing infinite recursion [9.3.6 (release_9.3.6-465-g4fde1c @ /home/christoffer/.emacs.d/straight/build/org/)] To: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="0000000000009f71a605a2d8f5ca" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52e X-Mailman-Approved-At: Thu, 09 Apr 2020 06:38:16 -0400 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=default; t=1586428901; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=PoNeG4Sz5N8ZZ07OCd0P5pytUhIXubu6XWsg3iS5hKw=; b=fyVjSs89L8MWADJTR6Piee5Z2ZMt0EXKnBav484BMd64VN4BmgaoEmlR3Qenb9CN6FMdAn R6NnvFRdYrY7mPBn37027FWArKGpE6wkWhvPzrdh6hEChNWza3zDDmDJaR9hEkt4Oxeve/ rY26IrT7R+cg/DpmzDzpiBj01vOW5Tc= ARC-Seal: i=1; s=default; d=yhetil.org; t=1586428901; a=rsa-sha256; cv=none; b=F6Px6jYNCvgN48xmNrjurVECnXhp4bsOTATG+cwX4f5Y/bHFABFog5VvCvzKhUZm7MfV1/ UEnsNm0/bynGuVqbyAswRpxV1QEdnrX8DMYVWC7ce23vVNxZoADRme7zm3NS8fgWO++nQW /mEEMATmFI7UGO7xwz3nQ439xkpFpWE= ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=pass header.d=loop54-com.20150623.gappssmtp.com header.s=20150623 header.b=mq44KaED; dmarc=none; spf=pass (aspmx2.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scanner: scn0 X-Spam-Score: -0.21 Authentication-Results: aspmx2.migadu.com; dkim=pass header.d=loop54-com.20150623.gappssmtp.com header.s=20150623 header.b=mq44KaED; dmarc=none; spf=pass (aspmx2.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [-0.21 / 13.00]; GENERIC_REPUTATION(0.00)[-0.5810558039831]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.31), country: US(-0.01), ip: 209.51.188.17(-0.58)]; TO_DN_NONE(0.00)[]; ARC_SIGNED(0.00)[i=1]; URI_COUNT_ODD(1.00)[3]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; DKIM_TRACE(0.00)[loop54-com.20150623.gappssmtp.com:+]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[christoffer@loop54.com,emacs-orgmode-bounces@gnu.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; R_DKIM_ALLOW(-0.20)[loop54-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[emacs-orgmode@gnu.org]; DMARC_NA(0.00)[loop54.com]; HAS_LIST_UNSUB(-0.01)[]; RCPT_COUNT_ONE(0.00)[1]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: fdbBJiY7rmHX --0000000000009f71a605a2d8f5ca Content-Type: text/plain; charset="UTF-8" Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list. ------------------------------------------------------------------------ Org-drill defines the following advice: (when (version< org-version "9.2") (advice-add 'org-get-tags :around #'org-drill-get-tags-advice)) (defun org-drill-get-tags-advice (orig-fun &rest args) ;; the two arg call obsoletes get-local-tags (if (= 2 (length args)) ;; and we don't want any byte compile errors (if (fboundp 'org-get-local-tags) (org-get-local-tags)) ;; the non-arg version doesn't return inherited tags, but ;; get-tags-at does. (org-get-tags-at))) The function being called at the end, org-get-tags-at, has the unfortunate definition: (define-obsolete-function-alias 'org-get-tags-at 'org-get-tags "Org 9.2") This results in the advice calling the function it advises, leading to infinite recursion. Is the version check around the advice addition accidentally inverted? Or is there anything else I'm missing? Emacs : GNU Emacs 26.3 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.24.13) of 2020-01-28 Package: Org mode version 9.3.6 (release_9.3.6-465-g4fde1c @ /home/christoffer/.emacs.d/straight/build/org/) --0000000000009f71a605a2d8f5ca Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Remember to cover the basics, that is, what you expected t= o happen and
what in fact did happen.=C2=A0 You don't know how to ma= ke a good report?=C2=A0 See

=C2=A0 =C2=A0 =C2=A0https://orgmode.org/manual/Feedba= ck.html#Feedback

Your bug report will be posted to the Org maili= ng list.
---------------------------------------------------------------= ---------

Org-drill defines the following advice:

=C2=A0=C2=A0=C2=A0 (when (version< org-version &q= uot;9.2")
=C2=A0=C2=A0=C2=A0=C2=A0 (advice-add 'org-get-tags := around #'org-drill-get-tags-advice))

=C2=A0=C2=A0=C2=A0 (defun o= rg-drill-get-tags-advice (orig-fun &rest args)
=C2=A0=C2=A0=C2=A0=C2= =A0 ;; the two arg call obsoletes get-local-tags
=C2=A0 =C2=A0=C2=A0=C2= =A0 (if (=3D 2 (length args))
=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 ;;= and we don't want any byte compile errors
=C2=A0 =C2=A0=C2=A0=C2=A0= =C2=A0 =C2=A0 (if (fboundp 'org-get-local-tags) (org-get-local-tags))<= br>=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 ;; the non-arg version doesn't retu= rn inherited tags, but
=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 ;; get-tags-at d= oes.
=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 (org-get-tags-at)))
=
The function being called at the end, org-get-tags-at, has t= he unfortunate definition:

=C2=A0=C2=A0=C2=A0 (define-obsolete-funct= ion-alias 'org-get-tags-at 'org-get-tags "Org 9.2")

This results in the advice calling the function it = advises, leading to infinite recursion.

Is the version ch= eck around the advice addition accidentally inverted? Or is there anything = else I'm missing?

Emacs =C2=A0: GNU Emacs 26.3 (build 1, x= 86_64-redhat-linux-gnu, GTK+ Version 3.24.13)
=C2=A0of 2020-01-28
Pac= kage: Org mode version 9.3.6 (release_9.3.6-465-g4fde1c @ /home/christoffer= /.emacs.d/straight/build/org/)
--0000000000009f71a605a2d8f5ca--