From: "Zane D. Purvis" <zane.purvis@gmail.com>
To: "Zane D. Purvis" <zane.purvis@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-html.el: add exporting of priority
Date: Fri, 9 Jan 2015 09:30:56 -0500 [thread overview]
Message-ID: <CAGJcBOc0RfcpfA71_sU5wP5PX=wpU-GBqBjdGhO3ZpQJHrQSzQ@mail.gmail.com> (raw)
In-Reply-To: <87fvbkpdpa.fsf@nicolasgoaziou.fr>
Sure thing. Expect a new patch momentarily. Thanks.
On Fri, Jan 9, 2015 at 3:20 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> "Zane D. Purvis" <zane.purvis@gmail.com> writes:
>
> Thanks for the patch.
>
> The summary line should be capitalized, i.e.,
>
> ox-html: Add exporting of priority
>
>> * list/ox-html.el (org-html--priority): new function
>
> Capitalize, too.
>
>> (org-html-format-headline-default-function): call `org-html--priority'
>
> Ditto.
>
>> (org-html-style-default): add `.priority'
>
> Ditto.
>
>> +(defun org-html--priority (priority info)
>> + "Format a priority into HTML.
>> +PRIORITY is the character code of the priority or nil.
>> +INFO is a plist containing export options."
>> + (when priority
>> + (format "<span class=\"priority\">[%s]</span>"
>> + (byte-to-string priority))))
>
> Shorter:
>
> (and priority (format "<span class=\"priority\">[%c]</span>" priority))
>
> Could you fix these issues before I apply your patch?
>
>
> Regards,
>
> --
> Nicolas Goaziou
next prev parent reply other threads:[~2015-01-09 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 3:23 [PATCH] ox-html.el: add exporting of priority Zane D. Purvis
2015-01-09 8:20 ` Nicolas Goaziou
2015-01-09 14:30 ` Zane D. Purvis [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-09 15:43 [PATCH] ox-html.el: Add " Zane D. Purvis
2015-01-10 9:29 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGJcBOc0RfcpfA71_sU5wP5PX=wpU-GBqBjdGhO3ZpQJHrQSzQ@mail.gmail.com' \
--to=zane.purvis@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).