From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zane D. Purvis" <zane.purvis@gmail.com>
Subject: Re: [PATCH] ox-html.el: add exporting of priority
Date: Fri, 9 Jan 2015 09:30:56 -0500
Message-ID: <CAGJcBOc0RfcpfA71_sU5wP5PX=wpU-GBqBjdGhO3ZpQJHrQSzQ@mail.gmail.com>
References: <CAGJcBOcdX-OXg68uCK6DpRqh9abMZ=Rd2hn1B=-gqak3z5GoNw@mail.gmail.com>
	<87fvbkpdpa.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53676)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zane.purvis@gmail.com>) id 1Y9aau-0005CQ-9C
	for emacs-orgmode@gnu.org; Fri, 09 Jan 2015 09:31:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zane.purvis@gmail.com>) id 1Y9aas-0000Uv-8L
	for emacs-orgmode@gnu.org; Fri, 09 Jan 2015 09:31:20 -0500
Received: from mail-qg0-x235.google.com ([2607:f8b0:400d:c04::235]:43938)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zane.purvis@gmail.com>) id 1Y9aas-0000Uq-3Z
	for emacs-orgmode@gnu.org; Fri, 09 Jan 2015 09:31:18 -0500
Received: by mail-qg0-f53.google.com with SMTP id l89so8875256qgf.12
	for <emacs-orgmode@gnu.org>; Fri, 09 Jan 2015 06:31:17 -0800 (PST)
In-Reply-To: <87fvbkpdpa.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: "Zane D. Purvis" <zane.purvis@gmail.com>, emacs-orgmode@gnu.org

Sure thing. Expect a new patch momentarily. Thanks.

On Fri, Jan 9, 2015 at 3:20 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> "Zane D. Purvis" <zane.purvis@gmail.com> writes:
>
> Thanks for the patch.
>
> The summary line should be capitalized, i.e.,
>
>   ox-html: Add exporting of priority
>
>> * list/ox-html.el (org-html--priority): new function
>
> Capitalize, too.
>
>> (org-html-format-headline-default-function): call `org-html--priority'
>
> Ditto.
>
>> (org-html-style-default): add `.priority'
>
> Ditto.
>
>> +(defun org-html--priority (priority info)
>> +  "Format a priority into HTML.
>> +PRIORITY is the character code of the priority or nil.
>> +INFO is a plist containing export options."
>> +  (when priority
>> +    (format "<span class=\"priority\">[%s]</span>"
>> +        (byte-to-string priority))))
>
> Shorter:
>
>   (and priority (format "<span class=\"priority\">[%c]</span>" priority))
>
> Could you fix these issues before I apply your patch?
>
>
> Regards,
>
> --
> Nicolas Goaziou