emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* org-src-fontify-natively stops working in 8.3
@ 2015-08-05  2:38 Kaushal
  2015-08-05  3:04 ` Kaushal
  2015-08-05  3:49 ` Kyle Meyer
  0 siblings, 2 replies; 6+ messages in thread
From: Kaushal @ 2015-08-05  2:38 UTC (permalink / raw)
  To: emacs-org list

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Hi,

The source code block fontification stops working in all my org files in
version 8.3.

When I evaluated org-src.el from version 8.2.10, the fontification started
working again.

Is anyone able to replicate this issue?

I have org-src-fontify-natively set to t. Do I need to set anything else in
8.3?

Thanks.



--
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1688 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: org-src-fontify-natively stops working in 8.3
  2015-08-05  2:38 org-src-fontify-natively stops working in 8.3 Kaushal
@ 2015-08-05  3:04 ` Kaushal
  2015-08-05  3:49 ` Kyle Meyer
  1 sibling, 0 replies; 6+ messages in thread
From: Kaushal @ 2015-08-05  3:04 UTC (permalink / raw)
  To: emacs-org list

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

Using (font-lock-fontify-buffer) as in version 8.2.10 instead of
(font-lock-ensure) in org-src-font-lock-fontify-block fixes this.

But the documentation in font-lock.el suggests using font-lock-ensure
instead of font-lock-fontify-buffer.


--
Kaushal Modi

On Tue, Aug 4, 2015 at 10:38 PM, Kaushal <kaushal.modi@gmail.com> wrote:

> Hi,
>
> The source code block fontification stops working in all my org files in
> version 8.3.
>
> When I evaluated org-src.el from version 8.2.10, the fontification started
> working again.
>
> Is anyone able to replicate this issue?
>
> I have org-src-fontify-natively set to t. Do I need to set anything else
> in 8.3?
>
> Thanks.
>
>
>
> --
> Kaushal Modi
>

[-- Attachment #2: Type: text/html, Size: 2698 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: org-src-fontify-natively stops working in 8.3
  2015-08-05  2:38 org-src-fontify-natively stops working in 8.3 Kaushal
  2015-08-05  3:04 ` Kaushal
@ 2015-08-05  3:49 ` Kyle Meyer
  2015-08-05  7:09   ` Bastien Guerry
  2015-08-05 11:34   ` Bastien Guerry
  1 sibling, 2 replies; 6+ messages in thread
From: Kyle Meyer @ 2015-08-05  3:49 UTC (permalink / raw)
  To: Kaushal; +Cc: emacs-org list

Kaushal <kaushal.modi@gmail.com> wrote:
> Hi,
>
> The source code block fontification stops working in all my org files in
> version 8.3.

Sorry, this was broken by my backport (d81e6b5) and the following merge
to master.  I should have caught this because 99f9999 ("org-src.el
(org-src-font-lock-fontify-block): Do not use `font-lock-ensure'",
2014-07-27) was already in response to an earlier attempt to use
font-lock-ensure here (although I've been unable to find the original ML
post).

I'll restore the use of font-lock-fontify-buffer and leave a comment to
make sure it isn't reverted again.

--
Kyle

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: org-src-fontify-natively stops working in 8.3
  2015-08-05  3:49 ` Kyle Meyer
@ 2015-08-05  7:09   ` Bastien Guerry
  2015-08-05 11:34   ` Bastien Guerry
  1 sibling, 0 replies; 6+ messages in thread
From: Bastien Guerry @ 2015-08-05  7:09 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-org list, Kaushal

Hi Kyle,

Kyle Meyer <kyle@kyleam.com> writes:

> I'll restore the use of font-lock-fontify-buffer and leave a comment to
> make sure it isn't reverted again.

Ouch.  I've been bitten by this before, if my memory is correct.

Let's fix those regressions within the next hour and release 8.3.1
to propagate them.

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: org-src-fontify-natively stops working in 8.3
  2015-08-05  3:49 ` Kyle Meyer
  2015-08-05  7:09   ` Bastien Guerry
@ 2015-08-05 11:34   ` Bastien Guerry
  2015-08-05 11:58     ` Kaushal
  1 sibling, 1 reply; 6+ messages in thread
From: Bastien Guerry @ 2015-08-05 11:34 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-org list, Kaushal

I've released 8.3.1 with this fix.

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: org-src-fontify-natively stops working in 8.3
  2015-08-05 11:34   ` Bastien Guerry
@ 2015-08-05 11:58     ` Kaushal
  0 siblings, 0 replies; 6+ messages in thread
From: Kaushal @ 2015-08-05 11:58 UTC (permalink / raw)
  To: Bastien Guerry; +Cc: Kyle Meyer, emacs-org list

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

Thanks guys!
On Aug 5, 2015 7:34 AM, "Bastien Guerry" <bzg@gnu.org> wrote:

> I've released 8.3.1 with this fix.
>
> Thanks,
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 405 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-08-05 11:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-05  2:38 org-src-fontify-natively stops working in 8.3 Kaushal
2015-08-05  3:04 ` Kaushal
2015-08-05  3:49 ` Kyle Meyer
2015-08-05  7:09   ` Bastien Guerry
2015-08-05 11:34   ` Bastien Guerry
2015-08-05 11:58     ` Kaushal

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).