* Fix org-clock compilation on emacs 24.x
@ 2016-07-25 15:20 Kaushal Modi
2016-07-25 15:21 ` Kaushal Modi
0 siblings, 1 reply; 2+ messages in thread
From: Kaushal Modi @ 2016-07-25 15:20 UTC (permalink / raw)
To: emacs-org list
[-- Attachment #1: Type: text/plain, Size: 2210 bytes --]
Hi all,
I have a script that builds org individually for different emacs version.
I noticed just today that the build is failing for emacs 24.5.
=====
make compile-dirall
==================== dirall ====================
make[2]: Entering directory `/home/kmodi/.emacs.d/elisp/org-mode/lisp'
Checking /home/kmodi/.emacs.d/elisp/org-mode/lisp...
Compiling /home/kmodi/.emacs.d/elisp/org-mode/lisp/org-install.el...
Compiling /home/kmodi/.emacs.d/elisp/org-mode/lisp/org-loaddefs.el...
Compiling /home/kmodi/.emacs.d/elisp/org-mode/lisp/org-timer.el...
In toplevel form:
org-timer.el:38:1:Error: Symbol's function definition is void: incf
Compiling /home/kmodi/.emacs.d/elisp/org-mode/lisp/org-version.el...
Done (Total of 0 files compiled, 1 failed, 118 skipped)
make[2]: Leaving directory `/home/kmodi/.emacs.d/elisp/org-mode/lisp'
if [ ! -d /home/kmodi/usr_local/apps/6/emacs/24/share/emacs/site-lisp/org ]
; then \
install -m 755 -d
/home/kmodi/usr_local/apps/6/emacs/24/share/emacs/site-lisp/org ; \
fi ;
install -m 644 -p <snip>
/home/kmodi/usr_local/apps/6/emacs/24/share/emacs/site-lisp/org
install: cannot stat `org-timer.elc': No such file or directory
make[1]: *** [install] Error 1
make[1]: Leaving directory `/home/kmodi/.emacs.d/elisp/org-mode/lisp'
make: *** [install-lisp] Error 2
=====
Below minor patch fixes that issue:
From 0b9c1b4a6cac2eec6f1ea5ff3a123fa7d8e3fc25 Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi@gmail.com>
Date: Mon, 25 Jul 2016 11:18:51 -0400
Subject: [PATCH] Use cl-incf instead of incf
* org-clock.el (org-clock--oldest-date): Use the correct macro from
`cl-lib' library.
---
lisp/org-clock.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 03e6a2c..fcc20e0 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -465,7 +465,7 @@ to add an effort property.")
(let* ((dichotomy
(lambda (min max pred)
(if (funcall pred min) min
- (incf min)
+ (cl-incf min)
(while (> (- max min) 1)
(let ((mean (+ (ash min -1) (ash max -1) (logand min max 1))))
(if (funcall pred mean) (setq max mean) (setq min mean)))))
--
2.9.2
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 3537 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Fix org-clock compilation on emacs 24.x
2016-07-25 15:20 Fix org-clock compilation on emacs 24.x Kaushal Modi
@ 2016-07-25 15:21 ` Kaushal Modi
0 siblings, 0 replies; 2+ messages in thread
From: Kaushal Modi @ 2016-07-25 15:21 UTC (permalink / raw)
To: emacs-org list
[-- Attachment #1: Type: text/plain, Size: 66 bytes --]
Please ignore.
It got fixed 10 minutes back :)
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 216 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-25 15:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-25 15:20 Fix org-clock compilation on emacs 24.x Kaushal Modi
2016-07-25 15:21 ` Kaushal Modi
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).