emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Michael Hendricks <michael@ndrix.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-compat: Allow imenu items without hierarchy
Date: Tue, 17 Apr 2018 18:52:36 +0000	[thread overview]
Message-ID: <CAFHuXuajUG+7iMUELP6nscW6h4o-HGCahEJwGtw5PM=P9LUEcQ@mail.gmail.com> (raw)
In-Reply-To: <8736zwlpy0.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

Hi Nicolas,

On Sun, Apr 15, 2018 at 4:33 AM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Thank you. However, you don't need to patch Org to have this. Just set
> `imenu-create-index-function' to your liking.
>

Thanks for the suggestion.   That's how I was doing it before this patch
and it works. I'll keep doing it that way if this patch isn't useful to
anyone.

Since org-imenu-depth and org-imenu-get-tree could also be handled by users
setting imenu-create-index-function to their liking, I assumed that some
pieces of imenu integration were open to patches.  Other modes with
hierarchical structure, like C++ and Java, create imenu items without
hierarchy rather than recreating the class hierarchy in the menu.  That
made me think that users other than myself might prefer a flat imenu in Org
mode too.  For that reason, I'd still like to have this patch included.

I have a couple other patches for imenu integration which clean it up and
make it more consistent with behavior elsewhere.  What's the project's view
on patches like these?  I don't want to waste anyone's time if they're
discouraged by policy.

Thanks for your time.

[-- Attachment #2: Type: text/html, Size: 1679 bytes --]

next prev parent reply	other threads:[~2018-04-17 18:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 15:49 [PATCH] org-compat: Allow imenu items without hierarchy Michael Hendricks
2018-04-15 10:33 ` Nicolas Goaziou
2018-04-17 18:52   ` Michael Hendricks [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-04-10 21:46 Michael Hendricks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFHuXuajUG+7iMUELP6nscW6h4o-HGCahEJwGtw5PM=P9LUEcQ@mail.gmail.com' \
    --to=michael@ndrix.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).