From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Hendricks Subject: Re: [PATCH] org-compat: Allow imenu items without hierarchy Date: Tue, 17 Apr 2018 18:52:36 +0000 Message-ID: References: <20180412154934.58182-1-michael@ndrix.org> <8736zwlpy0.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000002971bf056a0fd820" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8Vio-0004Gr-Cl for emacs-orgmode@gnu.org; Tue, 17 Apr 2018 14:52:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8Vij-0000OQ-R5 for emacs-orgmode@gnu.org; Tue, 17 Apr 2018 14:52:53 -0400 Received: from mail8.static.mailgun.info ([104.130.122.8]:15161) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8Vij-0000N3-Kh for emacs-orgmode@gnu.org; Tue, 17 Apr 2018 14:52:49 -0400 Received: by mail-ot0-f169.google.com with SMTP id o9-v6so22554283otj.5 for ; Tue, 17 Apr 2018 11:52:47 -0700 (PDT) In-Reply-To: <8736zwlpy0.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org --0000000000002971bf056a0fd820 Content-Type: text/plain; charset="UTF-8" Hi Nicolas, On Sun, Apr 15, 2018 at 4:33 AM Nicolas Goaziou wrote: > Thank you. However, you don't need to patch Org to have this. Just set > `imenu-create-index-function' to your liking. > Thanks for the suggestion. That's how I was doing it before this patch and it works. I'll keep doing it that way if this patch isn't useful to anyone. Since org-imenu-depth and org-imenu-get-tree could also be handled by users setting imenu-create-index-function to their liking, I assumed that some pieces of imenu integration were open to patches. Other modes with hierarchical structure, like C++ and Java, create imenu items without hierarchy rather than recreating the class hierarchy in the menu. That made me think that users other than myself might prefer a flat imenu in Org mode too. For that reason, I'd still like to have this patch included. I have a couple other patches for imenu integration which clean it up and make it more consistent with behavior elsewhere. What's the project's view on patches like these? I don't want to waste anyone's time if they're discouraged by policy. Thanks for your time. --0000000000002971bf056a0fd820 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Nicolas,

On Sun, Apr 15, 2018= at 4:33 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
Thank you. However, you don't need to patch Org to = have this. Just set
`imenu-create-index-function' to your liking.

=
Thanks f= or the suggestion.=C2=A0 =C2=A0That's how I was doing it before this pa= tch and it works. I'll keep doing it that way if this patch isn't u= seful to anyone.

Since org-imenu-depth and org-ime= nu-get-tree could also be handled by users setting imenu-create-index-funct= ion to their liking, I assumed that some pieces of imenu integration were o= pen to patches.=C2=A0 Other modes with hierarchical structure, like C++ and= Java, create imenu items without hierarchy rather than recreating the clas= s hierarchy in the menu.=C2=A0 That made me think that users other than mys= elf might prefer a flat imenu in Org mode too.=C2=A0 For that reason, I'= ;d still like to have this patch included.

I have = a couple other patches for imenu integration which clean it up and make it = more consistent with behavior elsewhere.=C2=A0 What's the project's= view on patches like these?=C2=A0 I don't want to waste anyone's t= ime if they're discouraged by policy.

Thanks f= or your time.

--0000000000002971bf056a0fd820--