emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Hiroshi Saito <monodie@gmail.com>
To: Michael Brand <michael.ch.brand@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Substitute a guid XML element in org-feed
Date: Mon, 19 Oct 2015 08:49:36 +0900	[thread overview]
Message-ID: <CAFEtL0fj3MZz5eYfcjPXz2UXKWRWgSFNyJXuKtKko9g5ZzTxAQ@mail.gmail.com> (raw)
In-Reply-To: <CALn3zogyW7_RTG=uOeN=Y-xGyyjpUYeh6EBpdPaEdPentE3yGw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

Hi Michael,

So sorry for that error. I did not notice.

I wrote an additional patch to fix it. The patch makes sure that the xml
library is loaded before calling `xml-substitute-special` as with
`org-feed-parse-rss-entry` and `org-feed-parse-atom-feed`.

--
Sincerely,
Hiroshi Saito

2015-10-19 2:54 GMT+09:00 Michael Brand <michael.ch.brand@gmail.com>:
> Hi Hiroshi
>
> On Sun, Sep 27, 2015 at 8:24 PM, Hiroshi Saito <monodie@gmail.com> wrote:
>> A guid XML element is not substituted in org-feed. Here is a patch
>> to fix it.
>
> It causes the error
>
>     if: Symbol's function definition is void: xml-substitute-special
>
> because xml is not loaded yet.
>
> Michael

[-- Attachment #2: 0001-org-feed.el-Load-the-xml-library-before-substituting.patch --]
[-- Type: application/octet-stream, Size: 891 bytes --]

From ca262ffe4376897523e641c0c51a6d26258883db Mon Sep 17 00:00:00 2001
From: Hiroshi Saito <saidie@saidie.info>
Date: Mon, 19 Oct 2015 08:07:01 +0900
Subject: [PATCH] org-feed.el: Load the xml library before substituting a guid
 XML element

* lisp/org-feed.el (org-feed-parse-rss-feed): Load the xml library
before calling `xml-substitute-special`.

TINYCHANGE
---
 lisp/org-feed.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-feed.el b/lisp/org-feed.el
index c881c18..fbd6108 100644
--- a/lisp/org-feed.el
+++ b/lisp/org-feed.el
@@ -604,6 +604,7 @@ Assumes headers are indeed present!"
   "Parse BUFFER for RSS feed entries.
 Returns a list of entries, with each entry a property list,
 containing the properties `:guid' and `:item-full-text'."
+  (require 'xml)
   (let ((case-fold-search t)
 	entries beg end item guid entry)
     (with-current-buffer buffer
-- 
2.6.0

next prev parent reply	other threads:[~2015-10-18 23:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-27 18:24 [PATCH] Substitute a guid XML element in org-feed Hiroshi Saito
2015-09-30 11:57 ` Nicolas Goaziou
2015-10-18 17:54 ` Michael Brand
2015-10-18 23:49   ` Hiroshi Saito [this message]
2015-11-14  4:15     ` Hiroshi Saito
2015-11-14  8:32       ` Nicolas Goaziou

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:c881c18 dfblob:fbd6108
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEtL0fj3MZz5eYfcjPXz2UXKWRWgSFNyJXuKtKko9g5ZzTxAQ@mail.gmail.com \
    --to=monodie@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=michael.ch.brand@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).