From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hiroshi Saito Subject: Re: [PATCH] Substitute a guid XML element in org-feed Date: Mon, 19 Oct 2015 08:49:36 +0900 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e01228934ce93ce052269b0a3 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnxiU-0008T9-Kx for emacs-orgmode@gnu.org; Sun, 18 Oct 2015 19:50:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZnxiT-0006ll-U2 for emacs-orgmode@gnu.org; Sun, 18 Oct 2015 19:50:18 -0400 Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:35162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnxiT-0006lg-Lh for emacs-orgmode@gnu.org; Sun, 18 Oct 2015 19:50:17 -0400 Received: by lbbes7 with SMTP id es7so40487761lbb.2 for ; Sun, 18 Oct 2015 16:50:16 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Michael Brand Cc: Org Mode --089e01228934ce93ce052269b0a3 Content-Type: text/plain; charset=UTF-8 Hi Michael, So sorry for that error. I did not notice. I wrote an additional patch to fix it. The patch makes sure that the xml library is loaded before calling `xml-substitute-special` as with `org-feed-parse-rss-entry` and `org-feed-parse-atom-feed`. -- Sincerely, Hiroshi Saito 2015-10-19 2:54 GMT+09:00 Michael Brand : > Hi Hiroshi > > On Sun, Sep 27, 2015 at 8:24 PM, Hiroshi Saito wrote: >> A guid XML element is not substituted in org-feed. Here is a patch >> to fix it. > > It causes the error > > if: Symbol's function definition is void: xml-substitute-special > > because xml is not loaded yet. > > Michael --089e01228934ce93ce052269b0a3 Content-Type: application/octet-stream; name="0001-org-feed.el-Load-the-xml-library-before-substituting.patch" Content-Disposition: attachment; filename="0001-org-feed.el-Load-the-xml-library-before-substituting.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ifx5zwlf0 RnJvbSBjYTI2MmZmZTQzNzY4OTc1MjNlNjQxYzBjNTFhNmQyNjI1ODg4M2RiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIaXJvc2hpIFNhaXRvIDxzYWlkaWVAc2FpZGllLmluZm8+CkRh dGU6IE1vbiwgMTkgT2N0IDIwMTUgMDg6MDc6MDEgKzA5MDAKU3ViamVjdDogW1BBVENIXSBvcmct ZmVlZC5lbDogTG9hZCB0aGUgeG1sIGxpYnJhcnkgYmVmb3JlIHN1YnN0aXR1dGluZyBhIGd1aWQK IFhNTCBlbGVtZW50CgoqIGxpc3Avb3JnLWZlZWQuZWwgKG9yZy1mZWVkLXBhcnNlLXJzcy1mZWVk KTogTG9hZCB0aGUgeG1sIGxpYnJhcnkKYmVmb3JlIGNhbGxpbmcgYHhtbC1zdWJzdGl0dXRlLXNw ZWNpYWxgLgoKVElOWUNIQU5HRQotLS0KIGxpc3Avb3JnLWZlZWQuZWwgfCAxICsKIDEgZmlsZSBj aGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3JnLWZlZWQuZWwgYi9s aXNwL29yZy1mZWVkLmVsCmluZGV4IGM4ODFjMTguLmZiZDYxMDggMTAwNjQ0Ci0tLSBhL2xpc3Av b3JnLWZlZWQuZWwKKysrIGIvbGlzcC9vcmctZmVlZC5lbApAQCAtNjA0LDYgKzYwNCw3IEBAIEFz c3VtZXMgaGVhZGVycyBhcmUgaW5kZWVkIHByZXNlbnQhIgogICAiUGFyc2UgQlVGRkVSIGZvciBS U1MgZmVlZCBlbnRyaWVzLgogUmV0dXJucyBhIGxpc3Qgb2YgZW50cmllcywgd2l0aCBlYWNoIGVu dHJ5IGEgcHJvcGVydHkgbGlzdCwKIGNvbnRhaW5pbmcgdGhlIHByb3BlcnRpZXMgYDpndWlkJyBh bmQgYDppdGVtLWZ1bGwtdGV4dCcuIgorICAocmVxdWlyZSAneG1sKQogICAobGV0ICgoY2FzZS1m b2xkLXNlYXJjaCB0KQogCWVudHJpZXMgYmVnIGVuZCBpdGVtIGd1aWQgZW50cnkpCiAgICAgKHdp dGgtY3VycmVudC1idWZmZXIgYnVmZmVyCi0tIAoyLjYuMAoK --089e01228934ce93ce052269b0a3--