emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG] org-mode 9.5.4 with evil-leader leads to endless loop in table [9.5.4 (9.5.4-g6013cb1 @ /Users/cgrabenstein/.emacs.d/straight/build/org/)]
@ 2022-07-27 18:45 Christoph Grabenstein
  2022-07-28 14:56 ` Ihor Radchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Christoph Grabenstein @ 2022-07-27 18:45 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 4666 bytes --]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

org-table-insert-row hangs if evil-leader is installed.

Steps to reproduce:

1. Install org-mode 9.5.4, evil and evil-leader, and enable evil-mode
and global-evil-leader-mode.
2. Open or create an org file that has a table like that:
```
| header | another header |
```
3. Place your cursor in the header and hit enter (in evil insert mode).
4. Emacs hangs in an endless loop, you will have to interrupt with C-g.


Additional notes:
- The problem does not occur with org-mode 9.5.2.
- I'm not sure if this is an error on org's side or on evil's side. Please
let me know if I should open a ticket for evil.
- For more details see my question at the emacs stackexchange:
https://emacs.stackexchange.com/questions/72769/org-mode-tables-slowed-down-by-evil-mode

Best regards
Christoph

Emacs  : GNU Emacs 28.1 (build 1, x86_64-apple-darwin20.6.0, Carbon Version
164 AppKit 2022.6)
 of 2022-05-03
Package: Org mode version 9.5.4 (9.5.4-g6013cb1 @
/Users/cgrabenstein/.emacs.d/straight/build/org/)

current state:
==============
(setq
 org-link-elisp-confirm-function 'yes-or-no-p
 org-bibtex-headline-format-function #[257 "\300 \236A\207" [:title] 3
"\n\n(fn ENTRY)"]
 org-export-before-parsing-hook '(org-attach-expand-links)
 org-cycle-tab-first-hook '(org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees
org-cycle-show-empty-lines
 org-cycle-optimize-window-after-visibility-change)
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
  [add-hook change-major-mode-hook org-fold-show-all append local] 5]
#[0 "\300\301\302\303\304$\207"
  [add-hook change-major-mode-hook org-babel-show-result-all append local]
5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-confirm-shell-link-function 'yes-or-no-p
 outline-isearch-open-invisible-function 'outline-isearch-open-invisible
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
org-src-mode-configure-edit-buffer)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-speed-command-hook '(org-speed-command-activate
org-babel-speed-command-activate)
 org-fold-core-isearch-open-function 'org-fold-core--isearch-reveal
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
 org-link-shell-confirm-function 'yes-or-no-p
 org-babel-pre-tangle-hook '(save-buffer)
 org-agenda-loop-over-headlines-in-active-region nil
 org-occur-hook '(org-first-headline-recenter)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-link-parameters '(("attachment" :follow org-attach-follow :complete
org-attach-complete-link)
      ("id" :follow org-id-open)
      ("eww" :follow org-eww-open :store org-eww-store-link)
      ("rmail" :follow org-rmail-open :store org-rmail-store-link)
      ("mhe" :follow org-mhe-open :store org-mhe-store-link)
      ("irc" :follow org-irc-visit :store org-irc-store-link :export
org-irc-export)
      ("info" :follow org-info-open :export org-info-export :store
org-info-store-link)
      ("gnus" :follow org-gnus-open :store org-gnus-store-link)
      ("docview" :follow org-docview-open :export org-docview-export :store
org-docview-store-link)
      ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
      ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
org-bbdb-complete-link :store org-bbdb-store-link)
      ("w3m" :store org-w3m-store-link)
      ("doi" :follow org-link-doi-open :export org-link-doi-export)
("file+sys")
      ("file+emacs") ("shell" :follow org-link--open-shell)
      ("news" :follow
#[514 "\301\300\302 Q \"\207" ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"])
      ("mailto" :follow
#[514 "\301\300\302 Q \"\207" ["mailto" browse-url ":"] 6
 "\n\n(fn URL ARG)"]
)
      ("https" :follow
#[514 "\301\300\302 Q \"\207" ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("http" :follow
#[514 "\301\300\302 Q \"\207" ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"])
      ("ftp" :follow
#[514 "\301\300\302 Q \"\207" ["ftp" browse-url ":"] 6 "\n\n(fn URL ARG)"])
      ("help" :follow org-link--open-help :store org-link--store-help)
      ("file" :complete org-link-complete-file)
      ("elisp" :follow org-link--open-elisp))
 org-metaup-hook '(org-babel-load-in-session-maybe)
 )

[-- Attachment #2: Type: text/html, Size: 6088 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BUG] org-mode 9.5.4 with evil-leader leads to endless loop in table [9.5.4 (9.5.4-g6013cb1 @ /Users/cgrabenstein/.emacs.d/straight/build/org/)]
  2022-07-27 18:45 [BUG] org-mode 9.5.4 with evil-leader leads to endless loop in table [9.5.4 (9.5.4-g6013cb1 @ /Users/cgrabenstein/.emacs.d/straight/build/org/)] Christoph Grabenstein
@ 2022-07-28 14:56 ` Ihor Radchenko
  2022-07-30  8:51   ` Christoph Grabenstein
  0 siblings, 1 reply; 5+ messages in thread
From: Ihor Radchenko @ 2022-07-28 14:56 UTC (permalink / raw)
  To: Christoph Grabenstein; +Cc: emacs-orgmode

Christoph Grabenstein <christoph.grabenstein@gmail.com> writes:

> org-table-insert-row hangs if evil-leader is installed.
>
> Steps to reproduce:
>
> 1. Install org-mode 9.5.4, evil and evil-leader, and enable evil-mode
> and global-evil-leader-mode.
> 2. Open or create an org file that has a table like that:
> ```
> | header | another header |
> ```
> 3. Place your cursor in the header and hit enter (in evil insert mode).
> 4. Emacs hangs in an endless loop, you will have to interrupt with C-g.

Thanks for reporting!

> - I'm not sure if this is an error on org's side or on evil's side. Please
> let me know if I should open a ticket for evil.
> - For more details see my question at the emacs stackexchange:
> https://emacs.stackexchange.com/questions/72769/org-mode-tables-slowed-down-by-evil-mode

Thanks for the link. Extra information from the link allowed me to
narrow down the cause. The cause is in evil-mode.

evil-local-mode is run in temporary buffer, which is OK. What is not OK
is that evil-local-mode is altering the match data. It must not happen.
Please report this issue to evil devs.

Best,
Ihor


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BUG] org-mode 9.5.4 with evil-leader leads to endless loop in table [9.5.4 (9.5.4-g6013cb1 @ /Users/cgrabenstein/.emacs.d/straight/build/org/)]
  2022-07-28 14:56 ` Ihor Radchenko
@ 2022-07-30  8:51   ` Christoph Grabenstein
  2022-07-30  8:56     ` Ihor Radchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Christoph Grabenstein @ 2022-07-30  8:51 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1770 bytes --]

Hello Ihor,

thanks for your reply, and thanks for further debugging the issue. I
created an issue for evil here:
https://github.com/emacs-evil/evil/issues/1642. Feel free to add some more
details to my report.

One thing that's still bugging me though is why the table would not hang
with the older version of org-mode. As far as I can tell nothing has
changed around tables between 9.5.2 and 9.5.4. Do you have any idea what
could cause the difference in behaviour?

Thanks again, and best regards

Christoph


On Thu, 28 Jul 2022, 16:55 Ihor Radchenko, <yantar92@gmail.com> wrote:

> Christoph Grabenstein <christoph.grabenstein@gmail.com> writes:
>
> > org-table-insert-row hangs if evil-leader is installed.
> >
> > Steps to reproduce:
> >
> > 1. Install org-mode 9.5.4, evil and evil-leader, and enable evil-mode
> > and global-evil-leader-mode.
> > 2. Open or create an org file that has a table like that:
> > ```
> > | header | another header |
> > ```
> > 3. Place your cursor in the header and hit enter (in evil insert mode).
> > 4. Emacs hangs in an endless loop, you will have to interrupt with C-g.
>
> Thanks for reporting!
>
> > - I'm not sure if this is an error on org's side or on evil's side.
> Please
> > let me know if I should open a ticket for evil.
> > - For more details see my question at the emacs stackexchange:
> >
> https://emacs.stackexchange.com/questions/72769/org-mode-tables-slowed-down-by-evil-mode
>
> Thanks for the link. Extra information from the link allowed me to
> narrow down the cause. The cause is in evil-mode.
>
> evil-local-mode is run in temporary buffer, which is OK. What is not OK
> is that evil-local-mode is altering the match data. It must not happen.
> Please report this issue to evil devs.
>
> Best,
> Ihor
>

[-- Attachment #2: Type: text/html, Size: 2690 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BUG] org-mode 9.5.4 with evil-leader leads to endless loop in table [9.5.4 (9.5.4-g6013cb1 @ /Users/cgrabenstein/.emacs.d/straight/build/org/)]
  2022-07-30  8:51   ` Christoph Grabenstein
@ 2022-07-30  8:56     ` Ihor Radchenko
  2022-07-30  9:14       ` Christoph Grabenstein
  0 siblings, 1 reply; 5+ messages in thread
From: Ihor Radchenko @ 2022-07-30  8:56 UTC (permalink / raw)
  To: Christoph Grabenstein; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

>
> One thing that's still bugging me though is why the table would not hang
> with the older version of org-mode. As far as I can tell nothing has
> changed around tables between 9.5.2 and 9.5.4. Do you have any idea what
> could cause the difference in behaviour?


`org-string-width` is now using temporary buffer to calculate width
precisely to pixels.

Best,
Ihor

>
>>
>>

[-- Attachment #2: Type: text/html, Size: 965 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BUG] org-mode 9.5.4 with evil-leader leads to endless loop in table [9.5.4 (9.5.4-g6013cb1 @ /Users/cgrabenstein/.emacs.d/straight/build/org/)]
  2022-07-30  8:56     ` Ihor Radchenko
@ 2022-07-30  9:14       ` Christoph Grabenstein
  0 siblings, 0 replies; 5+ messages in thread
From: Christoph Grabenstein @ 2022-07-30  9:14 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

That makes perfectly sense. Thank you!

On Sat, 30 Jul 2022, 10:55 Ihor Radchenko, <yantar92@gmail.com> wrote:

> One thing that's still bugging me though is why the table would not hang
>> with the older version of org-mode. As far as I can tell nothing has
>> changed around tables between 9.5.2 and 9.5.4. Do you have any idea what
>> could cause the difference in behaviour?
>
>
> `org-string-width` is now using temporary buffer to calculate width
> precisely to pixels.
>
> Best,
> Ihor
>
>>
>>>
>>>

[-- Attachment #2: Type: text/html, Size: 1339 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-07-30  9:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-27 18:45 [BUG] org-mode 9.5.4 with evil-leader leads to endless loop in table [9.5.4 (9.5.4-g6013cb1 @ /Users/cgrabenstein/.emacs.d/straight/build/org/)] Christoph Grabenstein
2022-07-28 14:56 ` Ihor Radchenko
2022-07-30  8:51   ` Christoph Grabenstein
2022-07-30  8:56     ` Ihor Radchenko
2022-07-30  9:14       ` Christoph Grabenstein

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).