emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Weird gap in agenda mode-line
@ 2021-11-12 23:26 Carlos Pita
  2021-11-14  7:26 ` Ihor Radchenko
  0 siblings, 1 reply; 8+ messages in thread
From: Carlos Pita @ 2021-11-12 23:26 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hi all,

in the *Org Agenda* buffer mode-line I'm seeing a weird gap that I
can't remember whether it was before or not. In the attached
screenshot the gap shows a different face than the rest. I don't know
under which circumstances this change of face happens but, in any
case, the extra space is always there (emacs -q) and there is some
combination in my setup that sometimes more obviously reveals it. I
don't know if that's a lighter with just a space on it or what.

Best regards,
Carlos

---

org-mode version: 9.5, release_9.5-68-g77e2ec (emacs-28 branch)

[-- Attachment #2: image.png --]
[-- Type: image/png, Size: 14956 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Weird gap in agenda mode-line
  2021-11-12 23:26 Weird gap in agenda mode-line Carlos Pita
@ 2021-11-14  7:26 ` Ihor Radchenko
  2021-11-14  7:32   ` Carlos Pita
  0 siblings, 1 reply; 8+ messages in thread
From: Ihor Radchenko @ 2021-11-14  7:26 UTC (permalink / raw)
  To: Carlos Pita; +Cc: emacs-orgmode

Carlos Pita <carlosjosepita@gmail.com> writes:

> Hi all,
>
> in the *Org Agenda* buffer mode-line I'm seeing a weird gap that I
> can't remember whether it was before or not.
> ...
> org-mode version: 9.5, release_9.5-68-g77e2ec (emacs-28 branch)

I am unable to reproduce

Best,
Ihor


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Weird gap in agenda mode-line
  2021-11-14  7:26 ` Ihor Radchenko
@ 2021-11-14  7:32   ` Carlos Pita
  2021-11-14  7:52     ` Ihor Radchenko
  2021-11-14 12:08     ` Eric S Fraga
  0 siblings, 2 replies; 8+ messages in thread
From: Carlos Pita @ 2021-11-14  7:32 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Hi Igor,

Have you checked that there is no extra space (I mean with the default
bg face) as in the attached image?

I've checked this now again with org main branch and emacs master
branch and the gap is still there.

Best regards,
Carlos

[-- Attachment #2: image.png --]
[-- Type: image/png, Size: 7924 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Weird gap in agenda mode-line
  2021-11-14  7:32   ` Carlos Pita
@ 2021-11-14  7:52     ` Ihor Radchenko
  2021-11-15  3:57       ` Carlos Pita
  2021-11-14 12:08     ` Eric S Fraga
  1 sibling, 1 reply; 8+ messages in thread
From: Ihor Radchenko @ 2021-11-14  7:52 UTC (permalink / raw)
  To: Carlos Pita; +Cc: emacs-orgmode

Carlos Pita <carlosjosepita@gmail.com> writes:

> Hi Igor,
>
> Have you checked that there is no extra space (I mean with the default
> bg face) as in the attached image?
>
> I've checked this now again with org main branch and emacs master
> branch and the gap is still there.

The extra space was there. However, it should have the same font. The
relevant code in org-agenda.el is:

(list "Org-Agenda"
	      (if (get 'org-agenda-files 'org-restrict) " []" "")
	      " " ;; <- this is the extra space
	      '(:eval (org-agenda-span-name org-agenda-current-span))
	      (if org-agenda-follow-mode     " Follow" "")
	      (if org-agenda-entry-text-mode " ETxt"   "")
	      (if org-agenda-include-diary   " Diary"  "")
	      (if org-agenda-include-deadlines " Ddl"  "")
	      (if org-agenda-use-time-grid   " Grid"   "")

This part of code has not been changed from 2010.

Best,
Ihor


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Weird gap in agenda mode-line
  2021-11-14  7:32   ` Carlos Pita
  2021-11-14  7:52     ` Ihor Radchenko
@ 2021-11-14 12:08     ` Eric S Fraga
  2021-11-17  5:43       ` Carlos Pita
  1 sibling, 1 reply; 8+ messages in thread
From: Eric S Fraga @ 2021-11-14 12:08 UTC (permalink / raw)
  To: Carlos Pita; +Cc: emacs-orgmode, Ihor Radchenko

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

I don't see this in my agenda view.  Image attached.

-- 
: Eric S Fraga, with org release_9.5-228-g577b98 in Emacs 29.0.50
: Latest paper written in org: https://arxiv.org/abs/2106.05096

[-- Attachment #2: screendump-20211114120656.png --]
[-- Type: image/png, Size: 6802 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Weird gap in agenda mode-line
  2021-11-14  7:52     ` Ihor Radchenko
@ 2021-11-15  3:57       ` Carlos Pita
  2021-11-16  7:37         ` Ihor Radchenko
  0 siblings, 1 reply; 8+ messages in thread
From: Carlos Pita @ 2021-11-15  3:57 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: emacs-orgmode

Hi Ihor (sorry I have been calling you Igor for a while now :p),

> (list "Org-Agenda"
>               (if (get 'org-agenda-files 'org-restrict) " []" "")
>               " " ;; <- this is the extra space
> [...]
> This part of code has not been changed from 2010.

Ok then, nevermind the highlight issue which is probably related to my
setup, what is reproducible is the "space issue" and the reason is
obvious now. That said, what is the point of the list? What is the
reason not to concatenate the parts into one single string? It
looks and feels weird as if each section had its own menu while it's
all the same thing.

Best regards,
Carlos


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Weird gap in agenda mode-line
  2021-11-15  3:57       ` Carlos Pita
@ 2021-11-16  7:37         ` Ihor Radchenko
  0 siblings, 0 replies; 8+ messages in thread
From: Ihor Radchenko @ 2021-11-16  7:37 UTC (permalink / raw)
  To: Carlos Pita; +Cc: emacs-orgmode

Carlos Pita <carlosjosepita@gmail.com> writes:

> ... That said, what is the point of the list? What is the
> reason not to concatenate the parts into one single string? It
> looks and feels weird as if each section had its own menu while it's
> all the same thing.

It is a list because mode-name is using format-mode-line :eval
constructs (see the docstring). Also, there is no need to concatenate
individual strings explicitly in mode-name list. One could do it, but
there will still be multiple string and :eval sections with their own
menus (AFAIU).

Best,
Ihor



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Weird gap in agenda mode-line
  2021-11-14 12:08     ` Eric S Fraga
@ 2021-11-17  5:43       ` Carlos Pita
  0 siblings, 0 replies; 8+ messages in thread
From: Carlos Pita @ 2021-11-17  5:43 UTC (permalink / raw)
  To: Org Mode List; +Cc: Ihor Radchenko

> I don't see this in my agenda view.  Image attached.

This is because there is a span in your case (Day). The space is still
there but it's not an extra one.

The space in:

              " " ;; <- this is the extra space
              '(:eval (org-agenda-span-name org-agenda-current-span))

should be conditional to the expression below evaluating to something
different than the empty string.

Best regards,
Carlos


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-11-17  5:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 23:26 Weird gap in agenda mode-line Carlos Pita
2021-11-14  7:26 ` Ihor Radchenko
2021-11-14  7:32   ` Carlos Pita
2021-11-14  7:52     ` Ihor Radchenko
2021-11-15  3:57       ` Carlos Pita
2021-11-16  7:37         ` Ihor Radchenko
2021-11-14 12:08     ` Eric S Fraga
2021-11-17  5:43       ` Carlos Pita

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).