From: Jay Kamat <jaygkamat@gmail.com>
To: fabio.leimgruber@posteo.eu
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Bug: export to markdown invalid URL
Date: Tue, 22 Aug 2017 17:50:18 -0400 [thread overview]
Message-ID: <CACe_Yv_yGY5tUQ3-3AnrX4dVUz7cj=7y6adqV7HJntokB60F7w@mail.gmail.com> (raw)
In-Reply-To: <CACe_Yv8DXuCJmk3a+xDfAY9wW3pva6BxypJfUUiKJ6s3HUpHPw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]
Hi again,
sorry for the repeated emails, but I think I've come up with a better
solution to this issue, to just use the raw link target in the target
of the markdown export, which I've attached to this email. Feel free
to pick either one of these patches or come up with something better.
Hope this gets fixed soon,
-Jay
On Tue, Aug 22, 2017 at 5:33 PM, Jay Kamat <jaygkamat@gmail.com> wrote:
> Hi,
>
> Thanks for catching that. That was my fault, for failing to test
> commit f3d7284ebd0c6e8248f7c3c444937270402b0ba6 properly.
>
> See http://lists.gnu.org/archive/html/emacs-orgmode/2017-08/msg00147.html
> for the previous thread.
>
> I've attached a trivial patch which appears to fix the issue for me,
> but I don't know if there's a cleaner way to do it or not (is there a
> link property that keeps the ':' in either the link or the type?).
>
> Thanks,
> -Jay
>
> On Tue, Aug 22, 2017 at 5:16 PM, Fabio Leimgruber
> <fabio.leimgruber@posteo.eu> wrote:
>> Hello everyone,
>>
>> using latest master, an org file containing just the link
>>
>> #+BEGIN_SRC org
>> [[http://orgmode.org/img/org-mode-unicorn-logo.png]]
>> #+END_SRC
>>
>> on export to markdown with =C-c C-e m m= produces the md file
>>
>> #+BEGIN_EXAMPLE
>> # Table of Contents
>>
>>
>>
>> 
>> #+END_EXAMPLE
>>
>> containing an invalid URL.
>>
>> Best Regards,
>>
>> --
>> Fabio Leimgruber
>>
[-- Attachment #2: 0001-ox-md.el-Fix-missing-in-exported-markdown-image-link.patch --]
[-- Type: text/x-patch, Size: 1177 bytes --]
From 743daf53843a29b1202553345b4fc298ac87c74e Mon Sep 17 00:00:00 2001
From: Jay Kamat <jaygkamat@gmail.com>
Date: Tue, 22 Aug 2017 17:28:28 -0400
Subject: [PATCH] ox-md.el: Fix missing ':' in exported markdown image links
* lisp/ox-md.el (org-md-link): Use raw-link for markdown link target
instead of merging type and raw-path
---
lisp/ox-md.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/ox-md.el b/lisp/ox-md.el
index 0dd1be095..9afb5227e 100644
--- a/lisp/ox-md.el
+++ b/lisp/ox-md.el
@@ -431,8 +431,9 @@ a communication channel."
description
(org-export-get-reference destination info))))))))
((org-export-inline-image-p link org-html-inline-image-rules)
- (let ((path (let ((raw-path (org-element-property :path link)))
- (cond ((not (equal "file" type)) (concat type raw-path))
+ (let ((path (let ((raw-path (org-element-property :path link))
+ (raw-link (org-element-property :raw-link link)))
+ (cond ((not (equal "file" type)) raw-link)
((not (file-name-absolute-p raw-path)) raw-path)
(t (expand-file-name raw-path)))))
(caption (org-export-data
--
2.11.0
next prev parent reply other threads:[~2017-08-22 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 21:16 Bug: export to markdown invalid URL Fabio Leimgruber
2017-08-22 21:33 ` Jay Kamat
2017-08-22 21:47 ` Nicolas Goaziou
2017-08-22 21:50 ` Jay Kamat [this message]
2017-08-22 22:31 ` Nicolas Goaziou
2017-08-23 2:27 ` Jay Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACe_Yv_yGY5tUQ3-3AnrX4dVUz7cj=7y6adqV7HJntokB60F7w@mail.gmail.com' \
--to=jaygkamat@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=fabio.leimgruber@posteo.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).