From: Jay Kamat <jaygkamat@gmail.com>
To: fabio.leimgruber@posteo.eu
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Bug: export to markdown invalid URL
Date: Tue, 22 Aug 2017 17:33:50 -0400 [thread overview]
Message-ID: <CACe_Yv8DXuCJmk3a+xDfAY9wW3pva6BxypJfUUiKJ6s3HUpHPw@mail.gmail.com> (raw)
In-Reply-To: <357ecb77-e9a1-2183-c9de-218a69a23893@posteo.eu>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
Hi,
Thanks for catching that. That was my fault, for failing to test
commit f3d7284ebd0c6e8248f7c3c444937270402b0ba6 properly.
See http://lists.gnu.org/archive/html/emacs-orgmode/2017-08/msg00147.html
for the previous thread.
I've attached a trivial patch which appears to fix the issue for me,
but I don't know if there's a cleaner way to do it or not (is there a
link property that keeps the ':' in either the link or the type?).
Thanks,
-Jay
On Tue, Aug 22, 2017 at 5:16 PM, Fabio Leimgruber
<fabio.leimgruber@posteo.eu> wrote:
> Hello everyone,
>
> using latest master, an org file containing just the link
>
> #+BEGIN_SRC org
> [[http://orgmode.org/img/org-mode-unicorn-logo.png]]
> #+END_SRC
>
> on export to markdown with =C-c C-e m m= produces the md file
>
> #+BEGIN_EXAMPLE
> # Table of Contents
>
>
>
> 
> #+END_EXAMPLE
>
> containing an invalid URL.
>
> Best Regards,
>
> --
> Fabio Leimgruber
>
[-- Attachment #2: 0001-ox-md.el-Fix-missing-in-exported-markdown-image-link.patch --]
[-- Type: text/x-patch, Size: 1014 bytes --]
From 5d92257575e497e0955b3414fb1e1a69e5ea97f8 Mon Sep 17 00:00:00 2001
From: Jay Kamat <jaygkamat@gmail.com>
Date: Tue, 22 Aug 2017 17:28:28 -0400
Subject: [PATCH] ox-md.el: Fix missing ':' in exported markdown image links
* lisp/ox-md.el (org-md-link): Append ':' to the type of non-file
image links.
---
lisp/ox-md.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/ox-md.el b/lisp/ox-md.el
index 0dd1be095..ac94ba648 100644
--- a/lisp/ox-md.el
+++ b/lisp/ox-md.el
@@ -432,7 +432,7 @@ a communication channel."
(org-export-get-reference destination info))))))))
((org-export-inline-image-p link org-html-inline-image-rules)
(let ((path (let ((raw-path (org-element-property :path link)))
- (cond ((not (equal "file" type)) (concat type raw-path))
+ (cond ((not (equal "file" type)) (concat type ":" raw-path))
((not (file-name-absolute-p raw-path)) raw-path)
(t (expand-file-name raw-path)))))
(caption (org-export-data
--
2.11.0
next prev parent reply other threads:[~2017-08-22 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 21:16 Bug: export to markdown invalid URL Fabio Leimgruber
2017-08-22 21:33 ` Jay Kamat [this message]
2017-08-22 21:47 ` Nicolas Goaziou
2017-08-22 21:50 ` Jay Kamat
2017-08-22 22:31 ` Nicolas Goaziou
2017-08-23 2:27 ` Jay Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACe_Yv8DXuCJmk3a+xDfAY9wW3pva6BxypJfUUiKJ6s3HUpHPw@mail.gmail.com \
--to=jaygkamat@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=fabio.leimgruber@posteo.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).