emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Skip Collins <skip.collins@gmail.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: [Bug] commit 39070b7fc7 breaks babel test
Date: Tue, 3 Dec 2013 14:09:59 -0500	[thread overview]
Message-ID: <CABUh-76LSR=oh77jBBUSe_3w2JFQv74TK_sY8XBAO3T-cG3A8A@mail.gmail.com> (raw)
In-Reply-To: <87eh622s3g.fsf@Rainer.invalid>

It's been a week and this test still fails.

Would it make sense to automatically enforce passing all tests before
git accepts a change?

On Wed, Nov 27, 2013 at 2:58 AM, Achim Gratz <Stromeko@nexgo.de> wrote:
> Hi Eric,
> this change seems to introduce additional line breaks in the following
> test:
> --8<---------------cut here---------------start------------->8---
> Test test-ob/catches-all-references condition:
>     (ert-test-failed
>      ((should
>        (string=
>         (org-babel-execute-src-block)
>         "A literal example\non two lines for me."))
>       :form
>       (string= "A literal example\non two lines\n for me." "A literal example\non two lines for me.")
>       :value nil))
>    FAILED  1/1  test-ob/catches-all-references
> --8<---------------cut here---------------end--------------->8---
> This seems to happen because the final \n from the babel result is not
> stripped anymore, pointing to the change in ob-core.  IIRC we
> flip-flopped a few times already with including or not including this
> final newline, so I don't know whether the code or the test should
> change.

  reply	other threads:[~2013-12-03 19:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27  7:58 [Bug] commit 39070b7fc7 breaks babel test Achim Gratz
2013-12-03 19:09 ` Skip Collins [this message]
2013-12-06 19:05   ` Eric Schulte
2013-12-06 19:47     ` Achim Gratz
2013-12-07  2:27       ` Eric Schulte
2013-12-07  8:56         ` Achim Gratz
2013-12-06 20:51     ` Skip Collins
2013-12-06 21:48       ` Bastien
2013-12-07  2:31       ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABUh-76LSR=oh77jBBUSe_3w2JFQv74TK_sY8XBAO3T-cG3A8A@mail.gmail.com' \
    --to=skip.collins@gmail.com \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).