emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: [Bug] commit 39070b7fc7 breaks babel test
Date: Sat, 07 Dec 2013 09:56:16 +0100	[thread overview]
Message-ID: <87k3fh9gzz.fsf@Rainer.invalid> (raw)
In-Reply-To: 87zjod2xz2.fsf@gmail.com

Eric Schulte writes:
> This test (test-ob/catches-all-references) is from commit c21692506d8,
> which doesn't have anything to do with newlines (judging from the commit
> message).
> To me the more natural behavior is to include the newline in the
> expansion.  Maybe we have discussed this before on list, and decided
> stripping the newline was preferable, but I don't recall that
> discussion.

I seem to have misremembered.  Anyway, when you committed that test you
apparently thought it was more natural to leave the trailing newline
out.  I'm not using such constructs myself, but changing this behaviour
more than two years later carries a risk that people have documents that
rely on it, for good or bad reasons.

> Just because behavior ends up being encoded in a test doesn't
> necessarily mean the behavior is correct.  I think as test suites
> attempt to protect the desired behavior they often end up also
> protecting incidental behavior of the implementation at the time the
> test was written.

Well, a test test should proof the specification is implemented
correctly.  This is exactly why test methodology has evolved to unit
tests, which mostly avoids testing for incident behaviour or emergent

+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:

  reply	other threads:[~2013-12-07  8:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27  7:58 [Bug] commit 39070b7fc7 breaks babel test Achim Gratz
2013-12-03 19:09 ` Skip Collins
2013-12-06 19:05   ` Eric Schulte
2013-12-06 19:47     ` Achim Gratz
2013-12-07  2:27       ` Eric Schulte
2013-12-07  8:56         ` Achim Gratz [this message]
2013-12-06 20:51     ` Skip Collins
2013-12-06 21:48       ` Bastien
2013-12-07  2:31       ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3fh9gzz.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).